[GitHub] [netbeans] dukescript commented on a change in pull request #1280: Java with Maven -> Java Frontend App + MOE is broken since Gradle support introduced

[GitBox <gi...@apache.org>]

dukescript commented on a change in pull request #1280: Java with Maven -> Java Frontend App + MOE is broken since Gradle support introduced
URL: https://github.com/apache/netbeans/pull/1280#discussion_r289644882
 
 

 ##########
 File path: groovy/gradle/src/org/netbeans/modules/gradle/NbGradleProjectFactory.java
 ##########
 @@ -47,24 +47,31 @@
 
     @Override
     public boolean isProject(FileObject dir) {
-        boolean ret = FileUtil.toFile(dir) != null;
-        if (ret) {
-            FileObject pom = dir.getFileObject("pom.xml"); //NOI18N
-            if ((pom != null) && pom.isData() && GradleSettings.getDefault().isPreferMaven()) {
-                ret = false;
-            } else {
-                File suspect = FileUtil.toFile(dir);
-                GradleFiles files = new GradleFiles(suspect);
-                if (!files.isRootProject()) {
-                    Boolean inSubDirCache = GradleProjectCache.isKnownSubProject(files.getRootDir(), suspect);
-                    ret = inSubDirCache != null ? inSubDirCache : files.isProject();
-                } else {
-                    ret = true;
-                }
+        return isProjectCheck(dir, GradleSettings.getDefault().isPreferMaven());
 
 Review comment:
   What exactly do you want? I don't understand.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists