[GitHub] [cloudstack] anuragaw commented on a change in pull request #3318: Fixed: User not allowed to tag project created by him

[GitBox <gi...@apache.org>]

anuragaw commented on a change in pull request #3318: Fixed: User not allowed to tag project created by him
URL: https://github.com/apache/cloudstack/pull/3318#discussion_r282046607
 
 

 ##########
 File path: server/src/com/cloud/tags/TaggedResourceManagerImpl.java
 ##########
 @@ -215,6 +215,10 @@ public long getResourceId(String resourceId, ResourceObjectType resourceType) {
             }
         }
 
+        if (resourceType == ResourceObjectType.Project) {
+            accountId = ((ProjectVO)entity).getProjectAccountId();
 
 Review comment:
   Couple of questions -
   1) Is it safe to assume the project account id will map to the user who created the project? Looks like it is set up from the passed parameter to Create Project Command. 
   2) What happens to the projects created directly via command line. Do they work as expected? (Asking this as it is missing in the tests conducted in the PR Description.)
   
   Also, the bug of users not being able to tag their resources extends to some other types of resources (as far as I recall in the mailing lists) but I guess we should file an open issue for others as it would be outside the scope of the current issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services