You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/07/07 11:46:26 UTC
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/563
ui: Allow UI plugins to be shown on navigation bar
Introduces a boolean option in UI plugins setting it to 'true' would display
the UI plugin on the left navigation bar.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/cloudstack 4.5-ui-plugin-enhancement
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/563.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #563
----
commit f8693d24a42dc806c67a4b12731b0ea20f6bd791
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2015-07-07T09:31:12Z
ui: Allow UI plugins to be shown on navigation bar
Introduces a boolean option in UI plugins setting it to 'true' would display
the UI plugin on the left navigation bar.
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/563
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/563#issuecomment-119875445
+1 LGTM (self)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/563#issuecomment-119889147
UI is not really my thing, but given the logic applied and the code itself, LGTM too.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/563#issuecomment-119893211
@karuturi fair point, will add a JIRA ticket tracking this. Will re-push with the JIRA ID and merge.
IMO one should be able to cast reviews, the minimum two LGTM requirements can be hard to enforce in an opensource community, no?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: ui: Allow UI plugins to be
shown on navig...
Posted by Rohit Yadav <ro...@shapeblue.com>.
On 09-Jul-2015, at 3:21 pm, Daan Hoogland <da...@gmail.com>> wrote:
I think I look good to myself as well ;}
On Thu, Jul 9, 2015 at 11:44 AM, karuturi <gi...@git.apache.org>> wrote:
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/563#issuecomment-119891522
+1 changes looks good. but, a jira ticket is required. Also, I dont think you can self vote ;)
That was an attempt to gain some attention on the PR, glad it worked ;)
Regards,
Rohit Yadav
Software Architect, ShapeBlue
[cid:9DD97B41-04C5-45F0-92A7-951F3E962F7A]
M. +91 88 262 30892 | rohit.yadav@shapeblue.com<ma...@shapeblue.com>
Blog: bhaisaab.org<http://bhaisaab.org> | Twitter: @_bhaisaab
Find out more about ShapeBlue and our range of CloudStack related services
IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//>
CSForge - rapid IaaS deployment framework<http://shapeblue.com/csforge/>
CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/>
CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-engineering/>
CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/>
CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/>
This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
Re: [GitHub] cloudstack pull request: ui: Allow UI plugins to be
shown on navig...
Posted by Daan Hoogland <da...@gmail.com>.
I think I look good to myself as well ;}
On Thu, Jul 9, 2015 at 11:44 AM, karuturi <gi...@git.apache.org> wrote:
> Github user karuturi commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/563#issuecomment-119891522
>
> +1 changes looks good. but, a jira ticket is required. Also, I dont think you can self vote ;)
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
--
Daan
[GitHub] cloudstack pull request: ui: Allow UI plugins to be shown on navig...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/563#issuecomment-119891522
+1 changes looks good. but, a jira ticket is required. Also, I dont think you can self vote ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---