You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Andrea Del Bene (JIRA)" <ji...@apache.org> on 2015/02/16 17:40:12 UTC

[jira] [Comment Edited] (WICKET-5835) InlineEnclosure doesn't call child.configure() before updating its visilbity

    [ https://issues.apache.org/jira/browse/WICKET-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14322968#comment-14322968 ] 

Andrea Del Bene edited comment on WICKET-5835 at 2/16/15 4:39 PM:
------------------------------------------------------------------

Thank you for the quickstart. To me this is not a problem with Wicket but with the way you use to decide the visibility for the inline internal component. Variable 'visible1' is used to determinate component's visibility but it is set only when onConfigure is called, hence the component is always invisible to the inline container.
Just replace the onconfigure method with this version of isVisible:

```
public boolean isVisible() {
 	return visible1;
 };
//            @Override
//            protected void onConfigure() {
//                super.onConfigure();
//
//                setVisible(visible1);
//            }
```
in this way the internal component's visibility reflects the visible1 flag.


was (Author: bitstorm):
Thank you for the quickstart. To me this is not a problem with Wicket but with the way you use to decide the visibility for the inline internal component. Variable 'visible1' is used to determinate component's visibility but it is set only when onConfigure is called, hence the component is always invisible to the inline container.
Just replace the onconfigure method with this version of isVisible:

```java
public boolean isVisible() {
 	return visible1;
 };
//            @Override
//            protected void onConfigure() {
//                super.onConfigure();
//
//                setVisible(visible1);
//            }
```
in this way the internal component's visibility reflects the visible1 flag.

> InlineEnclosure doesn't call child.configure() before updating its visilbity
> ----------------------------------------------------------------------------
>
>                 Key: WICKET-5835
>                 URL: https://issues.apache.org/jira/browse/WICKET-5835
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.19.0
>         Environment: Any
>            Reporter: Raoul Zander
>            Assignee: Andrea Del Bene
>            Priority: Minor
>              Labels: enclosure
>         Attachments: enclosure-quickstart.zip
>
>
> org.apache.wicket.markup.html.internal.InlineEnclosure.updateVisibility()
> should propably call child.configure() before the visibility of the InlineEnclosure is set to the visibility of the child.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)