You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Duo Zhang (Jira)" <ji...@apache.org> on 2024/12/16 14:21:00 UTC

[jira] [Resolved] (HBASE-29014) The RegionServer metrics of WALs is incorrect

     [ https://issues.apache.org/jira/browse/HBASE-29014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Duo Zhang resolved HBASE-29014.
-------------------------------
    Fix Version/s: 3.0.0-beta-2
     Hadoop Flags: Reviewed
         Assignee: guluo
       Resolution: Fixed

Pushed to master and branch-3.

Thanks [~guluo] for contributing!

> The RegionServer metrics of WALs is incorrect
> ---------------------------------------------
>
>                 Key: HBASE-29014
>                 URL: https://issues.apache.org/jira/browse/HBASE-29014
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>         Environment: master
>            Reporter: guluo
>            Assignee: guluo
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.0.0-beta-2
>
>
> RegionServer Metrics of wals (file count and file size) is incorrect.
> We should should recalculate every time, rather than continuously accumulating them.
>  
> // MetricsRegionServerWrapperImpl.RegionServerMetricsWrapperRunnable.run()
> List<WALProvider> providers = regionServer.getWalFactory().getAllWALProviders();
> for (WALProvider provider : providers) {
>     numWALFiles += provider.getNumLogFiles();
>     walFileSize += provider.getLogFileSize();
> }



--
This message was sent by Atlassian Jira
(v8.20.10#820010)