You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/07/22 04:35:11 UTC
[GitHub] [james-project] quantranhong1999 opened a new pull request #547: JAMES-3516 Update upgrade instructions follow adding threadId to ElasticSearch breaking change
quantranhong1999 opened a new pull request #547:
URL: https://github.com/apache/james-project/pull/547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #547: JAMES-3516 Update upgrade instructions follow adding threadId to ElasticSearch breaking change
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #547:
URL: https://github.com/apache/james-project/pull/547#discussion_r674497074
##########
File path: upgrade-instructions.md
##########
@@ -15,9 +15,33 @@ Note: this section is in progress. It will be updated during all the development
Changes to apply between 3.6.x and 3.7.x will be reported here.
Change list:
-
+ - [Adding the threadId to the ElasticSearch index](#adding-the-threadid-to-the-elasticsearch-index)
- [Rework message denormalization](#rework-message-denormalization)
+### Adding the threadId to the ElasticSearch index
+
+Date 22/07/2021
+
+JIRA: https://issues.apache.org/jira/browse/JAMES-3516
+
+Concerned product: Distributed James
+
+Add threadId to James document mapping to enable thread query search.
+
+We already tell ElasticSearch how to index this new field for future document by the code, but we need to explicitly add this field to existing backing indices by doing:
Review comment:
```suggestion
We alreadyhave this field as part of newly created mappings, but we need to explicitly add this field to existing indices by doing:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #547: JAMES-3516 Update upgrade instructions follow adding threadId to ElasticSearch breaking change
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #547:
URL: https://github.com/apache/james-project/pull/547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #547: JAMES-3516 Update upgrade instructions follow adding threadId to ElasticSearch breaking change
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #547:
URL: https://github.com/apache/james-project/pull/547#discussion_r674499787
##########
File path: upgrade-instructions.md
##########
@@ -15,9 +15,33 @@ Note: this section is in progress. It will be updated during all the development
Changes to apply between 3.6.x and 3.7.x will be reported here.
Change list:
-
+ - [Adding the threadId to the ElasticSearch index](#adding-the-threadid-to-the-elasticsearch-index)
- [Rework message denormalization](#rework-message-denormalization)
Review comment:
While we are at it `### Adding threadId column to message metadata tables` is missing from this menu...
Can you add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org