You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/16 23:19:26 UTC
[GitHub] [arrow-datafusion] xudong963 opened a new pull request, #2741: improve: supports user-defined `scale_factor` for dbgen
xudong963 opened a new pull request, #2741:
URL: https://github.com/apache/arrow-datafusion/pull/2741
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
No
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
1. clean some old docs and scripts
2. support user-defined `scale_factor` for dbgen
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2741: improve: supports user-defined `scale_factor` for dbgen
Posted by GitBox <gi...@apache.org>.
andygrove commented on code in PR #2741:
URL: https://github.com/apache/arrow-datafusion/pull/2741#discussion_r899737401
##########
benchmarks/tpch-gen.sh:
##########
@@ -21,7 +21,12 @@
pushd ..
. ./dev/build-set-env.sh
popd
-docker build -t datafusion-tpchgen:$DATAFUSION_VERSION -f tpchgen.dockerfile .
+
+if [[ -z $1 ]]; then
+ docker build -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION .
+ else
+ docker build -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION --build-arg scale_factor=$1 .
Review Comment:
Is there a way we can just pass the scale factor as an argument in `docker run` rather than building the image differently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2741: improve: supports user-defined `scale_factor` for dbgen
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2741:
URL: https://github.com/apache/arrow-datafusion/pull/2741#issuecomment-1159351402
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2741?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2741](https://codecov.io/gh/apache/arrow-datafusion/pull/2741?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d2e9f61) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/8adc1b60b4410739f75247d3d5687a30e3c9d108?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8adc1b6) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2741 +/- ##
==========================================
- Coverage 84.93% 84.92% -0.01%
==========================================
Files 270 270
Lines 47915 47915
==========================================
- Hits 40695 40693 -2
- Misses 7220 7222 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/2741?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/core/src/physical\_plan/metrics/value.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9waHlzaWNhbF9wbGFuL21ldHJpY3MvdmFsdWUucnM=) | `86.93% <0.00%> (-0.51%)` | :arrow_down: |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `73.91% <0.00%> (-0.40%)` | :arrow_down: |
| [datafusion/optimizer/src/utils.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2741/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9vcHRpbWl6ZXIvc3JjL3V0aWxzLnJz) | `34.21% <0.00%> (+0.52%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2741?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2741?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8adc1b6...d2e9f61](https://codecov.io/gh/apache/arrow-datafusion/pull/2741?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] avantgardnerio commented on a diff in pull request #2741: improve: supports user-defined `scale_factor` for dbgen
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on code in PR #2741:
URL: https://github.com/apache/arrow-datafusion/pull/2741#discussion_r901168800
##########
benchmarks/tpch-gen.sh:
##########
@@ -21,14 +21,15 @@
pushd ..
. ./dev/build-set-env.sh
popd
-docker build -t datafusion-tpchgen:$DATAFUSION_VERSION -f tpchgen.dockerfile .
+
+docker build -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION .
# Generate data into the ./data directory if it does not already exist
FILE=./data/supplier.tbl
if test -f "$FILE"; then
echo "$FILE exists."
else
mkdir data 2>/dev/null
- docker run -v `pwd`/data:/data -it --rm datafusion-tpchgen:$DATAFUSION_VERSION
Review Comment:
I created PR #2752 to resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #2741: improve: supports user-defined `scale_factor` for dbgen
Posted by GitBox <gi...@apache.org>.
xudong963 commented on code in PR #2741:
URL: https://github.com/apache/arrow-datafusion/pull/2741#discussion_r900687864
##########
benchmarks/tpch-gen.sh:
##########
@@ -21,7 +21,12 @@
pushd ..
. ./dev/build-set-env.sh
popd
-docker build -t datafusion-tpchgen:$DATAFUSION_VERSION -f tpchgen.dockerfile .
+
+if [[ -z $1 ]]; then
+ docker build -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION .
+ else
+ docker build -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION --build-arg scale_factor=$1 .
Review Comment:
fixed @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #2741: improve: supports user-defined `scale_factor` for dbgen
Posted by GitBox <gi...@apache.org>.
andygrove merged PR #2741:
URL: https://github.com/apache/arrow-datafusion/pull/2741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] avantgardnerio commented on a diff in pull request #2741: improve: supports user-defined `scale_factor` for dbgen
Posted by GitBox <gi...@apache.org>.
avantgardnerio commented on code in PR #2741:
URL: https://github.com/apache/arrow-datafusion/pull/2741#discussion_r901166971
##########
benchmarks/tpch-gen.sh:
##########
@@ -21,14 +21,15 @@
pushd ..
. ./dev/build-set-env.sh
popd
-docker build -t datafusion-tpchgen:$DATAFUSION_VERSION -f tpchgen.dockerfile .
+
+docker build -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION .
# Generate data into the ./data directory if it does not already exist
FILE=./data/supplier.tbl
if test -f "$FILE"; then
echo "$FILE exists."
else
mkdir data 2>/dev/null
- docker run -v `pwd`/data:/data -it --rm datafusion-tpchgen:$DATAFUSION_VERSION
Review Comment:
This change specifically breaks the volume mount for me. It appears the docker syntax expects the `imagename:version args` to come last, and putting it before the `-v` causes the `-v` to be interpreted as an argument to the script, not a volume mount. As such, the files are generated into an unbound volume and deleted when the container is destroyed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #2741: improve: supports user-defined `scale_factor` for dbgen
Posted by GitBox <gi...@apache.org>.
xudong963 commented on code in PR #2741:
URL: https://github.com/apache/arrow-datafusion/pull/2741#discussion_r900635837
##########
benchmarks/tpch-gen.sh:
##########
@@ -21,7 +21,12 @@
pushd ..
. ./dev/build-set-env.sh
popd
-docker build -t datafusion-tpchgen:$DATAFUSION_VERSION -f tpchgen.dockerfile .
+
+if [[ -z $1 ]]; then
+ docker build -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION .
+ else
+ docker build -f tpchgen.dockerfile -t datafusion-tpchgen:$DATAFUSION_VERSION --build-arg scale_factor=$1 .
Review Comment:
I'll try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org