You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "navinko (via GitHub)" <gi...@apache.org> on 2023/02/01 18:12:08 UTC

[GitHub] [ozone] navinko commented on a diff in pull request #3943: HDDS-6736. Provided consistent CLI options

navinko commented on code in PR #3943:
URL: https://github.com/apache/ozone/pull/3943#discussion_r1093572561


##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/datanode/ListInfoSubcommand.java:
##########
@@ -46,8 +46,9 @@ public class ListInfoSubcommand extends ScmSubcommand {
       defaultValue = "")
   private String ipaddress;
 
-  @CommandLine.Option(names = {"--id"},
-      description = "Show info by datanode UUID.",
+  @CommandLine.Option(names = {"--id", "--uuid"},
+      description = "Show info by datanode UUID. Command line option --id " +
+          "will be removed in later versions.",

Review Comment:
   Hi @adoroszlai Thank you for reviewing the changes. Will drop the comments from the PR changeset. But it seems we have some existing Command options where such comments do exist . Do i need to remove the comment from everywhere in ozone?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org