You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/08/26 04:39:27 UTC
[GitHub] [arrow] arw2019 opened a new pull request #8055: ARROW-7226: [Python][Doc] Add note re: JSON format support
arw2019 opened a new pull request #8055:
URL: https://github.com/apache/arrow/pull/8055
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #8055: ARROW-7226: [Python][Doc] Add note re: JSON format support
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #8055:
URL: https://github.com/apache/arrow/pull/8055#issuecomment-685704719
Thanks @arw2019 !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #8055: ARROW-7226: [Python][Doc] Add note re: JSON format support
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #8055:
URL: https://github.com/apache/arrow/pull/8055#issuecomment-680919060
> Why would you expect something else?
Because this is not a default "JSON" file, and many people will expect a "json reader" to support that.
I know it is already mentioned in the text, but given this expectation, I think it is fine to have an additional explicit note about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8055: ARROW-7226: [Python][Doc] Add note re: JSON format support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8055:
URL: https://github.com/apache/arrow/pull/8055#issuecomment-680611318
https://issues.apache.org/jira/browse/ARROW-7226
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on a change in pull request #8055: ARROW-7226: [Python][Doc] Add note re: JSON format support
Posted by GitBox <gi...@apache.org>.
arw2019 commented on a change in pull request #8055:
URL: https://github.com/apache/arrow/pull/8055#discussion_r481684892
##########
File path: docs/source/python/json.rst
##########
@@ -38,6 +38,9 @@ The features currently offered are the following:
such as ``my_data.json.gz``)
* sophisticated type inference (see below)
+.. note::
+ Currently only the line-delimited JSON (JSON-LD) format is supported.
Review comment:
That makes sense! I've removed these references to LD-JSON in the new commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8055: ARROW-7226: [Python][Doc] Add note re: JSON format support
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #8055:
URL: https://github.com/apache/arrow/pull/8055#discussion_r481010701
##########
File path: docs/source/python/json.rst
##########
@@ -38,6 +38,9 @@ The features currently offered are the following:
such as ``my_data.json.gz``)
* sophisticated type inference (see below)
+.. note::
+ Currently only the line-delimited JSON (JSON-LD) format is supported.
Review comment:
I wouldn't use JSON-LD here (and the same in the docstring).
My previous comment might have been worded a bit confusingly, but JSON-LD is the abbreviation for JSON-Linked Data, and searching for LDJSON ended up at pages about JSON-LD (which I raised as a argument to not use LDJSON). Given the variation in abbreviations used, maybe we can just leave out any abbreviation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche closed pull request #8055: ARROW-7226: [Python][Doc] Add note re: JSON format support
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #8055:
URL: https://github.com/apache/arrow/pull/8055
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8055: ARROW-7226: [Python][Doc] Add note re: JSON format support
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8055:
URL: https://github.com/apache/arrow/pull/8055#issuecomment-680891968
Is this useful? The paragraph above contains this sentence:
> a JSON file consists of multiple JSON objects, one per line, representing individual data rows
Why would you expect something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8055: ARROW-7226: [Python][Doc] Add note re: JSON format support
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #8055:
URL: https://github.com/apache/arrow/pull/8055#discussion_r477352442
##########
File path: docs/source/python/json.rst
##########
@@ -38,6 +38,9 @@ The features currently offered are the following:
such as ``my_data.json.gz``)
* sophisticated type inference (see below)
+.. note::
+ Currently only the line-delimited JSON (LDJSON) format is supported.
Review comment:
I am not sure how common the "LDJSON" abbreviation is. If you google that, I rather get hits for JSON-LD, which is json for linked data.
Searching for line delimited json gives "newline-delimited JSON (NDJSON)" (http://ndjson.org/) and "JSON Lines" (http://jsonlines.org/). Wiki mentions all three terms, though: https://en.wikipedia.org/wiki/JSON_streaming#Line-delimited_JSON
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org