You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "LiuYuHui (via GitHub)" <gi...@apache.org> on 2023/10/07 15:16:55 UTC
[PR] [WIP] Implement Xreadgroup [kvrocks]
LiuYuHui opened a new pull request, #1795:
URL: https://github.com/apache/kvrocks/pull/1795
This PR is still in a very early stage, it is not ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Implement Xreadgroup [kvrocks]
Posted by "LiuYuHui (via GitHub)" <gi...@apache.org>.
LiuYuHui commented on code in PR #1795:
URL: https://github.com/apache/kvrocks/pull/1795#discussion_r1371836350
##########
src/types/redis_stream_base.h:
##########
@@ -167,12 +174,21 @@ struct StreamConsumerGroupMetadata {
StreamEntryID last_delivered_id;
int64_t entries_read = 0;
uint64_t lag = 0;
+ StreamEntryID max_pending_entry_id;
};
struct StreamConsumerMetadata {
uint64_t pending_number = 0;
uint64_t last_idle;
uint64_t last_active;
+ StreamEntryID min_pending_entry_id;
+ StreamEntryID max_pending_entry_id;
Review Comment:
Hi @Yangsx-1, currently I only record `min_entry_id/max_entry_id` in stream consumer metadata, because If put every every entry in metadata, it will make the metadata very big. But I am not sure the current design is efficient when I want to read entries in PEL, I have to iterate the elements range from `min_entry_id` and `max_entry_id`, maybe it will be too slow. Do you have any suggestions about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Implement Xreadgroup [kvrocks]
Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on PR #1795:
URL: https://github.com/apache/kvrocks/pull/1795#issuecomment-1778622218
Hi @LiuYuHui , how's it going now? Feel free to ask question if you have any problems. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Implement Xreadgroup [kvrocks]
Posted by "LiuYuHui (via GitHub)" <gi...@apache.org>.
LiuYuHui commented on PR #1795:
URL: https://github.com/apache/kvrocks/pull/1795#issuecomment-1779191459
> Hi @LiuYuHui , how's it going now? Feel free to ask question if you have any problems. :)
Hi @Yangsx-1, thanks for asking, I was a bit busy in previous weeks, but recently I found some time, and will continue to work on this PR :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Implement Xreadgroup [kvrocks]
Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on code in PR #1795:
URL: https://github.com/apache/kvrocks/pull/1795#discussion_r1372511994
##########
src/types/redis_stream_base.h:
##########
@@ -167,12 +174,21 @@ struct StreamConsumerGroupMetadata {
StreamEntryID last_delivered_id;
int64_t entries_read = 0;
uint64_t lag = 0;
+ StreamEntryID max_pending_entry_id;
};
struct StreamConsumerMetadata {
uint64_t pending_number = 0;
uint64_t last_idle;
uint64_t last_active;
+ StreamEntryID min_pending_entry_id;
+ StreamEntryID max_pending_entry_id;
Review Comment:
Yes, it is a little inefficient. But only XPENDING and XINFO commands need to iterate the whole elements, and XACK, XCLAIM will only have o(1) complexity in this design, I think it's ok for now. @LiuYuHui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Implement Xreadgroup [kvrocks]
Posted by "Yangsx-1 (via GitHub)" <gi...@apache.org>.
Yangsx-1 commented on PR #1795:
URL: https://github.com/apache/kvrocks/pull/1795#issuecomment-1820310043
Hi @LiuYuHui , is there any progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Implement Xreadgroup [kvrocks]
Posted by "LiuYuHui (via GitHub)" <gi...@apache.org>.
LiuYuHui commented on PR #1795:
URL: https://github.com/apache/kvrocks/pull/1795#issuecomment-1826542768
> Hi @LiuYuHui , is there any progress?
Hi @Yangsx-1 Apologies for the delayed response. I am currently occupied with other commitments, and unfortunately, I won't be able to continue with this PR at the moment. Please ingore this PR, I apologize for any inconvenience this may cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Implement Xreadgroup [kvrocks]
Posted by "LiuYuHui (via GitHub)" <gi...@apache.org>.
LiuYuHui closed pull request #1795: [WIP] Implement Xreadgroup
URL: https://github.com/apache/kvrocks/pull/1795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org