You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/12/01 14:28:30 UTC
(commons-validator) 02/23: Fix SpotBugs [ERROR] High: Found reliance on default encoding in org.apache.commons.validator.ValidatorAction.readJavascriptFile(String): new java.io.InputStreamReader(InputStream) [org.apache.commons.validator.ValidatorAction] At ValidatorAction.java:[line 428] DM_DEFAULT_ENCODING.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git
commit f4aafcfa820cb30bd69031bb7bab383afd109bef
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Dec 1 07:55:00 2023 -0500
Fix SpotBugs [ERROR] High: Found reliance on default encoding in
org.apache.commons.validator.ValidatorAction.readJavascriptFile(String):
new java.io.InputStreamReader(InputStream)
[org.apache.commons.validator.ValidatorAction] At
ValidatorAction.java:[line 428] DM_DEFAULT_ENCODING.
---
src/changes/changes.xml | 3 +++
src/main/java/org/apache/commons/validator/ValidatorAction.java | 3 ++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 19613d83..18b33169 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -90,6 +90,9 @@ The <action> type attribute can be add,update,fix,remove.
<action type="fix" dev="ggregory" due-to="Gary Gregory">
Fix SpotBugs [ERROR] High: Class org.apache.commons.validator.ValidatorAction defines non-transient non-serializable instance field validationMethod [org.apache.commons.validator.ValidatorAction] In ValidatorAction.java SE_BAD_FIELD.
</action>
+ <action type="fix" dev="ggregory" due-to="Gary Gregory">
+ Fix SpotBugs [ERROR] High: Found reliance on default encoding in org.apache.commons.validator.ValidatorAction.readJavascriptFile(String): new java.io.InputStreamReader(InputStream) [org.apache.commons.validator.ValidatorAction] At ValidatorAction.java:[line 428] DM_DEFAULT_ENCODING.
+ </action>
<!-- ADD -->
<action type="add" dev="ggregory" due-to="Dependabot, Gary Gregory">
Add github/codeql-action.
diff --git a/src/main/java/org/apache/commons/validator/ValidatorAction.java b/src/main/java/org/apache/commons/validator/ValidatorAction.java
index 45c572d2..e56fdc06 100644
--- a/src/main/java/org/apache/commons/validator/ValidatorAction.java
+++ b/src/main/java/org/apache/commons/validator/ValidatorAction.java
@@ -24,6 +24,7 @@ import java.io.Serializable;
import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
+import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
@@ -425,7 +426,7 @@ public class ValidatorAction implements Serializable {
}
final StringBuilder buffer = new StringBuilder();
// TODO encoding
- try (BufferedReader reader = new BufferedReader(new InputStreamReader(is))) {
+ try (BufferedReader reader = new BufferedReader(new InputStreamReader(is, StandardCharsets.UTF_8))) {
String line = null;
while ((line = reader.readLine()) != null) {
buffer.append(line).append("\n");