You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/18 01:54:11 UTC

[GitHub] [arrow-rs] viirya opened a new pull request, #1585: Read/write nested dictionary under large list in ipc stream reader/writer

viirya opened a new pull request, #1585:
URL: https://github.com/apache/arrow-rs/pull/1585

   # Which issue does this PR close?
   
   <!---
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #1584.
   
   # Rationale for this change
    
    <!---
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!---
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!---
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold merged pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] codecov-commenter commented on pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#issuecomment-1101030099

   # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1585?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1585](https://codecov.io/gh/apache/arrow-rs/pull/1585?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (348b12f) into [master](https://codecov.io/gh/apache/arrow-rs/commit/6bb6ed0a94361319fd393d45ed45f29b4e87685a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6bb6ed0) will **increase** coverage by `0.00%`.
   > The diff coverage is `80.95%`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1585   +/-   ##
   =======================================
     Coverage   82.87%   82.87%           
   =======================================
     Files         193      193           
     Lines       55304    55322   +18     
   =======================================
   + Hits        45832    45850   +18     
     Misses       9472     9472           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1585?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [arrow/src/datatypes/field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1585/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9maWVsZC5ycw==) | `54.92% <0.00%> (+0.29%)` | :arrow_up: |
   | [arrow/src/ipc/writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/1585/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2lwYy93cml0ZXIucnM=) | `81.52% <62.50%> (-0.28%)` | :arrow_down: |
   | [arrow/src/ipc/reader.rs](https://codecov.io/gh/apache/arrow-rs/pull/1585/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2lwYy9yZWFkZXIucnM=) | `88.73% <100.00%> (+0.12%)` | :arrow_up: |
   | [arrow/src/datatypes/datatype.rs](https://codecov.io/gh/apache/arrow-rs/pull/1585/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9kYXRhdHlwZS5ycw==) | `66.40% <0.00%> (-0.40%)` | :arrow_down: |
   | [arrow/src/compute/kernels/substring.rs](https://codecov.io/gh/apache/arrow-rs/pull/1585/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9zdWJzdHJpbmcucnM=) | `98.31% <0.00%> (ø)` | |
   | [arrow/src/compute/kernels/cast.rs](https://codecov.io/gh/apache/arrow-rs/pull/1585/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jYXN0LnJz) | `95.74% <0.00%> (+<0.01%)` | :arrow_up: |
   | [parquet/src/column/writer.rs](https://codecov.io/gh/apache/arrow-rs/pull/1585/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvY29sdW1uL3dyaXRlci5ycw==) | `92.42% <0.00%> (+<0.01%)` | :arrow_up: |
   | [parquet/src/file/properties.rs](https://codecov.io/gh/apache/arrow-rs/pull/1585/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvZmlsZS9wcm9wZXJ0aWVzLnJz) | `95.76% <0.00%> (+0.01%)` | :arrow_up: |
   | [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1585/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (+0.22%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/arrow-rs/pull/1585/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1585?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1585?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6bb6ed0...348b12f](https://codecov.io/gh/apache/arrow-rs/pull/1585?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#discussion_r852767908


##########
arrow/src/datatypes/field.rs:
##########
@@ -131,7 +131,7 @@ impl Field {
             DataType::List(field)
             | DataType::LargeList(field)
             | DataType::FixedSizeList(field, _)
-            | DataType::Map(field, _) => collected_fields.push(field),
+            | DataType::Map(field, _) => collected_fields.extend(field.fields()),

Review Comment:
   Possibly an accidental inclusion from #1583 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#discussion_r852765193


##########
arrow/src/ipc/reader.rs:
##########
@@ -1481,4 +1479,35 @@ mod tests {
         let output_batch = roundtrip_ipc_stream(&input_batch);
         assert_eq!(input_batch, output_batch);
     }
+
+    #[test]
+    fn test_roundtrip_stream_nested_dict_dict_in_list() {

Review Comment:
   ```suggestion
       fn test_roundtrip_stream_dict_of_list_of_dict() {
   ```



##########
arrow/src/datatypes/field.rs:
##########
@@ -131,7 +131,7 @@ impl Field {
             DataType::List(field)
             | DataType::LargeList(field)
             | DataType::FixedSizeList(field, _)
-            | DataType::Map(field, _) => collected_fields.push(field),
+            | DataType::Map(field, _) => collected_fields.extend(field.fields()),

Review Comment:
   What does this change relate to?



##########
arrow/src/ipc/reader.rs:
##########
@@ -1481,4 +1479,35 @@ mod tests {
         let output_batch = roundtrip_ipc_stream(&input_batch);
         assert_eq!(input_batch, output_batch);
     }
+
+    #[test]
+    fn test_roundtrip_stream_nested_dict_dict_in_list() {
+        // list
+        let list_data_type = DataType::List(Box::new(Field::new_dict(
+            "item",
+            DataType::Dictionary(Box::new(DataType::Int8), Box::new(DataType::Utf8)),
+            false,
+            1,
+            false,
+        )));
+        let offsets: &[i32; 4] = &[0, 2, 4, 6];

Review Comment:
   Maybe try a zero-length slice, instead of uniform 2 each time?



##########
arrow/src/ipc/reader.rs:
##########
@@ -1444,29 +1444,27 @@ mod tests {
         assert_eq!(input_batch, output_batch);
     }
 
-    #[test]
-    fn test_roundtrip_stream_nested_dict_dict() {
+    fn test_test_roundtrip_stream_nested_dict_dict_for_list<

Review Comment:
   ```suggestion
       fn test_roundtrip_stream_dict_of_list_of_dict_impl<
   ```
   Maybe?



##########
arrow/src/ipc/reader.rs:
##########
@@ -1444,29 +1444,27 @@ mod tests {
         assert_eq!(input_batch, output_batch);
     }
 
-    #[test]
-    fn test_roundtrip_stream_nested_dict_dict() {
+    fn test_test_roundtrip_stream_nested_dict_dict_for_list<
+        OffsetSize: OffsetSizeTrait,
+        U: ArrowNativeType,
+    >(
+        list_data_type: DataType,
+        offsets: &[U; 4],
+    ) {
         let values = StringArray::from_iter_values(["a", "b", "c"]);
         let keys = Int8Array::from_iter_values([0, 0, 1, 2, 0, 1]);
         let dict_array = DictionaryArray::<Int8Type>::try_new(&keys, &values).unwrap();
         let dict_data = dict_array.data();
 
-        let value_offsets = Buffer::from_slice_ref(&[0, 2, 4, 6]);
+        let value_offsets = Buffer::from_slice_ref(offsets);
 
-        let list_data_type = DataType::List(Box::new(Field::new_dict(
-            "item",
-            DataType::Dictionary(Box::new(DataType::Int8), Box::new(DataType::Utf8)),
-            false,
-            1,
-            false,
-        )));
         let list_data = ArrayData::builder(list_data_type)
             .len(3)
             .add_buffer(value_offsets)
             .add_child_data(dict_data.clone())
             .build()
             .unwrap();
-        let list_array = ListArray::from(list_data);
+        let list_array = GenericListArray::<OffsetSize>::from(list_data);
 
         let dict_dict_array =
             DictionaryArray::<Int8Type>::try_new(&keys, &list_array).unwrap();

Review Comment:
   Could consider using a different keys array for this dictionary for added :hot_pepper: 



##########
arrow/src/ipc/reader.rs:
##########
@@ -1481,4 +1479,35 @@ mod tests {
         let output_batch = roundtrip_ipc_stream(&input_batch);
         assert_eq!(input_batch, output_batch);
     }
+
+    #[test]
+    fn test_roundtrip_stream_nested_dict_dict_in_list() {
+        // list
+        let list_data_type = DataType::List(Box::new(Field::new_dict(
+            "item",
+            DataType::Dictionary(Box::new(DataType::Int8), Box::new(DataType::Utf8)),
+            false,

Review Comment:
   Could also test some nulls, just because they always seem to break things :sweat_smile: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#discussion_r853813924


##########
arrow/src/ipc/reader.rs:
##########
@@ -1444,32 +1444,31 @@ mod tests {
         assert_eq!(input_batch, output_batch);
     }
 
-    #[test]
-    fn test_roundtrip_stream_nested_dict_dict() {
-        let values = StringArray::from_iter_values(["a", "b", "c"]);
-        let keys = Int8Array::from_iter_values([0, 0, 1, 2, 0, 1]);
+    fn test_roundtrip_stream_dict_of_list_of_dict_impl<
+        OffsetSize: OffsetSizeTrait,
+        U: ArrowNativeType,
+    >(
+        list_data_type: DataType,
+        offsets: &[U; 5],
+    ) {
+        let values = StringArray::from(vec![Some("a"), None, Some("c"), None]);

Review Comment:
   Whilst reviewing #1583 I realised this has the same bug, dictionaries store nulls on the keys not the values. This might not be doing something sensible
   
   Edit: nvm this is actually supported for some reason



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] viirya commented on a diff in pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#discussion_r853270208


##########
arrow/src/ipc/reader.rs:
##########
@@ -1444,29 +1444,27 @@ mod tests {
         assert_eq!(input_batch, output_batch);
     }
 
-    #[test]
-    fn test_roundtrip_stream_nested_dict_dict() {
+    fn test_test_roundtrip_stream_nested_dict_dict_for_list<
+        OffsetSize: OffsetSizeTrait,
+        U: ArrowNativeType,
+    >(
+        list_data_type: DataType,
+        offsets: &[U; 4],
+    ) {
         let values = StringArray::from_iter_values(["a", "b", "c"]);
         let keys = Int8Array::from_iter_values([0, 0, 1, 2, 0, 1]);
         let dict_array = DictionaryArray::<Int8Type>::try_new(&keys, &values).unwrap();
         let dict_data = dict_array.data();
 
-        let value_offsets = Buffer::from_slice_ref(&[0, 2, 4, 6]);
+        let value_offsets = Buffer::from_slice_ref(offsets);
 
-        let list_data_type = DataType::List(Box::new(Field::new_dict(
-            "item",
-            DataType::Dictionary(Box::new(DataType::Int8), Box::new(DataType::Utf8)),
-            false,
-            1,
-            false,
-        )));
         let list_data = ArrayData::builder(list_data_type)
             .len(3)
             .add_buffer(value_offsets)
             .add_child_data(dict_data.clone())
             .build()
             .unwrap();
-        let list_array = ListArray::from(list_data);
+        let list_array = GenericListArray::<OffsetSize>::from(list_data);
 
         let dict_dict_array =
             DictionaryArray::<Int8Type>::try_new(&keys, &list_array).unwrap();

Review Comment:
   Okay.



##########
arrow/src/datatypes/field.rs:
##########
@@ -131,7 +131,7 @@ impl Field {
             DataType::List(field)
             | DataType::LargeList(field)
             | DataType::FixedSizeList(field, _)
-            | DataType::Map(field, _) => collected_fields.push(field),
+            | DataType::Map(field, _) => collected_fields.extend(field.fields()),

Review Comment:
   Removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#discussion_r852767908


##########
arrow/src/datatypes/field.rs:
##########
@@ -131,7 +131,7 @@ impl Field {
             DataType::List(field)
             | DataType::LargeList(field)
             | DataType::FixedSizeList(field, _)
-            | DataType::Map(field, _) => collected_fields.push(field),
+            | DataType::Map(field, _) => collected_fields.extend(field.fields()),

Review Comment:
   Possibly an accidental inclusion from #1584 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] viirya commented on a diff in pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#discussion_r853270020


##########
arrow/src/ipc/reader.rs:
##########
@@ -1481,4 +1479,35 @@ mod tests {
         let output_batch = roundtrip_ipc_stream(&input_batch);
         assert_eq!(input_batch, output_batch);
     }
+
+    #[test]
+    fn test_roundtrip_stream_nested_dict_dict_in_list() {
+        // list
+        let list_data_type = DataType::List(Box::new(Field::new_dict(
+            "item",
+            DataType::Dictionary(Box::new(DataType::Int8), Box::new(DataType::Utf8)),
+            false,
+            1,
+            false,
+        )));
+        let offsets: &[i32; 4] = &[0, 2, 4, 6];

Review Comment:
   Yea, added a zero-length one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] viirya commented on a diff in pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#discussion_r853269559


##########
arrow/src/ipc/reader.rs:
##########
@@ -1481,4 +1479,35 @@ mod tests {
         let output_batch = roundtrip_ipc_stream(&input_batch);
         assert_eq!(input_batch, output_batch);
     }
+
+    #[test]
+    fn test_roundtrip_stream_nested_dict_dict_in_list() {
+        // list
+        let list_data_type = DataType::List(Box::new(Field::new_dict(
+            "item",
+            DataType::Dictionary(Box::new(DataType::Int8), Box::new(DataType::Utf8)),
+            false,

Review Comment:
   Good point. Added a few nulls.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] viirya commented on pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#issuecomment-1102854342

   Thanks @tustvold.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1585: Read/write nested dictionary under large list in ipc stream reader/writer

Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #1585:
URL: https://github.com/apache/arrow-rs/pull/1585#discussion_r853813924


##########
arrow/src/ipc/reader.rs:
##########
@@ -1444,32 +1444,31 @@ mod tests {
         assert_eq!(input_batch, output_batch);
     }
 
-    #[test]
-    fn test_roundtrip_stream_nested_dict_dict() {
-        let values = StringArray::from_iter_values(["a", "b", "c"]);
-        let keys = Int8Array::from_iter_values([0, 0, 1, 2, 0, 1]);
+    fn test_roundtrip_stream_dict_of_list_of_dict_impl<
+        OffsetSize: OffsetSizeTrait,
+        U: ArrowNativeType,
+    >(
+        list_data_type: DataType,
+        offsets: &[U; 5],
+    ) {
+        let values = StringArray::from(vec![Some("a"), None, Some("c"), None]);

Review Comment:
   Whilst reviewing #1583 I realised this has the same bug, dictionaries store nulls on the keys not the values. This might not be doing something sensible



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org