You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by dkuppitz <gi...@git.apache.org> on 2018/10/04 14:41:42 UTC

[GitHub] tinkerpop pull request #950: TINKERPOP-2058 Contains predicates should rely ...

GitHub user dkuppitz opened a pull request:

    https://github.com/apache/tinkerpop/pull/950

    TINKERPOP-2058 Contains predicates should rely on Compare predicates

    https://issues.apache.org/jira/browse/TINKERPOP-2058
    
    If the object to be filtered is a number, `Contains` predicates will now scan the provided collection, comparing each element using `Compare.eq`. For non-numeric values `Contains.within` will still use `collection.contains()` in order to make use of search-optimized data types (e.g. `Set`).
    
    This is a breaking change as the test suite previously ensured that number types had an effect on `Contains` predicates. This, however, was inconsistent with `Compare` predicates which ignore the number type.
    
    `docker/build.sh -t -i -n` passed.
    
    VOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-2058

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/950.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #950
    
----
commit ec0d8805fe18e6d1985af5544106f78169f3f5b4
Author: Daniel Kuppitz <da...@...>
Date:   2018-10-04T14:15:09Z

    TINKERPOP-2058 Use `Compare.eq` in `Contains.within` to ensure equal filter behaviors.
    
    If the object to be filtered is a number, `Contains` predicates will now scan the provided collection, comparing
    each element using `Compare.eq`. For non-numeric values `Contains.within` will still use `collection.contains()`
    in order to make use of search-optimized data types (e.g. `Set`).

----


---

[GitHub] tinkerpop issue #950: TINKERPOP-2058 Contains predicates should rely on Comp...

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/950
  
    VOTE +1


---

[GitHub] tinkerpop issue #950: TINKERPOP-2058 Contains predicates should rely on Comp...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/950
  
    Reminder: Merge #949 first, then rebase this PRs branch and fix `PTest` (include differing number tests for `Contains` predicates).
    
    https://github.com/apache/tinkerpop/pull/949/files#diff-dc8c8777ab12a44729fc5f2c9c255c66R115


---