[GitHub] rafaelweingartner opened a new pull request #2496: [CLOUDSTACK-10332] Users are not able to change/edit the protocol of an ACL rule

[GitBox <gi...@apache.org>]

rafaelweingartner opened a new pull request #2496: [CLOUDSTACK-10332] Users are not able to change/edit the protocol of an ACL rule 
URL: https://github.com/apache/cloudstack/pull/2496
 
 
   ## Description
   <!--- Describe your changes in detail -->
   Users should be able to edit an ACL rule completely. Therefore, they must be able to change the protocol type and others configs of an ACL rules.
   
   In addition, it is not just the protocol that users are not able to change. For instance, after defining ports, or reason/description for the rule, users are not able to set those values back to null. The same happens for ICMP code and type.
   
   We will introduce a new parameter called "partialUpdate", which will have its default value as true to maintain backward compatibility. When this parameter is set to false, we will consider only the parameters sent, and not the parameters we already have in the database to change and validate the ACL rule data. This allows us to update parameters already set back to null, and to completely change an ACL rule.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   https://issues.apache.org/jira/browse/CLOUDSTACK-10332
   
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   * Create an ACL for ICMP
   * Click on edit and change the protocol to TCP
   * An error will happen when saving the rule.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   Compile, and deployed ACS with the proposed changes and verified them manually. Moreover, I have unit tests covering this issue, which are able to catch the problem.
   
   <!-- Include details of your testing environment, and the tests you ran to -->
   used Unit testing and a test ACS environment running with XenServer 6.5, and NFS server as primary and secondary storage.
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   - [x] I have added tests to cover my changes.
   - [x] All new and existing tests passed.
   
   <!-- The following will kick a packaging job, remove if as applicable -->
   @blueorangutan package

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services