[GitHub] [skywalking-query-protocol] wu-sheng commented on a diff in pull request #80: Add process count query

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #80:
URL: https://github.com/apache/skywalking-query-protocol/pull/80#discussion_r847915189


##########
metadata-v2.graphqls:
##########
@@ -140,6 +140,9 @@ extend type Query {
     listProcesses(serviceId: ID, instanceId: ID): [Process!]!
     # Find process according to given ID. Return null if not existing.
     getProcess(processId: ID!): Process
+    # Get process count by serviceId, labels and duration
+    # The labels means that the process must contains all of labels which queried
+    getProcessCount(serviceId: ID!, labels: [String!]!, duration: Duration!): Long!

Review Comment:
   ```suggestion
       # Get the number of matched processes through serviceId, labels, and duration
       # Labels: the matched process should contain all labels
       #
       # The return is not a precise number, the process has its lifecycle, as it reboots and shutdowns with time.
       # The return number just gives an abstract of the scale of profiling that would be applied.
       estimateProfilingScale(serviceId: ID!, labels: [String!]!, duration: Duration!): Long!
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org