You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by Zhangshunyu <gi...@git.apache.org> on 2016/10/10 03:39:38 UTC
[GitHub] incubator-carbondata pull request #224: Add scan_blocklet_num for query stat...
GitHub user Zhangshunyu opened a pull request:
https://github.com/apache/incubator-carbondata/pull/224
Add scan_blocklet_num for query statistics
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zhangshunyu/incubator-carbondata querystat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #224
----
commit 06d15f22b66cc7413af3ddd575faa64b4ccbb52e
Author: Zhangshunyu <zh...@huawei.com>
Date: 2016-10-10T03:33:05Z
Add scan_blocklet_num for query statistics
commit 933d9356a42ba8ef7d40b8ea9429dd3d3d3d7de9
Author: Zhangshunyu <zh...@huawei.com>
Date: 2016-10-10T03:37:43Z
Style
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #224: [CARBONDATA-239]Add scan_blocklet_nu...
Posted by sujith71955 <gi...@git.apache.org>.
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/224#discussion_r82983904
--- Diff: core/src/main/java/org/apache/carbondata/scan/scanner/impl/FilterScanner.java ---
@@ -78,10 +80,11 @@ public FilterScanner(BlockExecutionInfo blockExecutionInfo) {
* @throws QueryExecutionException
* @throws FilterUnsupportedException
*/
- @Override public AbstractScannedResult scanBlocklet(BlocksChunkHolder blocksChunkHolder)
+ @Override public AbstractScannedResult scanBlocklet(BlocksChunkHolder blocksChunkHolder,
+ QueryStatisticsModel queryStatisticsModel)
throws QueryExecutionException {
try {
- fillScannedResult(blocksChunkHolder);
+ fillScannedResult(blocksChunkHolder, queryStatisticsModel);
--- End diff --
Pass the model in constructor so that no need to change in all API
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #224: [CARBONDATA-239]Add scan_blocklet_nu...
Posted by Zhangshunyu <gi...@git.apache.org>.
Github user Zhangshunyu commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/224#discussion_r82958230
--- Diff: core/src/main/java/org/apache/carbondata/scan/processor/AbstractDataBlockIterator.java ---
@@ -127,11 +133,15 @@ protected boolean updateScanner() {
}
}
- private AbstractScannedResult getNextScannedResult() throws QueryExecutionException {
+ private AbstractScannedResult getNextScannedResult(QueryStatisticsRecorder recorder,
--- End diff --
@sujith71955 OK, i will use a statistics model, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #224: [CARBONDATA-239]Add scan_blocklet_nu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #224: [CARBONDATA-239]Add scan_blocklet_nu...
Posted by sujith71955 <gi...@git.apache.org>.
Github user sujith71955 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/224#discussion_r82729006
--- Diff: core/src/main/java/org/apache/carbondata/scan/processor/AbstractDataBlockIterator.java ---
@@ -127,11 +133,15 @@ protected boolean updateScanner() {
}
}
- private AbstractScannedResult getNextScannedResult() throws QueryExecutionException {
+ private AbstractScannedResult getNextScannedResult(QueryStatisticsRecorder recorder,
--- End diff --
Why we need to change this getNextScannedResult() method parameters. if required please pass a statistics model, this will make sure that our method parameters wont grow
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---