You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@parquet.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2019/05/01 22:42:00 UTC

[jira] [Resolved] (PARQUET-1413) [C++] Remove virtual calls from parquet::Comparator hot paths on writing file

     [ https://issues.apache.org/jira/browse/PARQUET-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wes McKinney resolved PARQUET-1413.
-----------------------------------
    Resolution: Duplicate

Duplicate of PARQUET-1523

> [C++] Remove virtual calls from parquet::Comparator hot paths on writing file
> -----------------------------------------------------------------------------
>
>                 Key: PARQUET-1413
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1413
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Assignee: Wes McKinney
>            Priority: Major
>             Fix For: cpp-1.6.0
>
>
> Having virtual calls on the innermost loop of writing to a file would be best avoided. While we need to provide for users to write custom comparators (I think?), an implementation of a single-value comparison should be inlined into an array-oriented update step so that the per-element looping does not contain a virtual call



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)