You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "nvazquez (via GitHub)" <gi...@apache.org> on 2025/09/03 15:18:43 UTC
[PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]
nvazquez opened a new pull request, #11569:
URL: https://github.com/apache/cloudstack/pull/11569
### Description
This PR fixes OS the machine type on newer QEMU versions (observed on Ubuntu 24, please check the test matrix on: https://github.com/apache/cloudstack/issues/11512#issuecomment-3242172694)
<img width="1027" height="219" alt="Screenshot 2025-09-03 at 11 58 40 AM" src="https://github.com/user-attachments/assets/3e57a186-7218-40d3-88c5-324e15d0b7fd" />
Fixes: #11512
<!--- ******************************************************************************* -->
<!--- NOTE: AUTOMATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ******************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested on Ubuntu 24 KVM host - deploying Windows VM and retrieving the UUID through the wmic command
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#discussion_r2322105149
##########
api/src/main/java/com/cloud/vm/VmDetailConstants.java:
##########
@@ -41,6 +41,7 @@ public interface VmDetailConstants {
String KVM_VNC_PORT = "kvm.vnc.port";
String KVM_VNC_ADDRESS = "kvm.vnc.address";
String KVM_VNC_PASSWORD = "kvm.vnc.password";
+ String KVM_GUEST_OS_TYPE_MACHINE = "kvm.guest.os.type.machine";
Review Comment:
```suggestion
String KVM_GUEST_OS_MACHINE_TYPE = "kvm.guest.os.machine.type";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "jmgsky (via GitHub)" <gi...@apache.org>.
jmgsky commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253532555
This looks like it will fix my issue with booting a Juniper VSRX on cloudstack, but I think an option to set other parameters on the underlying qemu virtual machine would be more sustainable.
Specifically, you can set `smbios-entry-point-type` on the machine (even newer i440fx-8.2 and beyond) and have it still use the older 32-bit smbios 2.x interface. [Here](https://github.com/qemu/qemu/blob/baa79455fa92984ff0f4b9ae94bed66823177a27/tests/functional/x86_64/test_acpi_bits.py#L321C1-L326C1) is the best example I can find of it's usage with qemu.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249854922
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250485684
@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#discussion_r2351929873
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -3292,6 +3292,9 @@ protected GuestDef createGuestFromSpec(VirtualMachineTO vmTO, LibvirtVMDef vm, S
}
}
guest.setIothreads(customParams.containsKey(VmDetailConstants.IOTHREADS));
+ if (customParams.containsKey(VmDetailConstants.KVM_GUEST_OS_MACHINE_TYPE)) {
Review Comment:
can this be set by every user ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250141871
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 14836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on code in PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#discussion_r2319353711
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2903,6 +2904,31 @@ private boolean isGuestAarch64() {
return AARCH64.equals(guestCpuArch);
}
+ private boolean isQemuVersionConflictingSMBiosForWindowsGuestVMs() {
+ if (!isUbuntuOrDebianHost()) {
Review Comment:
we don't know if this issue is restricted to only ubuntu/debian - el10 "may" also face this issue..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253077166
Thanks @Pearl1594 I'll create a doc PR for that.
@weizhouapache as discussed offline let's keep it targeted to main branch to avoid feature loss on upgrade to 4.21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253164601
@nvazquez is this worth raising the PR for 4.20 branch, could you check & change the base branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3254544676
@jmgsky thanks, the extraconfig will attempt to append the snippet as well on the XML domain, should have similar results than editing the XML directly. I couldn't find it mentioned on: https://libvirt.org/formatdomain.html, however checking the example you mentioned can you try the following?
````
<type arch='x86_64' machine='pc-i440fx-8.0' sm-bios-entry-point-type='32'>hvm</type>
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249927196
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253259562
<b>[SF] Trillian test result (tid-14206)</b>
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 55385 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11569-t14206-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249919810
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250622357
Would it make sense to have a documentation PR - adding a note on the limitation with retrieving UUID on a Windows VM, and how it can be achieved using this @nvazquez.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249852930
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253681646
> @nvazquez is this worth raising the PR for 4.20 branch, could you check & change the base branch?
@rohityadavcloud
I have discussed with @nvazquez , our concern is, when users upgrade from 4.20.2 (assume this PR is included) to 4.21.0 (released already), the setting will be gone.
my opinion is, unless very necessary, let's not introduce new api params, api responses, settings or db changes in minor versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3273257782
> Would it make sense to have a documentation PR - adding a note on the limitation with retrieving UUID on a Windows VM, and how it can be mitigated using this @nvazquez.
@nvazquez can you please raise the doc PR as suggested here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on code in PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#discussion_r2319356718
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -2903,6 +2904,31 @@ private boolean isGuestAarch64() {
return AARCH64.equals(guestCpuArch);
}
+ private boolean isQemuVersionConflictingSMBiosForWindowsGuestVMs() {
+ if (!isUbuntuOrDebianHost()) {
+ return false;
+ }
+ return getHypervisorQemuVersion() > HYPERVISOR_QEMU_VERSION_PC_MACHINE_TYPE_FIX;
+ }
+
+ /**
+ * Observed the QEMU version included on Ubuntu 24 conflicts retrieval of UUID for Windows VMs
+ * References:
+ * - <a href="https://gitlab.com/libvirt/libvirt/-/issues/807">Reported issue with CloudStack created Windows VMs on Ubuntu 24</a>
+ * - <a href="https://gitlab.com/qemu-project/qemu/-/issues/2008">Reported Issue on QEMU</a>
+ * Workaround: Set an older OS type machine on the XML domain: 'pc-i440fx-8.0'
+ */
+ private void setGuestMachineType(GuestDef guest) {
+ if (isGuestAarch64()) {
+ guest.setMachineType(VIRT);
+ } else if (isQemuVersionConflictingSMBiosForWindowsGuestVMs()) {
+ // Please check the method javadoc
+ guest.setMachineType("pc-i440fx-8.0");
Review Comment:
I wonder if getting this as vm detail would be better? as opposed to hard-coding this to a specific machine type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250656718
@nvazquez
should the target branch be 4.20 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "jmgsky (via GitHub)" <gi...@apache.org>.
jmgsky commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3254483058
@nvazquez - I'm actually not sure if that's right or not. I was trying to do it with `extraconfig` and qemu:args, but my VM wouldn't even start at that point. I switched to testing using `virsh edit` manually, and it doesn't like that xml snippet or `qemu:args`, so I'm honestly not even sure if there's a way to achieve that with libvirt.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala merged PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250490942
@nvazquez
maybe machine.type, not type.machine
Can it be set by regular user ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250481430
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3253929401
Hi @jmgsky thanks for your input. I think that can be addressed on a separate PR.
I couldn't find references for this attribute on the libvirt documentation, but seems it should be wrapped as a feature on the XML domain. Can you please confirm if this snippet looks correct for a running domain?
````
<type arch='x86_64' machine='pc-i440fx-8.2=0'>hvm</type>
<features>
<sm-bios-entry-point-type value='32'/>
</features>
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249925436
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3250176955
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Allow passing the OS type machine for KVM XML domains through VM setting [cloudstack]
Posted by "nvazquez (via GitHub)" <gi...@apache.org>.
nvazquez commented on code in PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#discussion_r2322709861
##########
api/src/main/java/com/cloud/vm/VmDetailConstants.java:
##########
@@ -41,6 +41,7 @@ public interface VmDetailConstants {
String KVM_VNC_PORT = "kvm.vnc.port";
String KVM_VNC_ADDRESS = "kvm.vnc.address";
String KVM_VNC_PASSWORD = "kvm.vnc.password";
+ String KVM_GUEST_OS_TYPE_MACHINE = "kvm.guest.os.type.machine";
Review Comment:
Thanks @weizhouapache, addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [KVM] Fix for UUID retrieval of Windows VMs on Ubuntu 24 [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #11569:
URL: https://github.com/apache/cloudstack/pull/11569#issuecomment-3249735562
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/11569?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 4.00%. Comparing base ([`db5b6a5`](https://app.codecov.io/gh/apache/cloudstack/commit/db5b6a54a1e52ac1716e87c9f0fa0ae46310ba3e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`cd9929f`](https://app.codecov.io/gh/apache/cloudstack/commit/cd9929f7c5a7ae058f22ed61df39b5430fe6844f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (db5b6a5) and HEAD (cd9929f). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (db5b6a5) | HEAD (cd9929f) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.20 #11569 +/- ##
=============================================
- Coverage 16.17% 4.00% -12.17%
=============================================
Files 5656 402 -5254
Lines 498015 32635 -465380
Branches 60406 5798 -54608
=============================================
- Hits 80538 1308 -79230
+ Misses 408515 31177 -377338
+ Partials 8962 150 -8812
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/11569/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/11569/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.00% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/11569/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/11569?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org