You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Roger Whitcomb (JIRA)" <ji...@apache.org> on 2012/07/26 21:24:33 UTC

[jira] [Comment Edited] (PIVOT-865) Crash in Save, As dialog when path + filename entered in text field

    [ https://issues.apache.org/jira/browse/PIVOT-865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423349#comment-13423349 ] 

Roger Whitcomb edited comment on PIVOT-865 at 7/26/12 7:22 PM:
---------------------------------------------------------------

Simple fix for this problem:  getName() -> getPath().  BUT, there are further problems:
* What if the input text contains an invalid directory name?  Still have an IllegalArgumentException in this case.  Should there be an error message in this case?
* What if the input text contains ONLY a directory name?  We should set the root directory and clear the selected files list and not close the sheet.

Will try to resolve these issues as well.
                
      was (Author: rwhitcomb):
    Simple fix for this problem:  getName() -> getPath().  BUT, there are further problems:
* What if the input text contains an invalid directory name?  Still have an IllegalArgumentException in this case.  Should there be an error message in this case?
* What if the input text contains ONLY a directory name?  We should set the root directory and clear the selected files list.

Will try to resolve these issues as well.
                  
> Crash in Save, As dialog when path + filename entered in text field
> -------------------------------------------------------------------
>
>                 Key: PIVOT-865
>                 URL: https://issues.apache.org/jira/browse/PIVOT-865
>             Project: Pivot
>          Issue Type: Bug
>          Components: wtk, wtk-terra
>    Affects Versions: 2.0.2
>         Environment: Windows XP, Windows 7, JRE 1.6 or 1.7
>            Reporter: Roger Whitcomb
>            Assignee: Roger Whitcomb
>              Labels: filebrowser
>             Fix For: 2.0.3
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> In a File Browser sheet in SAVE_AS mode, enter a path and file name (something like [in Windows] "test\script\test.txt") in the text field and it will throw this exception:
> java.lang.IllegalArgumentException
>         at org.apache.pivot.wtk.FileBrowserSheet.setRootDirectory(FileBrowserSheet.java:139)
>         at org.apache.pivot.wtk.skin.terra.TerraFileBrowserSheetSkin.previewSheetClose(TerraFileBrowserSheetSkin.java:296)
>         at org.apache.pivot.wtk.Sheet$SheetStateListenerList.previewSheetClose(Sheet.java:34)
>         at org.apache.pivot.wtk.Sheet.close(Sheet.java:118)
>         at org.apache.pivot.wtk.skin.terra.TerraSheetSkin.keyPressed(TerraSheetSkin.java:502)
>         at org.apache.pivot.wtk.Component$ComponentKeyListenerList.keyPressed(Component.java:544)
>         at org.apache.pivot.wtk.Component.keyPressed(Component.java:2853)
>         at org.apache.pivot.wtk.Window.keyPressed(Window.java:1179)
>         at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856)
>         at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856)
>         at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856)
>         at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856)
>         at org.apache.pivot.wtk.Component.keyPressed(Component.java:2856)
>         at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processKeyEvent(ApplicationContext.java:1339)
>         at java.awt.Component.processEvent(Unknown Source)
>         at org.apache.pivot.wtk.ApplicationContext$DisplayHost.processEvent(ApplicationContext.java:792)
>         at java.awt.Component.dispatchEventImpl(Unknown Source)
>         at java.awt.Component.dispatchEvent(Unknown Source)
>         at java.awt.KeyboardFocusManager.redispatchEvent(Unknown Source)
>         at java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(Unknown Source)
>         at java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(Unknown Source)
>         at java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(Unknown Source)
>         at java.awt.DefaultKeyboardFocusManager.dispatchEvent(Unknown Source)
>         at java.awt.Component.dispatchEventImpl(Unknown Source)
>         at java.awt.Container.dispatchEventImpl(Unknown Source)
>         at java.awt.Window.dispatchEventImpl(Unknown Source)
>         at java.awt.Component.dispatchEvent(Unknown Source)
>         at java.awt.EventQueue.dispatchEventImpl(Unknown Source)
>         at java.awt.EventQueue.access$000(Unknown Source)
>         at java.awt.EventQueue$3.run(Unknown Source)
>         at java.awt.EventQueue$3.run(Unknown Source)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
>         at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
>         at java.awt.EventQueue$4.run(Unknown Source)
>         at java.awt.EventQueue$4.run(Unknown Source)
>         at java.security.AccessController.doPrivileged(Native Method)
>         at java.security.ProtectionDomain$1.doIntersectionPrivilege(Unknown Source)
>         at java.awt.EventQueue.dispatchEvent(Unknown Source)
>         at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)
>         at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)
>         at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)
>         at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
>         at java.awt.EventDispatchThread.pumpEvents(Unknown Source)
>         at java.awt.EventDispatchThread.run(Unknown Source)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira