[GitHub] [skywalking-nodejs] tom-pytel opened a new pull request #5: [Enhancement] tweaks for better error handling

[GitBox <gi...@apache.org>]

tom-pytel opened a new pull request #5:
URL: https://github.com/apache/skywalking-nodejs/pull/5


   * Removed ContextManager.withSpanNoStop() to clean up interface since this was only meant to be used in plugins and so the plugins themselves should do this.
   * Changed ContextManager.withSpan() and .withSpanAsync() to not insert span as first argument but rather just pass the args through to allow more generalized use, for example `ContextManager.withSpanAsync(user_defined_span, unsupported_async_URL_requester, requester_arg1, ...)`.
   * Reworked HttpPlugin:http.request() to better cover and handle error conditions, should be 100% covered now (before there was a range between `span.async()` and the callback where an unexpected error could cause the span to not be stopped).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-nodejs] kezhenxu94 merged pull request #5: [Enhancement] tweaks for better error handling

[GitBox <gi...@apache.org>]

kezhenxu94 merged pull request #5:
URL: https://github.com/apache/skywalking-nodejs/pull/5


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org