[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #9650: feat: add a single endpoint that visualizes a new table. Enables external superset integration.

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #9650:
URL: https://github.com/apache/incubator-superset/pull/9650#discussion_r442489954



##########
File path: superset/security/manager.py
##########
@@ -273,15 +273,15 @@ def can_access_datasource(self, datasource: "BaseDatasource") -> bool:
             "datasource_access", datasource.perm or ""
         )
 
-    def get_datasource_access_error_msg(self, datasource: "BaseDatasource") -> str:
+    def get_datasource_access_error_msg(self, datasource_name: Optional[str]) -> str:

Review comment:
       That's a grey area in superset, e.g. we have database and schema level permissions that are leveraged in both explore view and sqllab. For consistency it feels to me that we should treat them the same e.g. having access to the table in sqllab and having access to the datasources that represents the same table.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org