You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/03 20:31:00 UTC
[GitHub] [airflow] jhtimmins opened a new pull request #12794: Convert state values to list.
jhtimmins opened a new pull request #12794:
URL: https://github.com/apache/airflow/pull/12794
The ExternalTaskSensor expects to receive `allowed_states ` and `failed_states` arguments as list values. The `state.py` file defines states as tuples, which cause `ExternalTaskSensor` to fail when passed in as arguments.
This change allows any iterable to be used for `allowed_states` and `failed_states`, and then converts the input arguments into lists.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12794: Convert state values in ExternalTaskSensor to list
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12794:
URL: https://github.com/apache/airflow/pull/12794#issuecomment-738316226
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #12794: Convert state values in ExternalTaskSensor to list
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #12794:
URL: https://github.com/apache/airflow/pull/12794
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org