[GitHub] [arrow] rishabh-rana commented on a diff in pull request #13279: ARROW-16660: [C#] Add support for Time32Array and Time64Array

[GitBox <gi...@apache.org>]

rishabh-rana commented on code in PR #13279:
URL: https://github.com/apache/arrow/pull/13279#discussion_r888677735


##########
csharp/test/Apache.Arrow.Tests/TestData.cs:
##########
@@ -47,6 +47,8 @@ public static RecordBatch CreateSampleRecordBatch(int length, int columnSetCount
                 builder.Field(CreateField(DoubleType.Default, i));
                 builder.Field(CreateField(Date32Type.Default, i));
                 builder.Field(CreateField(Date64Type.Default, i));
+                builder.Field(CreateField(Time32Type.Default, i));
+                builder.Field(CreateField(Time64Type.Default, i));

Review Comment:
   removed these



##########
csharp/src/Apache.Arrow/Arrays/Time32Array.cs:
##########
@@ -0,0 +1,138 @@
+// Licensed to the Apache Software Foundation (ASF) under one or moreDate32Array
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+using Apache.Arrow.Types;
+using System;
+using System.IO;
+
+namespace Apache.Arrow
+{
+    /// <summary>
+    /// The <see cref="Time32Array"/> class holds an array of ints, where each value is
+    /// stored as the number of seconds/ milliseconds (depending on the Time32Type) since midnight.
+    /// </summary>
+    public class Time32Array : PrimitiveArray<int>
+    {
+        private static readonly int seconds_in_millisecond = 1_000;

Review Comment:
   made this change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org