You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/03/07 20:23:23 UTC

[GitHub] [fineract-cn-mobile] varsvat opened a new pull request #118: Fix: Nav bar overflow issue solved for new mobile screen sizes

varsvat opened a new pull request #118:
URL: https://github.com/apache/fineract-cn-mobile/pull/118


   #Fixes #Issue_number
   
   The profile avatar icon is cut because of overflow of nav drawer in new mobile models as shown below:
   
   ![profileIconCut](https://user-images.githubusercontent.com/53621853/110253460-6fb47080-7fb0-11eb-8c18-82b71dc85ce7.png)
   
   I have solved this issue and now it works fine as shown below: 
   
   ![profileIconCutIssue_solved](https://user-images.githubusercontent.com/53621853/110253549-f6694d80-7fb0-11eb-929f-cd398ea642ac.png)
   
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Apply the `AndroidStyle.xml` style template to your code in Android Studio.
   
   - [ ] Run the unit tests with `./gradlew check` to make sure you didn't break anything.
   
   - [ ] If you have multiple commits please combine them into one commit by squashing them.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] varsvat commented on pull request #118: Bug: Nav bar overflow issue solved for new mobile screen sizes

Posted by GitBox <gi...@apache.org>.

varsvat commented on pull request #118:
URL: https://github.com/apache/fineract-cn-mobile/pull/118#issuecomment-792918666


   @therajanmaurya @edcable @jawidMuhammadi Please review this when you have time.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] varsvat commented on pull request #118: Bug: Nav bar overflow issue solved for new mobile screen sizes

Posted by GitBox <gi...@apache.org>.

varsvat commented on pull request #118:
URL: https://github.com/apache/fineract-cn-mobile/pull/118#issuecomment-792719853


   I actually did not purposely did this, I just formatted the code which repositioned the lines :sweat_smile: . Thank you @EGOR-IND for letting me know this .... makes sense . I'll keep this in mind now onwards .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract-cn-mobile] varsvat closed pull request #118: Bug: Nav bar overflow issue solved for new mobile screen sizes

Posted by GitBox <gi...@apache.org>.

varsvat closed pull request #118:
URL: https://github.com/apache/fineract-cn-mobile/pull/118


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org