Re: [PR] [CXF-9162]avoid reusing HttpClientHTTPConduit if the underlying HttpC… [cxf]

["eric6iese (via GitHub)" <gi...@apache.org>]

eric6iese commented on code in PR #2571:
URL: https://github.com/apache/cxf/pull/2571#discussion_r2315329644


##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -195,23 +207,29 @@ RefCount<HttpClient> computeIfAbsent(final boolean shareHttpClient, final HTTPCl
 
             // Do not share if it is not allowed for the conduit or cache capacity is exceeded
             if (!shareHttpClient || clients.size() >= MAX_SIZE) {

Review Comment:
   That's correct, if the result does not need to be exact, than this change is not necessary. 
   
   Still would not write it that way, but there is no need to change it eiter. I am a bit pedantic and cautious in this regard since I've been massively burned by multi threading in my youth. ;-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org