You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Nathan Mittler (JIRA)" <ji...@apache.org> on 2006/11/26 14:14:03 UTC
[jira] Created: (AMQCPP-14) CMSExpiration not handled properly in
ActiveMQProducer
CMSExpiration not handled properly in ActiveMQProducer
------------------------------------------------------
Key: AMQCPP-14
URL: https://issues.apache.org/activemq/browse/AMQCPP-14
Project: ActiveMQ C++ Client
Issue Type: Bug
Components: CMS Impl
Affects Versions: 1.0
Environment: All
Reporter: Nathan Mittler
Assigned To: Nathan Mittler
Priority: Minor
Fix For: 1.1
ActiveMQProducer.send method is overwriting the CMSExpiration in the message with its default timeToLive value. This is incorrect - it should set the expiry to (expiry + timeToLive). An example of this is in ActiveMQ's ActiveMQSession:
https://svn.apache.org/repos/asf/incubator/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQSession.java
A work-around is to specify the timeToLive value in the producer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (AMQCPP-14) CMSExpiration not handled properly in
ActiveMQProducer
Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-14?page=comments#action_37560 ]
Nathan Mittler commented on AMQCPP-14:
--------------------------------------
I have committed changes to trunk. I'd like to create a new integration test to prove that the expiration works properly before I mark this issue as resolved.
> CMSExpiration not handled properly in ActiveMQProducer
> ------------------------------------------------------
>
> Key: AMQCPP-14
> URL: https://issues.apache.org/activemq/browse/AMQCPP-14
> Project: ActiveMQ C++ Client
> Issue Type: Bug
> Components: CMS Impl
> Affects Versions: 1.0
> Environment: All
> Reporter: Nathan Mittler
> Assigned To: Nathan Mittler
> Priority: Minor
> Fix For: 1.1
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> ActiveMQProducer.send method is overwriting the CMSExpiration in the message with its default timeToLive value. This is incorrect - it should set the expiry to (expiry + timeToLive). An example of this is in ActiveMQ's ActiveMQSession:
> https://svn.apache.org/repos/asf/incubator/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQSession.java
> A work-around is to specify the timeToLive value in the producer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (AMQCPP-14) CMSExpiration not handled properly in
ActiveMQProducer
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-14?page=all ]
Timothy Bish resolved AMQCPP-14.
--------------------------------
Resolution: Fixed
Changes are applied in trunk to address this issue
The producer now correctly sets the timestamp and expiration value when the timeToLive value is specified.
The consumer now throws away expired messages when they arrive.
Unit tests and Integration tests are now in that tests this functionality.
> CMSExpiration not handled properly in ActiveMQProducer
> ------------------------------------------------------
>
> Key: AMQCPP-14
> URL: https://issues.apache.org/activemq/browse/AMQCPP-14
> Project: ActiveMQ C++ Client
> Issue Type: Bug
> Components: CMS Impl
> Affects Versions: 1.0
> Environment: All
> Reporter: Nathan Mittler
> Assigned To: Timothy Bish
> Priority: Minor
> Fix For: 1.1
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> ActiveMQProducer.send method is overwriting the CMSExpiration in the message with its default timeToLive value. This is incorrect - it should set the expiry to (expiry + timeToLive). An example of this is in ActiveMQ's ActiveMQSession:
> https://svn.apache.org/repos/asf/incubator/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQSession.java
> A work-around is to specify the timeToLive value in the producer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (AMQCPP-14) CMSExpiration not handled properly in
ActiveMQProducer
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-14?page=all ]
Timothy Bish reassigned AMQCPP-14:
----------------------------------
Assignee: Timothy Bish (was: Nathan Mittler)
> CMSExpiration not handled properly in ActiveMQProducer
> ------------------------------------------------------
>
> Key: AMQCPP-14
> URL: https://issues.apache.org/activemq/browse/AMQCPP-14
> Project: ActiveMQ C++ Client
> Issue Type: Bug
> Components: CMS Impl
> Affects Versions: 1.0
> Environment: All
> Reporter: Nathan Mittler
> Assigned To: Timothy Bish
> Priority: Minor
> Fix For: 1.1
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> ActiveMQProducer.send method is overwriting the CMSExpiration in the message with its default timeToLive value. This is incorrect - it should set the expiry to (expiry + timeToLive). An example of this is in ActiveMQ's ActiveMQSession:
> https://svn.apache.org/repos/asf/incubator/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQSession.java
> A work-around is to specify the timeToLive value in the producer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (AMQCPP-14) CMSExpiration not handled properly in
ActiveMQProducer
Posted by "Nathan Mittler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQCPP-14?page=comments#action_37573 ]
Nathan Mittler commented on AMQCPP-14:
--------------------------------------
Another issue was found in that the MessageConsumer's receive() method does not seem to take message expiration into account before returning it. After a quick inspection, it appears the .NET client may have the same issue.
An example of what should be done is shown in ActiveMQMessageConsumer's dequeue method:
https://svn.apache.org/repos/asf/incubator/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQMessageConsumer.java
> CMSExpiration not handled properly in ActiveMQProducer
> ------------------------------------------------------
>
> Key: AMQCPP-14
> URL: https://issues.apache.org/activemq/browse/AMQCPP-14
> Project: ActiveMQ C++ Client
> Issue Type: Bug
> Components: CMS Impl
> Affects Versions: 1.0
> Environment: All
> Reporter: Nathan Mittler
> Assigned To: Nathan Mittler
> Priority: Minor
> Fix For: 1.1
>
> Original Estimate: 1 day
> Remaining Estimate: 1 day
>
> ActiveMQProducer.send method is overwriting the CMSExpiration in the message with its default timeToLive value. This is incorrect - it should set the expiry to (expiry + timeToLive). An example of this is in ActiveMQ's ActiveMQSession:
> https://svn.apache.org/repos/asf/incubator/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/ActiveMQSession.java
> A work-around is to specify the timeToLive value in the producer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira