You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2022/08/25 05:54:08 UTC

[Bug 8032] New: DCC meta failure

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8032

            Bug ID: 8032
           Summary: DCC meta failure
           Product: Spamassassin
           Version: 4.0.0
          Hardware: All
                OS: All
            Status: NEW
          Severity: blocker
          Priority: P2
         Component: Plugins
          Assignee: dev@spamassassin.apache.org
          Reporter: apache@hege.li
  Target Milestone: Undefined

Noticed t/dcc.t failures for 4.0.0-rc1 when dcc responses are slow

t/dcc.t ........................... # Note: Failure may not be an SpamAssassin
bug, as DCC tests can fail due to problems with the DCC servers.
t/dcc.t ........................... 5/16        Not found: pos =  3.3
X_META_POS  at t/dcc.t line 51.

#   Failed test at t/SATest.pm line 926.
        Found anti-pattern: neg =  X_META_NEG  at t/dcc.t line 51.

#   Failed test at t/SATest.pm line 937.
Output can be examined in: log/dcc.usiJXX/d.dcc/4
t/dcc.t ........................... 9/16        Not found: pos =  3.3
X_META_POS  at t/dcc.t line 53.

#   Failed test at t/SATest.pm line 926.
        Found anti-pattern: neg =  X_META_NEG  at t/dcc.t line 53.

#   Failed test at t/SATest.pm line 937.
Output can be examined in: log/dcc.usiJXX/d.dcc/8
# Looks like you failed 4 tests of 16.


Aug 25 08:22:03.364 [2311390] dbg: dcc: still waiting for dccifd response
Aug 25 08:22:03.364 [2311390] dbg: rules: ran meta rule X_META_NEG ======> got
hit (1)

--> meta X_META_NEG !DCC_CHECK

It should not be possible for X_META_NEG to hit, unless DCC async status is
somehow marked prematurely ready. Need to investigate.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8032] [review] DCC meta failure

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8032

Sidney Markowitz <si...@sidney.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sidney@sidney.com

--- Comment #5 from Sidney Markowitz <si...@sidney.com> ---
+1 for the fix

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8032] [review] DCC meta failure

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8032

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #6 from Henrik Krohns <ap...@hege.li> ---
Sending        trunk/lib/Mail/SpamAssassin/Plugin/DCC.pm
Transmitting file data .done
Committing transaction...
Committed revision 1903693.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8032] DCC meta failure

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8032

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |apache@hege.li

--- Comment #1 from Henrik Krohns <ap...@hege.li> ---
Created attachment 5801
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5801&action=edit
async fix

In this case, check_dcc() was called before check_dnsbl() and the logic did not
handle that properly. Just needs an additional check in check_dcc() to check if
async is active.

Vote to commit.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8032] [review] DCC meta failure

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8032

Bill Cole <bi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |billcole@apache.org

--- Comment #3 from Bill Cole <bi...@apache.org> ---
+1 for the fix

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8032] [review] DCC meta failure

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8032

Giovanni Bechis <gi...@paclan.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |giovanni@paclan.it

--- Comment #2 from Giovanni Bechis <gi...@paclan.it> ---
+1 for me on the fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8032] [review] DCC meta failure

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8032

Kevin A. McGrail <km...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@apache.org

--- Comment #4 from Kevin A. McGrail <km...@apache.org> ---
+1 for the fix -KAM

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 8032] [review] DCC meta failure

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8032

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |4.0.0
            Summary|DCC meta failure            |[review] DCC meta failure

-- 
You are receiving this mail because:
You are the assignee for the bug.