[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #940: HADOOP-16341. ShutDownHookManager: Regressed performance on Hook remo…

[GitBox <gi...@apache.org>]

hadoop-yetus commented on a change in pull request #940: HADOOP-16341. ShutDownHookManager: Regressed performance on Hook remo…
URL: https://github.com/apache/hadoop/pull/940#discussion_r293165684
 
 

 ##########
 File path: hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/ShutdownHookManager.java
 ##########
 @@ -342,7 +342,9 @@ public boolean removeShutdownHook(Runnable shutdownHook) {
       throw new IllegalStateException("Shutdown in progress, cannot remove a " +
           "shutdownHook");
     }
-    return hooks.remove(new HookEntry(shutdownHook, 0));
+    // hooks are only == by runnable
+    return hooks.remove(new HookEntry(shutdownHook, 0, TIMEOUT_MINIMUM,
+	        TIME_UNIT_DEFAULT));
 
 Review comment:
   whitespace:tabs in line
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org