[GitHub] [airflow] josh-fell commented on a diff in pull request #24836: Move all SQL classes to common-sql provider

[GitBox <gi...@apache.org>]

josh-fell commented on code in PR #24836:
URL: https://github.com/apache/airflow/pull/24836#discussion_r914128448


##########
airflow/hooks/dbapi_hook.py:
##########
@@ -19,8 +19,6 @@
 
 import warnings
 
-from airflow.hooks.dbapi import DbApiHook  # noqa
-
 warnings.warn(
     "This module is deprecated. Please use `airflow.hooks.dbapi`.", DeprecationWarning, stacklevel=2

Review Comment:
   Should this deprecation message also reflect the new provider location for the hook too?



##########
docs/apache-airflow-providers-cncf-kubernetes/operators.rst:
##########
@@ -89,6 +89,7 @@ Using this method will ensure correctness
 and type safety. While we have removed almost all Kubernetes convenience classes, we have kept the
 :class:`~airflow.kubernetes.secret.Secret` class to simplify the process of generating secret volumes/env variables.
 
+.. exampleinclude:: /../../tests/system/providers/cncf/kubernetes/example_kubernetes.py

Review Comment:
   This looks like a duplicate line?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org