You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/22 08:29:02 UTC
[GitHub] [flink] dawidwys opened a new pull request #14979: Flink 19970 2
dawidwys opened a new pull request #14979:
URL: https://github.com/apache/flink/pull/14979
## What is the purpose of the change
The PR fixes a bug that nodes with timed out paths only can still be held back by nodes that have edges that are not timed out from different runs. In turn this can lead to ever growing state for certain patterns such as e.g. a* where each record starts a new pattern.
This PR drops direct savepoint backwards compatibility with Flink <= 1.5 in order to simplify the migration code a bit.
## Verifying this change
* Added test
* All previous tests run
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (**yes** / no / don't know)
- The runtime per-record code paths (performance sensitive): (**yes** / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / **docs** / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14979: [FLINK-19970] State leak in CEP Operators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14979:
URL: https://github.com/apache/flink/pull/14979#issuecomment-783202987
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2d5c25ea80baf2b250540d555429d3a61888374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f2d5c25ea80baf2b250540d555429d3a61888374",
"triggerType" : "PUSH"
}, {
"hash" : "93fee7cc42a9e7f05e87492ef26265062da2e486",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "93fee7cc42a9e7f05e87492ef26265062da2e486",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2d5c25ea80baf2b250540d555429d3a61888374 UNKNOWN
* 93fee7cc42a9e7f05e87492ef26265062da2e486 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14979: Flink 19970 2
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14979:
URL: https://github.com/apache/flink/pull/14979#issuecomment-783192815
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f2d5c25ea80baf2b250540d555429d3a61888374 (Mon Feb 22 08:31:04 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] aljoscha commented on a change in pull request #14979: [FLINK-19970] State leak in CEP Operators
Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #14979:
URL: https://github.com/apache/flink/pull/14979#discussion_r580901535
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBufferAccessor.java
##########
@@ -225,10 +227,15 @@ public NodeId put(
*
* @param node id of the entry
*/
- public void lockNode(final NodeId node) {
+ public void lockNode(final NodeId node, final DeweyNumber version) {
Review comment:
Missing javadocs for the new parameter.
##########
File path: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBufferAccessor.java
##########
@@ -240,10 +247,12 @@ public void lockNode(final NodeId node) {
* @param node id of the entry
* @throws Exception Thrown if the system cannot access the state.
*/
- public void releaseNode(final NodeId node) throws Exception {
+ public void releaseNode(final NodeId node, final DeweyNumber version) throws Exception {
Review comment:
Also missing javadocs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14979: [FLINK-19970] State leak in CEP Operators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14979:
URL: https://github.com/apache/flink/pull/14979#issuecomment-783202987
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2d5c25ea80baf2b250540d555429d3a61888374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f2d5c25ea80baf2b250540d555429d3a61888374",
"triggerType" : "PUSH"
}, {
"hash" : "93fee7cc42a9e7f05e87492ef26265062da2e486",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13566",
"triggerID" : "93fee7cc42a9e7f05e87492ef26265062da2e486",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2d5c25ea80baf2b250540d555429d3a61888374 UNKNOWN
* 93fee7cc42a9e7f05e87492ef26265062da2e486 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13566)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #14979: [FLINK-19970] State leak in CEP Operators
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #14979:
URL: https://github.com/apache/flink/pull/14979
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14979: [FLINK-19970] State leak in CEP Operators
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14979:
URL: https://github.com/apache/flink/pull/14979#issuecomment-783202987
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2d5c25ea80baf2b250540d555429d3a61888374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f2d5c25ea80baf2b250540d555429d3a61888374",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2d5c25ea80baf2b250540d555429d3a61888374 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14979: [FLINK-19970] State leak in CEP Operators
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14979:
URL: https://github.com/apache/flink/pull/14979#issuecomment-783202987
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f2d5c25ea80baf2b250540d555429d3a61888374",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f2d5c25ea80baf2b250540d555429d3a61888374",
"triggerType" : "PUSH"
}, {
"hash" : "93fee7cc42a9e7f05e87492ef26265062da2e486",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13566",
"triggerID" : "93fee7cc42a9e7f05e87492ef26265062da2e486",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f2d5c25ea80baf2b250540d555429d3a61888374 UNKNOWN
* 93fee7cc42a9e7f05e87492ef26265062da2e486 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13566)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org