[GitHub] [httpcomponents-client] michael-o commented on a change in pull request #287: Fix the issues causing Kerberos/SPNego to fail

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #287:
URL: https://github.com/apache/httpcomponents-client/pull/287#discussion_r579679123



##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/auth/GGSSchemeBase.java
##########
@@ -73,7 +72,8 @@
     }
 
     private static final Logger LOG = LoggerFactory.getLogger(GGSSchemeBase.class);
-
+    private static final String NO_TOKEN = "";
+    private static final String KERBEROS_SCHEME = "HTTP";

Review comment:
       This name is semantically wrong! It is a service class and not a Kerberos scheme. I also don't understand why make a difference between `null` and `#isEmpty()` with a static final field.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org