You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "tomsun28 (via GitHub)" <gi...@apache.org> on 2023/10/11 10:25:14 UTC
[PR] shenyu admin register itself and others can call admin api through gateway [shenyu]
tomsun28 opened a new pull request, #5207:
URL: https://github.com/apache/shenyu/pull/5207
<!-- Describe your PR here; eg. Fixes #issueNo -->
- shenyu admin register itself and others can call admin api through gateway divide plugin
- alert report support config admin cluster register gateway api path
https://github.com/apache/shenyu/pull/5197 this support: alert report support config admin cluster multi servers
```
shenyu
alert:
enabled: true
# the shenyu admin servers or gateway path switch one to config
admins: localhost:9095
# the shenyu admin servers or gateway path switch one to config
gateway: localhost:9195/shenyu/admin/alert/report
```
<!--
Thank you for proposing a pull request. This template will guide you through the essential steps necessary for a pull request.
-->
Make sure that:
- [ ] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [ ] You submit test cases (unit or integration tests) that back your changes.
- [ ] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] shenyu admin register itself and others can call admin api through gateway [shenyu]
Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 commented on PR #5207:
URL: https://github.com/apache/shenyu/pull/5207#issuecomment-1759662290
close. do not call shenyu admin api through shenyu gateway
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] shenyu admin register itself and others can call admin api through gateway [shenyu]
Posted by "lianjunwei (via GitHub)" <gi...@apache.org>.
lianjunwei commented on code in PR #5207:
URL: https://github.com/apache/shenyu/pull/5207#discussion_r1354901150
##########
shenyu-admin/pom.xml:
##########
@@ -313,6 +313,12 @@
<artifactId>shenyu-discovery-zookeeper</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.shenyu</groupId>
+ <artifactId>shenyu-spring-boot-starter-client-springmvc</artifactId>
+ <version>${project.version}</version>
Review Comment:
This solution of introducing client jars feels too heavy and not elegant. It should be better to use a listener (such as org. apache. shenyu. admin. listener. Application Start Listener) to directly call the internal method to initiate the registration process after the admin is started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] shenyu admin register itself and others can call admin api through gateway [shenyu]
Posted by "lianjunwei (via GitHub)" <gi...@apache.org>.
lianjunwei commented on code in PR #5207:
URL: https://github.com/apache/shenyu/pull/5207#discussion_r1355086593
##########
shenyu-admin/pom.xml:
##########
@@ -313,6 +313,12 @@
<artifactId>shenyu-discovery-zookeeper</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.shenyu</groupId>
+ <artifactId>shenyu-spring-boot-starter-client-springmvc</artifactId>
+ <version>${project.version}</version>
Review Comment:
After thinking about it, the "sdk+annotation" solution is perfect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] shenyu admin register itself and others can call admin api through gateway [shenyu]
Posted by "lianjunwei (via GitHub)" <gi...@apache.org>.
lianjunwei commented on code in PR #5207:
URL: https://github.com/apache/shenyu/pull/5207#discussion_r1354901150
##########
shenyu-admin/pom.xml:
##########
@@ -313,6 +313,12 @@
<artifactId>shenyu-discovery-zookeeper</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.shenyu</groupId>
+ <artifactId>shenyu-spring-boot-starter-client-springmvc</artifactId>
+ <version>${project.version}</version>
Review Comment:
This solution of introducing client jars feels too heavy and not elegant. It should be better to use a listener (such as `org.apache.shenyu.admin.listener.ApplicationStartListener`) to directly call the internal method to initiate the registration process after the admin is started.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] shenyu admin register itself and others can call admin api through gateway [shenyu]
Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 commented on code in PR #5207:
URL: https://github.com/apache/shenyu/pull/5207#discussion_r1355079377
##########
shenyu-admin/pom.xml:
##########
@@ -313,6 +313,12 @@
<artifactId>shenyu-discovery-zookeeper</artifactId>
<version>${project.version}</version>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.shenyu</groupId>
+ <artifactId>shenyu-spring-boot-starter-client-springmvc</artifactId>
+ <version>${project.version}</version>
Review Comment:
we need sdk's annotation and config yml meta data. If call the internal method to register api directly, the meta info and api info also need to construct. After WeChat with @lianjunwei, we think it is better to use client sdk to register.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] shenyu admin register itself and others can call admin api through gateway [shenyu]
Posted by "tomsun28 (via GitHub)" <gi...@apache.org>.
tomsun28 closed pull request #5207: shenyu admin register itself and others can call admin api through gateway
URL: https://github.com/apache/shenyu/pull/5207
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org