[GitHub] [skywalking-go] wu-sheng commented on a diff in pull request #11: Support init the skywalking tracer in the application

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #11:
URL: https://github.com/apache/skywalking-go/pull/11#discussion_r1174402321


##########
tools/go-agent/instrument/instrument.go:
##########
@@ -31,14 +31,18 @@ import (
 
 	"github.com/apache/skywalking-go/tools/go-agent/instrument/agentcore"
 	"github.com/apache/skywalking-go/tools/go-agent/instrument/api"
+	"github.com/apache/skywalking-go/tools/go-agent/instrument/entry"
 	"github.com/apache/skywalking-go/tools/go-agent/instrument/framework"
+	"github.com/apache/skywalking-go/tools/go-agent/instrument/reporter"
 	"github.com/apache/skywalking-go/tools/go-agent/instrument/runtime"
 	"github.com/apache/skywalking-go/tools/go-agent/tools"
 )
 
 var instruments = []api.Instrument{
 	runtime.NewInstrument(),
 	agentcore.NewInstrument(),
+	reporter.NewGRPCInstrument(),
+	entry.NewInstrument(),
 	framework.NewInstrument(),

Review Comment:
   Could you explain what do you mean `NewXXXInstrument`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org