You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/07/03 20:06:20 UTC

[GitHub] [submarine] MortalHappiness opened a new pull request #639: SUBMARINE-890. Extract all resource creation spec

MortalHappiness opened a new pull request #639:
URL: https://github.com/apache/submarine/pull/639


   ### What is this PR for?
   Extract all resource creation spec into functions so the code is more readable.
   
   ### What type of PR is it?
   [Refactoring]
   
   ### Todos
   * [x] - Make controller be a standalone package
   * [x] - Extract resource creation spec into functions
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-890
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] asfgit closed pull request #639: SUBMARINE-890. Extract all resource creation spec

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #639:
URL: https://github.com/apache/submarine/pull/639


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [submarine] MortalHappiness commented on pull request #639: SUBMARINE-890. Extract all resource creation spec

Posted by GitBox <gi...@apache.org>.
MortalHappiness commented on pull request #639:
URL: https://github.com/apache/submarine/pull/639#issuecomment-873463573


   @kevin85421 Can you help me review this PR? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org