You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2012/07/23 12:49:34 UTC
[jira] [Commented] (JCR-3396) Simplify the code when possible
[ https://issues.apache.org/jira/browse/JCR-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420550#comment-13420550 ]
Julian Reschke commented on JCR-3396:
-------------------------------------
- the "else" is unnecessary if the "if" block always returns
I don't consider this an improvement; having return calls always at the same level has also advantages with respect to readability.
> Simplify the code when possible
> -------------------------------
>
> Key: JCR-3396
> URL: https://issues.apache.org/jira/browse/JCR-3396
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Reporter: Thomas Mueller
> Priority: Minor
>
> Sometimes it's possible to simplify the code, for example:
> - making methods static when possible, so a reader knows the method doesn't change the state of an object
> - the "else" is unnecessary if the "if" block always returns
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira