You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flink.apache.org by Stephan Ewen <se...@apache.org> on 2014/12/10 19:35:04 UTC
Forking off the 0.8 release branch.
Hi everyone!
I would suggest to fork a 0.8 release branch very soon, to not stall the
development of features that go into 0.9. The new Akka based coordination
and the network stack extensions are required for many new features which
are in the pipeline.
How about we merge the below listed pull requests into the master, and then
branch the 0.8 release branch off and bump the master version to
0.9-SNAPSHOT.
After we have forked the release branch, Marton (as release manager) would
create release candidates and collect status of the tests and patches. We
can fix bugs on the release branch and cherry-pick the patches to the
0.9-SNAPSHOT branch.
----------------------------------------------
Important Pull Requests to merge:
----------------------------------------------
[FLINK-1287] LocalizableSplitAssigner prefers splits with less degrees of
freedom
Fixed java quickstart example
[FLINK-998] Close TCP connections after destroying logical channels
[FLINK-1302] Make JDBCInputFormat implement the NonParallelInput interface
[FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and NullWritable
support
Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
ExecutionEnvironment
(this is partially merged, there are a few POM entries missing for Hadoop 1
support)
----------------------------------------------
Optional Pull Requests to merge:
----------------------------------------------
Add support for Subclasses, Interfaces, Abstract Classes as POJOs
[FLINK-1245] Introduce TypeHints for Java API operators
enable CSV Reader to ignore invalid lines like an empty line at the end and
comments - FLINK-1208
Please veto the important pull requests (if they should not go in) and +1
or -1 the optional ones, as you deem fitting.
Greetings,
Stephan
Re: Forking off the 0.8 release branch.
Posted by Fabian Hueske <fh...@apache.org>.
+1
2014-12-11 11:00 GMT+01:00 Till Rohrmann <tr...@apache.org>:
>
> +1
>
> Looking forward merging the Akka changes into the 0.9-SNAPSHOT master.
>
> On Wed, Dec 10, 2014 at 9:06 PM, Robert Metzger <rm...@apache.org>
> wrote:
>
> > +1.
> >
> > I think adding the TypeHints pull request to the release is a good idea.
> > This allows us to give users a workaround if the type extraction is not
> > working.
> >
> > I'll have a look at the Hbase hadoop1 support.
> >
> > On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org> wrote:
> >
> > > Hi everyone!
> > >
> > > I would suggest to fork a 0.8 release branch very soon, to not stall
> the
> > > development of features that go into 0.9. The new Akka based
> coordination
> > > and the network stack extensions are required for many new features
> which
> > > are in the pipeline.
> > >
> > > How about we merge the below listed pull requests into the master, and
> > then
> > > branch the 0.8 release branch off and bump the master version to
> > > 0.9-SNAPSHOT.
> > >
> > > After we have forked the release branch, Marton (as release manager)
> > would
> > > create release candidates and collect status of the tests and patches.
> We
> > > can fix bugs on the release branch and cherry-pick the patches to the
> > > 0.9-SNAPSHOT branch.
> > >
> > > ----------------------------------------------
> > > Important Pull Requests to merge:
> > > ----------------------------------------------
> > >
> > > [FLINK-1287] LocalizableSplitAssigner prefers splits with less degrees
> of
> > > freedom
> > >
> > > Fixed java quickstart example
> > >
> > > [FLINK-998] Close TCP connections after destroying logical channels
> > >
> > > [FLINK-1302] Make JDBCInputFormat implement the NonParallelInput
> > interface
> > >
> > > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and NullWritable
> > > support
> > >
> > > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
> > > ExecutionEnvironment
> > > (this is partially merged, there are a few POM entries missing for
> > Hadoop 1
> > > support)
> > >
> > >
> > > ----------------------------------------------
> > > Optional Pull Requests to merge:
> > > ----------------------------------------------
> > >
> > > Add support for Subclasses, Interfaces, Abstract Classes as POJOs
> > >
> > > [FLINK-1245] Introduce TypeHints for Java API operators
> > >
> > > enable CSV Reader to ignore invalid lines like an empty line at the end
> > and
> > > comments - FLINK-1208
> > >
> > >
> > > Please veto the important pull requests (if they should not go in) and
> +1
> > > or -1 the optional ones, as you deem fitting.
> > >
> > >
> > > Greetings,
> > > Stephan
> > >
> >
>
Re: Forking off the 0.8 release branch.
Posted by Till Rohrmann <tr...@apache.org>.
+1
Looking forward merging the Akka changes into the 0.9-SNAPSHOT master.
On Wed, Dec 10, 2014 at 9:06 PM, Robert Metzger <rm...@apache.org> wrote:
> +1.
>
> I think adding the TypeHints pull request to the release is a good idea.
> This allows us to give users a workaround if the type extraction is not
> working.
>
> I'll have a look at the Hbase hadoop1 support.
>
> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org> wrote:
>
> > Hi everyone!
> >
> > I would suggest to fork a 0.8 release branch very soon, to not stall the
> > development of features that go into 0.9. The new Akka based coordination
> > and the network stack extensions are required for many new features which
> > are in the pipeline.
> >
> > How about we merge the below listed pull requests into the master, and
> then
> > branch the 0.8 release branch off and bump the master version to
> > 0.9-SNAPSHOT.
> >
> > After we have forked the release branch, Marton (as release manager)
> would
> > create release candidates and collect status of the tests and patches. We
> > can fix bugs on the release branch and cherry-pick the patches to the
> > 0.9-SNAPSHOT branch.
> >
> > ----------------------------------------------
> > Important Pull Requests to merge:
> > ----------------------------------------------
> >
> > [FLINK-1287] LocalizableSplitAssigner prefers splits with less degrees of
> > freedom
> >
> > Fixed java quickstart example
> >
> > [FLINK-998] Close TCP connections after destroying logical channels
> >
> > [FLINK-1302] Make JDBCInputFormat implement the NonParallelInput
> interface
> >
> > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and NullWritable
> > support
> >
> > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
> > ExecutionEnvironment
> > (this is partially merged, there are a few POM entries missing for
> Hadoop 1
> > support)
> >
> >
> > ----------------------------------------------
> > Optional Pull Requests to merge:
> > ----------------------------------------------
> >
> > Add support for Subclasses, Interfaces, Abstract Classes as POJOs
> >
> > [FLINK-1245] Introduce TypeHints for Java API operators
> >
> > enable CSV Reader to ignore invalid lines like an empty line at the end
> and
> > comments - FLINK-1208
> >
> >
> > Please veto the important pull requests (if they should not go in) and +1
> > or -1 the optional ones, as you deem fitting.
> >
> >
> > Greetings,
> > Stephan
> >
>
Re: Forking off the 0.8 release branch.
Posted by Robert Metzger <rm...@apache.org>.
+1.
I think adding the TypeHints pull request to the release is a good idea.
This allows us to give users a workaround if the type extraction is not
working.
I'll have a look at the Hbase hadoop1 support.
On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org> wrote:
> Hi everyone!
>
> I would suggest to fork a 0.8 release branch very soon, to not stall the
> development of features that go into 0.9. The new Akka based coordination
> and the network stack extensions are required for many new features which
> are in the pipeline.
>
> How about we merge the below listed pull requests into the master, and then
> branch the 0.8 release branch off and bump the master version to
> 0.9-SNAPSHOT.
>
> After we have forked the release branch, Marton (as release manager) would
> create release candidates and collect status of the tests and patches. We
> can fix bugs on the release branch and cherry-pick the patches to the
> 0.9-SNAPSHOT branch.
>
> ----------------------------------------------
> Important Pull Requests to merge:
> ----------------------------------------------
>
> [FLINK-1287] LocalizableSplitAssigner prefers splits with less degrees of
> freedom
>
> Fixed java quickstart example
>
> [FLINK-998] Close TCP connections after destroying logical channels
>
> [FLINK-1302] Make JDBCInputFormat implement the NonParallelInput interface
>
> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and NullWritable
> support
>
> Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
> ExecutionEnvironment
> (this is partially merged, there are a few POM entries missing for Hadoop 1
> support)
>
>
> ----------------------------------------------
> Optional Pull Requests to merge:
> ----------------------------------------------
>
> Add support for Subclasses, Interfaces, Abstract Classes as POJOs
>
> [FLINK-1245] Introduce TypeHints for Java API operators
>
> enable CSV Reader to ignore invalid lines like an empty line at the end and
> comments - FLINK-1208
>
>
> Please veto the important pull requests (if they should not go in) and +1
> or -1 the optional ones, as you deem fitting.
>
>
> Greetings,
> Stephan
>
Re: Forking off the 0.8 release branch.
Posted by Henry Saputra <he...@gmail.com>.
Nice! =)
- Henry
On Tue, Jan 6, 2015 at 12:03 PM, Márton Balassi
<ba...@gmail.com> wrote:
> It turns out that we received the new repo and the ldap group at the same
> time - so I guess problem solved. ;)
>
> On Tue, Jan 6, 2015 at 8:03 PM, Robert Metzger <rm...@apache.org> wrote:
>
>> >
>> > When you said "finish the release" meaning distribute/publish a TLP
>> > release in the incubating branch repo?
>>
>>
>> Marton did like 40% of the release work by now. I think it would be best if
>> Marton gets his chance to finish the release. Sadly, the TLP migration
>> seems to block it right now.
>> The release will look like a TLP release even though our repo is called
>> "incubator-flink". We already got our release directory, so the artifacts
>> won't be published from the incubator.
>> From my point of view only the ldap group + nexus setup is missing for a
>> TLP release.
>>
>> Once we have our new repo, we can just push the release branch to that repo
>> as well. The commit hash (thats the one really relevant for the release)
>> won't change.
>>
>>
>>
>> On Tue, Jan 6, 2015 at 7:09 PM, Henry Saputra <he...@gmail.com>
>> wrote:
>>
>> > Hi Márton,
>> >
>> > Yes, we could and should move to non-incubating repo. I think Robert
>> > and Stephan are working with Infra to make it happen.
>> >
>> > My question is more should we wait till migration happen or should we
>> > publish non-incubating release artifact to ASF diet and mvn central
>> > from our incubating source repository instead.
>> >
>> > - Henry
>> >
>> > On Mon, Jan 5, 2015 at 2:37 PM, Márton Balassi <balassi.marton@gmail.com
>> >
>> > wrote:
>> > > I assume that infra graduation means that we can move to the
>> > non-incubating
>> > > repo as well.
>> > >
>> > > Also to the best of my knowledge the release is not connected to the
>> > > incubating repo itself. Of course it can be listed on github as well,
>> but
>> > > what makes an apache release is that it can be downloaded from the
>> apache
>> > > distribution mirrors (where it is signed correctly) and from maven
>> > central
>> > > (provided by the apache repository infrastructure). But please correct
>> me
>> > > if I'm wrong.
>> > >
>> > > On Mon, Jan 5, 2015 at 11:20 PM, Henry Saputra <
>> henry.saputra@gmail.com>
>> > > wrote:
>> > >
>> > >> When you said "finish the release" meaning distribute/publish a TLP
>> > >> release in the incubating branch repo?
>> > >>
>> > >> - Henry
>> > >>
>> > >> On Mon, Jan 5, 2015 at 6:38 AM, Robert Metzger <rm...@apache.org>
>> > >> wrote:
>> > >> > Allright .. I've asked infra and they plan to do the graduation this
>> > week
>> > >> > ("hopefully today/tomorrow").
>> > >> > If that is really going to happen in the next days, I would suggest
>> to
>> > >> let
>> > >> > Marton finish the release. If there are any major delays due to
>> INFRA,
>> > >> I'll
>> > >> > do the release.
>> > >> >
>> > >> > On Fri, Jan 2, 2015 at 10:37 AM, Robert Metzger <
>> rmetzger@apache.org>
>> > >> wrote:
>> > >> >
>> > >> >> Thanks for the update.
>> > >> >>
>> > >> >> Happy new year to everyone.
>> > >> >>
>> > >> >> It seems that we have to wait for INFRA to finish the LDAP group
>> > >> creation
>> > >> >> for the new TLP first, since this is connected to the maven
>> > repository.
>> > >> >> If nothing happened until Monday, I'll ask infra on their IRC chat
>> if
>> > >> they
>> > >> >> can resolve the LDAP group creation.
>> > >> >>
>> > >> >>
>> > >> >> Robert
>> > >> >>
>> > >> >>
>> > >> >>
>> > >> >> On Fri, Jan 2, 2015 at 9:45 AM, Márton Balassi <
>> > >> balassi.marton@gmail.com>
>> > >> >> wrote:
>> > >> >>
>> > >> >>> Happy new year Flinkers,
>> > >> >>>
>> > >> >>> I'm sorry that I could not report any progress on the release yet.
>> > It
>> > >> was
>> > >> >>> finally clarified that we are actually blocked by the apache
>> > >> >>> infrastructure
>> > >> >>> at the moment. [1]
>> > >> >>>
>> > >> >>> [1] https://issues.apache.org/jira/browse/INFRA-8954
>> > >> >>>
>> > >> >>> Marton
>> > >> >>>
>> > >> >>> On Fri, Dec 19, 2014 at 11:00 PM, Henry Saputra <
>> > >> henry.saputra@gmail.com>
>> > >> >>> wrote:
>> > >> >>>
>> > >> >>> > Thanks for the update Marton.
>> > >> >>> >
>> > >> >>> > So with we are graduating it is coming as blessing but
>> > unfortunately
>> > >> >>> > adding more work to the release process.
>> > >> >>> >
>> > >> >>> > Please do let us know if you need any help with the release.
>> > >> >>> >
>> > >> >>> > - Henry
>> > >> >>> >
>> > >> >>> > On Fri, Dec 19, 2014 at 12:38 PM, Márton Balassi
>> > >> >>> > <ba...@gmail.com> wrote:
>> > >> >>> > > +1 on quickstart, I'm having a look at it tomorrow.
>> > >> >>> > >
>> > >> >>> > > Robert also pointed out the the DISCLAIMER file (for
>> incubation,
>> > >> >>> > currently
>> > >> >>> > > also added to the distribution) is no longer needed neither on
>> > the
>> > >> >>> master
>> > >> >>> > > nor on the release branch. Other minor things in the repo
>> > regarding
>> > >> >>> the
>> > >> >>> > > graduation:
>> > >> >>> > >
>> > >> >>> > > * Eliminating the incubating subscript from the project
>> > version
>> > >> >>> > > * Updating the the docs (mostly mentioned in variables,
>> > >> sometimes in
>> > >> >>> > > since given version that should not be changed)
>> > >> >>> > > * Updating the quickstart scripts (more related to simply
>> > >> releasing)
>> > >> >>> > >
>> > >> >>> > > I'm deleting the DISCLAIMER from the repo and the assemblies,
>> > >> bumping
>> > >> >>> the
>> > >> >>> > > version and updating the parts of the docs that can be done
>> > prior
>> > >> to
>> > >> >>> the
>> > >> >>> > > release.
>> > >> >>> > >
>> > >> >>> > > As for the state of the relese: With the help of Robert I have
>> > >> >>> acquired
>> > >> >>> > the
>> > >> >>> > > necessary knowledge and set up the tools needed for the
>> > release. I
>> > >> >>> have
>> > >> >>> > > still minor issues with maven, but I'm confident that the
>> > solution
>> > >> is
>> > >> >>> > near.
>> > >> >>> > > I also fell motivated to write down my experiences in a
>> > >> documentation
>> > >> >>> to
>> > >> >>> > > spare some time for up and coming release managers.
>> > >> >>> > >
>> > >> >>> > > Best,
>> > >> >>> > >
>> > >> >>> > > Marton
>> > >> >>> > >
>> > >> >>> > > On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <
>> > >> >>> aljoscha@apache.org>
>> > >> >>> > > wrote:
>> > >> >>> > >>
>> > >> >>> > >> +1
>> > >> >>> > >>
>> > >> >>> > >> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <
>> > >> rmetzger@apache.org
>> > >> >>> >
>> > >> >>> > >> wrote:
>> > >> >>> > >> > Hi guys,
>> > >> >>> > >> >
>> > >> >>> > >> > I vote to make this issue a release blocker:
>> > >> >>> > >> > https://issues.apache.org/jira/browse/FLINK-1225
>> > >> >>> > >> > Two users ran into the issue within 2 days. The quickstart
>> is
>> > >> mean
>> > >> >>> to
>> > >> >>> > >> give
>> > >> >>> > >> > new users a good experience.
>> > >> >>> > >> >
>> > >> >>> > >> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <
>> > >> sewen@apache.org>
>> > >> >>> > wrote:
>> > >> >>> > >> >>
>> > >> >>> > >> >> Hi!
>> > >> >>> > >> >>
>> > >> >>> > >> >> I forked a branch "release-0.8" and bumped the master
>> > version
>> > >> to
>> > >> >>> > >> >> "0.9-incubating-SNAPSHOT".
>> > >> >>> > >> >>
>> > >> >>> > >> >> The closure cleaner is merged. Robert has opened a PR for
>> > Kryo
>> > >> - I
>> > >> >>> > would
>> > >> >>> > >> >> suggest to merge that to "master", cherry-pick to
>> > "release-0.8"
>> > >> >>> and
>> > >> >>> > >> then:
>> > >> >>> > >> >> Merry releasing!
>> > >> >>> > >> >>
>> > >> >>> > >> >> Greetings,
>> > >> >>> > >> >> Stephan
>> > >> >>> > >> >>
>> > >> >>> > >> >>
>> > >> >>> > >> >>
>> > >> >>> > >> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
>> > >> >>> > >> balassi.marton@gmail.com>
>> > >> >>> > >> >> wrote:
>> > >> >>> > >> >> >
>> > >> >>> > >> >> > @Timo&Stephan: The streaming code uses this since last
>> > week
>> > >> [1],
>> > >> >>> > Timo
>> > >> >>> > >> >> > starting working on the issue prior way before that - so
>> > it
>> > >> also
>> > >> >>> > has
>> > >> >>> > >> to
>> > >> >>> > >> >> do
>> > >> >>> > >> >> > with the streaming team pushing last minute features to
>> be
>> > >> >>> > honest...
>> > >> >>> > >> >> >
>> > >> >>> > >> >> > Then are we waiting for the Java Clousure cleaner and
>> the
>> > >> Kyro
>> > >> >>> > >> support, I
>> > >> >>> > >> >> > guess.
>> > >> >>> > >> >> > Aljoscha has already issued a PR for the former, some
>> > >> additional
>> > >> >>> > >> testing
>> > >> >>> > >> >> is
>> > >> >>> > >> >> > needed from the looks of it. [2]
>> > >> >>> > >> >> >
>> > >> >>> > >> >> > [1]
>> > >> >>> > >> >> >
>> > >> >>> > >> >> >
>> > >> >>> > >> >>
>> > >> >>> > >>
>> > >> >>> >
>> > >> >>>
>> > >>
>> >
>> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
>> > >> >>> > >> >> > [2] https://github.com/apache/incubator-flink/pull/269
>> > >> >>> > >> >> >
>> > >> >>> > >> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <
>> > >> >>> flink@twalthr.com>
>> > >> >>> > >> wrote:
>> > >> >>> > >> >> > >
>> > >> >>> > >> >> > > Yes, I also think so. Stability is more important.
>> > >> >>> > >> >> > >
>> > >> >>> > >> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <
>> > >> >>> sewen@apache.org
>> > >> >>> > >:
>> > >> >>> > >> >> > > >
>> > >> >>> > >> >> > > > Yes, the fact that we both did not realize that
>> until
>> > now
>> > >> >>> sort
>> > >> >>> > of
>> > >> >>> > >> >> > reveals
>> > >> >>> > >> >> > > > that there are more implications than anticipated.
>> > That
>> > >> is
>> > >> >>> > never
>> > >> >>> > >> good
>> > >> >>> > >> >> > for
>> > >> >>> > >> >> > > > "last minute" patches.
>> > >> >>> > >> >> > > >
>> > >> >>> > >> >> > > > That's why I would like to merge it into 0.8.1 and
>> > 0.9,
>> > >> >>> rather
>> > >> >>> > >> than
>> > >> >>> > >> >> > 0.8.0
>> > >> >>> > >> >> > > > That gives the code a bit more testing/use and us a
>> > bit
>> > >> more
>> > >> >>> > time
>> > >> >>> > >> to
>> > >> >>> > >> >> > > > thoroughly think the implications through.
>> > >> >>> > >> >> > > >
>> > >> >>> > >> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <
>> > >> >>> > flink@twalthr.com
>> > >> >>> > >> >
>> > >> >>> > >> >> > > wrote:
>> > >> >>> > >> >> > > >>
>> > >> >>> > >> >> > > >> Sorry I totally forgot to check the streaming API.
>> Do
>> > >> they
>> > >> >>> use
>> > >> >>> > >> the
>> > >> >>> > >> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
>> > >> >>> > >> >> > > >>
>> > >> >>> > >> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
>> > >> >>> > >> rmetzger@apache.org
>> > >> >>> > >> >> >:
>> > >> >>> > >> >> > > >>>
>> > >> >>> > >> >> > > >>> I've worked on adding Kryo support to Flink
>> today. I
>> > >> would
>> > >> >>> > >> really
>> > >> >>> > >> >> > like
>> > >> >>> > >> >> > > to
>> > >> >>> > >> >> > > >>> include this into the release. Many users were
>> > >> complaining
>> > >> >>> > about
>> > >> >>> > >> >> > this (
>> > >> >>> > >> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
>> > >> >>> > >> >> > > >>>
>> > >> >>> > >> >> > > >>> I've based my work on top of Timo's pull request.
>> If
>> > >> we're
>> > >> >>> > not
>> > >> >>> > >> >> going
>> > >> >>> > >> >> > to
>> > >> >>> > >> >> > > >>> merge it, I will have to rebase my code to the
>> > current
>> > >> >>> > master.
>> > >> >>> > >> ...
>> > >> >>> > >> >> > I'll
>> > >> >>> > >> >> > > >> try
>> > >> >>> > >> >> > > >>> and see if its easily doable.
>> > >> >>> > >> >> > > >>>
>> > >> >>> > >> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
>> > >> >>> > >> sewen@apache.org>
>> > >> >>> > >> >> > > wrote:
>> > >> >>> > >> >> > > >>>>
>> > >> >>> > >> >> > > >>>> Yes, one thing I just realized is that the
>> > streaming
>> > >> API
>> > >> >>> is
>> > >> >>> > not
>> > >> >>> > >> >> > aware
>> > >> >>> > >> >> > > of
>> > >> >>> > >> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
>> > >> >>> > >> >> > > >>>>
>> > >> >>> > >> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
>> > >> >>> > >> >> fhueske@gmail.com>
>> > >> >>> > >> >> > > >> wrote:
>> > >> >>> > >> >> > > >>>>>
>> > >> >>> > >> >> > > >>>>> +1 for stability first
>> > >> >>> > >> >> > > >>>>>
>> > >> >>> > >> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <
>> > >> >>> sewen@apache.org
>> > >> >>> > >:
>> > >> >>> > >> >> > > >>>>>>
>> > >> >>> > >> >> > > >>>>>> I am currently working through the type hints
>> > pull
>> > >> >>> > request...
>> > >> >>> > >> >> > > >>>>>>
>> > >> >>> > >> >> > > >>>>>> Right now, I actually think that we should
>> > postpone
>> > >> >>> this
>> > >> >>> > for
>> > >> >>> > >> the
>> > >> >>> > >> >> > > next
>> > >> >>> > >> >> > > >>>>>> bugfix release.
>> > >> >>> > >> >> > > >>>>>>
>> > >> >>> > >> >> > > >>>>>> This pull request changes actually some tricky
>> > >> >>> mechanisms
>> > >> >>> > in
>> > >> >>> > >> the
>> > >> >>> > >> >> > > Java
>> > >> >>> > >> >> > > >>>> API
>> > >> >>> > >> >> > > >>>>>> (it delays the type information), which may
>> have
>> > >> >>> > implications
>> > >> >>> > >> >> that
>> > >> >>> > >> >> > > me
>> > >> >>> > >> >> > > >>>> and
>> > >> >>> > >> >> > > >>>>>> Timo have not fully caught now.
>> > >> >>> > >> >> > > >>>>>>
>> > >> >>> > >> >> > > >>>>>> I don't feel Merging this last minute - this is
>> > >> prone
>> > >> >>> to
>> > >> >>> > >> >> introduce
>> > >> >>> > >> >> > > >>>>> errors.
>> > >> >>> > >> >> > > >>>>>>
>> > >> >>> > >> >> > > >>>>>> Any opinions on that?
>> > >> >>> > >> >> > > >>>>>>
>> > >> >>> > >> >> > > >>>>>>
>> > >> >>> > >> >> > > >>>>>>
>> > >> >>> > >> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
>> > >> >>> > >> sewen@apache.org
>> > >> >>> > >> >> >
>> > >> >>> > >> >> > > >>>> wrote:
>> > >> >>> > >> >> > > >>>>>>>
>> > >> >>> > >> >> > > >>>>>>> +1 for adding the closure cleaner...
>> > >> >>> > >> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha
>> Krettek" <
>> > >> >>> > >> >> > > aljoscha@apache.org
>> > >> >>> > >> >> > > >>>>> :
>> > >> >>> > >> >> > > >>>>>>>
>> > >> >>> > >> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as
>> > well?
>> > >> >>> > >> >> > > >>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton
>> > Balassi
>> > >> >>> > >> >> > > >>>>>>>> <ba...@gmail.com> wrote:
>> > >> >>> > >> >> > > >>>>>>>>> Cool, thanks.
>> > >> >>> > >> >> > > >>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan
>> > Ewen <
>> > >> >>> > >> >> > sewen@apache.org
>> > >> >>> > >> >> > > >
>> > >> >>> > >> >> > > >>>>>>>> wrote:
>> > >> >>> > >> >> > > >>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>> Hi!
>> > >> >>> > >> >> > > >>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made
>> > some
>> > >> >>> final
>> > >> >>> > >> >> > adjustments
>> > >> >>> > >> >> > > >>>>>>>> yesterday
>> > >> >>> > >> >> > > >>>>>>>>>> evening. I'll review and merge it now, then
>> > we
>> > >> can
>> > >> >>> > fork
>> > >> >>> > >> the
>> > >> >>> > >> >> > > >>>> branch.
>> > >> >>> > >> >> > > >>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>> Cheers,
>> > >> >>> > >> >> > > >>>>>>>>>> Stephan
>> > >> >>> > >> >> > > >>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton
>> > >> Balassi <
>> > >> >>> > >> >> > > >>>>>>>> balassi.marton@gmail.com
>> > >> >>> > >> >> > > >>>>>>>>>> wrote:
>> > >> >>> > >> >> > > >>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>> Hey,
>> > >> >>> > >> >> > > >>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it
>> seems
>> > >> every
>> > >> >>> > import
>> > >> >>> > >> >> one
>> > >> >>> > >> >> > > >>>> has
>> > >> >>> > >> >> > > >>>>>> been
>> > >> >>> > >> >> > > >>>>>>>>>>> merged. As for the optional ones the
>> > following
>> > >> two
>> > >> >>> > are
>> > >> >>> > >> >> still
>> > >> >>> > >> >> > > >>>>>> pending:
>> > >> >>> > >> >> > > >>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces,
>> > >> Abstract
>> > >> >>> > >> Classes as
>> > >> >>> > >> >> > > >>>> POJOs
>> > >> >>> > >> >> > > >>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java
>> > API
>> > >> >>> > operators
>> > >> >>> > >> >> > > >>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has
>> > just
>> > >> >>> > updated
>> > >> >>> > >> it.
>> > >> >>> > >> >> > > >>>> Should
>> > >> >>> > >> >> > > >>>>>> we
>> > >> >>> > >> >> > > >>>>>>>> wait
>> > >> >>> > >> >> > > >>>>>>>>>>> for it?
>> > >> >>> > >> >> > > >>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>> Cheers,
>> > >> >>> > >> >> > > >>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>> Marton
>> > >> >>> > >> >> > > >>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk
>> > Celebi <
>> > >> >>> > >> >> uce@apache.org
>> > >> >>> > >> >> > >
>> > >> >>> > >> >> > > >>>>>> wrote:
>> > >> >>> > >> >> > > >>>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan
>> > Ewen
>> > >> <
>> > >> >>> > >> >> > > >>>>> sewen@apache.org>
>> > >> >>> > >> >> > > >>>>>>>>>> wrote:
>> > >> >>> > >> >> > > >>>>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>>>
>> > >> ----------------------------------------------
>> > >> >>> > >> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
>> > >> >>> > >> >> > > >>>>>>>>>>>>>
>> > >> ----------------------------------------------
>> > >> >>> > >> >> > > >>>>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner
>> > prefers
>> > >> >>> > splits
>> > >> >>> > >> with
>> > >> >>> > >> >> > > >>>>> less
>> > >> >>> > >> >> > > >>>>>>>>>> degrees
>> > >> >>> > >> >> > > >>>>>>>>>>> of
>> > >> >>> > >> >> > > >>>>>>>>>>>>> freedom
>> > >> >>> > >> >> > > >>>>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for
>> > >> >>> > HadoopInputWrapper
>> > >> >>> > >> and
>> > >> >>> > >> >> > > >>>>>>>>>> NullWritable
>> > >> >>> > >> >> > > >>>>>>>>>>>>> support
>> > >> >>> > >> >> > > >>>>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and
>> > new
>> > >> >>> Tuple
>> > >> >>> > >> APIs +
>> > >> >>> > >> >> > > >>>> fix
>> > >> >>> > >> >> > > >>>>>> of
>> > >> >>> > >> >> > > >>>>>>>>>>>>> ExecutionEnvironment
>> > >> >>> > >> >> > > >>>>>>>>>>>>> (this is partially merged, there are a
>> few
>> > >> POM
>> > >> >>> > entries
>> > >> >>> > >> >> > > >>>>> missing
>> > >> >>> > >> >> > > >>>>>>>> for
>> > >> >>> > >> >> > > >>>>>>>>>>>> Hadoop 1
>> > >> >>> > >> >> > > >>>>>>>>>>>>> support)
>> > >> >>> > >> >> > > >>>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>> The first two PRs are still open. I will
>> > have
>> > >> a
>> > >> >>> > look at
>> > >> >>> > >> >> them
>> > >> >>> > >> >> > > >>>> as
>> > >> >>> > >> >> > > >>>>>>>> well
>> > >> >>> > >> >> > > >>>>>>>>>>>> (Robert already tested one).
>> > >> >>> > >> >> > > >>>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>> @Robert:
>> > >> >>> > >> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by
>> > >> 1b69749
>> > >> >>> > >> ("Enable
>> > >> >>> > >> >> > > >>>>>>>> flink-hbase
>> > >> >>> > >> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
>> > >> >>> > >> >> > > >>>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>>
>> > >> >>> > >> >> > > >>>>>>>>>>>> It would be nice if had a look at the
>> > >> remaining
>> > >> >>> > >> important
>> > >> >>> > >> >> > > >>>> ones
>> > >> >>> > >> >> > > >>>>>>>> today.
>> > >> >>> > >> >> > > >>>>>>>>>> :-)
>> > >> >>> > >> >> > > >>
>> > >> >>> > >> >> > >
>> > >> >>> > >> >> >
>> > >> >>> > >> >>
>> > >> >>> > >>
>> > >> >>> >
>> > >> >>>
>> > >> >>
>> > >> >>
>> > >>
>> >
>>
Re: Forking off the 0.8 release branch.
Posted by Márton Balassi <ba...@gmail.com>.
It turns out that we received the new repo and the ldap group at the same
time - so I guess problem solved. ;)
On Tue, Jan 6, 2015 at 8:03 PM, Robert Metzger <rm...@apache.org> wrote:
> >
> > When you said "finish the release" meaning distribute/publish a TLP
> > release in the incubating branch repo?
>
>
> Marton did like 40% of the release work by now. I think it would be best if
> Marton gets his chance to finish the release. Sadly, the TLP migration
> seems to block it right now.
> The release will look like a TLP release even though our repo is called
> "incubator-flink". We already got our release directory, so the artifacts
> won't be published from the incubator.
> From my point of view only the ldap group + nexus setup is missing for a
> TLP release.
>
> Once we have our new repo, we can just push the release branch to that repo
> as well. The commit hash (thats the one really relevant for the release)
> won't change.
>
>
>
> On Tue, Jan 6, 2015 at 7:09 PM, Henry Saputra <he...@gmail.com>
> wrote:
>
> > Hi Márton,
> >
> > Yes, we could and should move to non-incubating repo. I think Robert
> > and Stephan are working with Infra to make it happen.
> >
> > My question is more should we wait till migration happen or should we
> > publish non-incubating release artifact to ASF diet and mvn central
> > from our incubating source repository instead.
> >
> > - Henry
> >
> > On Mon, Jan 5, 2015 at 2:37 PM, Márton Balassi <balassi.marton@gmail.com
> >
> > wrote:
> > > I assume that infra graduation means that we can move to the
> > non-incubating
> > > repo as well.
> > >
> > > Also to the best of my knowledge the release is not connected to the
> > > incubating repo itself. Of course it can be listed on github as well,
> but
> > > what makes an apache release is that it can be downloaded from the
> apache
> > > distribution mirrors (where it is signed correctly) and from maven
> > central
> > > (provided by the apache repository infrastructure). But please correct
> me
> > > if I'm wrong.
> > >
> > > On Mon, Jan 5, 2015 at 11:20 PM, Henry Saputra <
> henry.saputra@gmail.com>
> > > wrote:
> > >
> > >> When you said "finish the release" meaning distribute/publish a TLP
> > >> release in the incubating branch repo?
> > >>
> > >> - Henry
> > >>
> > >> On Mon, Jan 5, 2015 at 6:38 AM, Robert Metzger <rm...@apache.org>
> > >> wrote:
> > >> > Allright .. I've asked infra and they plan to do the graduation this
> > week
> > >> > ("hopefully today/tomorrow").
> > >> > If that is really going to happen in the next days, I would suggest
> to
> > >> let
> > >> > Marton finish the release. If there are any major delays due to
> INFRA,
> > >> I'll
> > >> > do the release.
> > >> >
> > >> > On Fri, Jan 2, 2015 at 10:37 AM, Robert Metzger <
> rmetzger@apache.org>
> > >> wrote:
> > >> >
> > >> >> Thanks for the update.
> > >> >>
> > >> >> Happy new year to everyone.
> > >> >>
> > >> >> It seems that we have to wait for INFRA to finish the LDAP group
> > >> creation
> > >> >> for the new TLP first, since this is connected to the maven
> > repository.
> > >> >> If nothing happened until Monday, I'll ask infra on their IRC chat
> if
> > >> they
> > >> >> can resolve the LDAP group creation.
> > >> >>
> > >> >>
> > >> >> Robert
> > >> >>
> > >> >>
> > >> >>
> > >> >> On Fri, Jan 2, 2015 at 9:45 AM, Márton Balassi <
> > >> balassi.marton@gmail.com>
> > >> >> wrote:
> > >> >>
> > >> >>> Happy new year Flinkers,
> > >> >>>
> > >> >>> I'm sorry that I could not report any progress on the release yet.
> > It
> > >> was
> > >> >>> finally clarified that we are actually blocked by the apache
> > >> >>> infrastructure
> > >> >>> at the moment. [1]
> > >> >>>
> > >> >>> [1] https://issues.apache.org/jira/browse/INFRA-8954
> > >> >>>
> > >> >>> Marton
> > >> >>>
> > >> >>> On Fri, Dec 19, 2014 at 11:00 PM, Henry Saputra <
> > >> henry.saputra@gmail.com>
> > >> >>> wrote:
> > >> >>>
> > >> >>> > Thanks for the update Marton.
> > >> >>> >
> > >> >>> > So with we are graduating it is coming as blessing but
> > unfortunately
> > >> >>> > adding more work to the release process.
> > >> >>> >
> > >> >>> > Please do let us know if you need any help with the release.
> > >> >>> >
> > >> >>> > - Henry
> > >> >>> >
> > >> >>> > On Fri, Dec 19, 2014 at 12:38 PM, Márton Balassi
> > >> >>> > <ba...@gmail.com> wrote:
> > >> >>> > > +1 on quickstart, I'm having a look at it tomorrow.
> > >> >>> > >
> > >> >>> > > Robert also pointed out the the DISCLAIMER file (for
> incubation,
> > >> >>> > currently
> > >> >>> > > also added to the distribution) is no longer needed neither on
> > the
> > >> >>> master
> > >> >>> > > nor on the release branch. Other minor things in the repo
> > regarding
> > >> >>> the
> > >> >>> > > graduation:
> > >> >>> > >
> > >> >>> > > * Eliminating the incubating subscript from the project
> > version
> > >> >>> > > * Updating the the docs (mostly mentioned in variables,
> > >> sometimes in
> > >> >>> > > since given version that should not be changed)
> > >> >>> > > * Updating the quickstart scripts (more related to simply
> > >> releasing)
> > >> >>> > >
> > >> >>> > > I'm deleting the DISCLAIMER from the repo and the assemblies,
> > >> bumping
> > >> >>> the
> > >> >>> > > version and updating the parts of the docs that can be done
> > prior
> > >> to
> > >> >>> the
> > >> >>> > > release.
> > >> >>> > >
> > >> >>> > > As for the state of the relese: With the help of Robert I have
> > >> >>> acquired
> > >> >>> > the
> > >> >>> > > necessary knowledge and set up the tools needed for the
> > release. I
> > >> >>> have
> > >> >>> > > still minor issues with maven, but I'm confident that the
> > solution
> > >> is
> > >> >>> > near.
> > >> >>> > > I also fell motivated to write down my experiences in a
> > >> documentation
> > >> >>> to
> > >> >>> > > spare some time for up and coming release managers.
> > >> >>> > >
> > >> >>> > > Best,
> > >> >>> > >
> > >> >>> > > Marton
> > >> >>> > >
> > >> >>> > > On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <
> > >> >>> aljoscha@apache.org>
> > >> >>> > > wrote:
> > >> >>> > >>
> > >> >>> > >> +1
> > >> >>> > >>
> > >> >>> > >> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <
> > >> rmetzger@apache.org
> > >> >>> >
> > >> >>> > >> wrote:
> > >> >>> > >> > Hi guys,
> > >> >>> > >> >
> > >> >>> > >> > I vote to make this issue a release blocker:
> > >> >>> > >> > https://issues.apache.org/jira/browse/FLINK-1225
> > >> >>> > >> > Two users ran into the issue within 2 days. The quickstart
> is
> > >> mean
> > >> >>> to
> > >> >>> > >> give
> > >> >>> > >> > new users a good experience.
> > >> >>> > >> >
> > >> >>> > >> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <
> > >> sewen@apache.org>
> > >> >>> > wrote:
> > >> >>> > >> >>
> > >> >>> > >> >> Hi!
> > >> >>> > >> >>
> > >> >>> > >> >> I forked a branch "release-0.8" and bumped the master
> > version
> > >> to
> > >> >>> > >> >> "0.9-incubating-SNAPSHOT".
> > >> >>> > >> >>
> > >> >>> > >> >> The closure cleaner is merged. Robert has opened a PR for
> > Kryo
> > >> - I
> > >> >>> > would
> > >> >>> > >> >> suggest to merge that to "master", cherry-pick to
> > "release-0.8"
> > >> >>> and
> > >> >>> > >> then:
> > >> >>> > >> >> Merry releasing!
> > >> >>> > >> >>
> > >> >>> > >> >> Greetings,
> > >> >>> > >> >> Stephan
> > >> >>> > >> >>
> > >> >>> > >> >>
> > >> >>> > >> >>
> > >> >>> > >> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
> > >> >>> > >> balassi.marton@gmail.com>
> > >> >>> > >> >> wrote:
> > >> >>> > >> >> >
> > >> >>> > >> >> > @Timo&Stephan: The streaming code uses this since last
> > week
> > >> [1],
> > >> >>> > Timo
> > >> >>> > >> >> > starting working on the issue prior way before that - so
> > it
> > >> also
> > >> >>> > has
> > >> >>> > >> to
> > >> >>> > >> >> do
> > >> >>> > >> >> > with the streaming team pushing last minute features to
> be
> > >> >>> > honest...
> > >> >>> > >> >> >
> > >> >>> > >> >> > Then are we waiting for the Java Clousure cleaner and
> the
> > >> Kyro
> > >> >>> > >> support, I
> > >> >>> > >> >> > guess.
> > >> >>> > >> >> > Aljoscha has already issued a PR for the former, some
> > >> additional
> > >> >>> > >> testing
> > >> >>> > >> >> is
> > >> >>> > >> >> > needed from the looks of it. [2]
> > >> >>> > >> >> >
> > >> >>> > >> >> > [1]
> > >> >>> > >> >> >
> > >> >>> > >> >> >
> > >> >>> > >> >>
> > >> >>> > >>
> > >> >>> >
> > >> >>>
> > >>
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
> > >> >>> > >> >> > [2] https://github.com/apache/incubator-flink/pull/269
> > >> >>> > >> >> >
> > >> >>> > >> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <
> > >> >>> flink@twalthr.com>
> > >> >>> > >> wrote:
> > >> >>> > >> >> > >
> > >> >>> > >> >> > > Yes, I also think so. Stability is more important.
> > >> >>> > >> >> > >
> > >> >>> > >> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <
> > >> >>> sewen@apache.org
> > >> >>> > >:
> > >> >>> > >> >> > > >
> > >> >>> > >> >> > > > Yes, the fact that we both did not realize that
> until
> > now
> > >> >>> sort
> > >> >>> > of
> > >> >>> > >> >> > reveals
> > >> >>> > >> >> > > > that there are more implications than anticipated.
> > That
> > >> is
> > >> >>> > never
> > >> >>> > >> good
> > >> >>> > >> >> > for
> > >> >>> > >> >> > > > "last minute" patches.
> > >> >>> > >> >> > > >
> > >> >>> > >> >> > > > That's why I would like to merge it into 0.8.1 and
> > 0.9,
> > >> >>> rather
> > >> >>> > >> than
> > >> >>> > >> >> > 0.8.0
> > >> >>> > >> >> > > > That gives the code a bit more testing/use and us a
> > bit
> > >> more
> > >> >>> > time
> > >> >>> > >> to
> > >> >>> > >> >> > > > thoroughly think the implications through.
> > >> >>> > >> >> > > >
> > >> >>> > >> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <
> > >> >>> > flink@twalthr.com
> > >> >>> > >> >
> > >> >>> > >> >> > > wrote:
> > >> >>> > >> >> > > >>
> > >> >>> > >> >> > > >> Sorry I totally forgot to check the streaming API.
> Do
> > >> they
> > >> >>> use
> > >> >>> > >> the
> > >> >>> > >> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
> > >> >>> > >> >> > > >>
> > >> >>> > >> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
> > >> >>> > >> rmetzger@apache.org
> > >> >>> > >> >> >:
> > >> >>> > >> >> > > >>>
> > >> >>> > >> >> > > >>> I've worked on adding Kryo support to Flink
> today. I
> > >> would
> > >> >>> > >> really
> > >> >>> > >> >> > like
> > >> >>> > >> >> > > to
> > >> >>> > >> >> > > >>> include this into the release. Many users were
> > >> complaining
> > >> >>> > about
> > >> >>> > >> >> > this (
> > >> >>> > >> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
> > >> >>> > >> >> > > >>>
> > >> >>> > >> >> > > >>> I've based my work on top of Timo's pull request.
> If
> > >> we're
> > >> >>> > not
> > >> >>> > >> >> going
> > >> >>> > >> >> > to
> > >> >>> > >> >> > > >>> merge it, I will have to rebase my code to the
> > current
> > >> >>> > master.
> > >> >>> > >> ...
> > >> >>> > >> >> > I'll
> > >> >>> > >> >> > > >> try
> > >> >>> > >> >> > > >>> and see if its easily doable.
> > >> >>> > >> >> > > >>>
> > >> >>> > >> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
> > >> >>> > >> sewen@apache.org>
> > >> >>> > >> >> > > wrote:
> > >> >>> > >> >> > > >>>>
> > >> >>> > >> >> > > >>>> Yes, one thing I just realized is that the
> > streaming
> > >> API
> > >> >>> is
> > >> >>> > not
> > >> >>> > >> >> > aware
> > >> >>> > >> >> > > of
> > >> >>> > >> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
> > >> >>> > >> >> > > >>>>
> > >> >>> > >> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
> > >> >>> > >> >> fhueske@gmail.com>
> > >> >>> > >> >> > > >> wrote:
> > >> >>> > >> >> > > >>>>>
> > >> >>> > >> >> > > >>>>> +1 for stability first
> > >> >>> > >> >> > > >>>>>
> > >> >>> > >> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <
> > >> >>> sewen@apache.org
> > >> >>> > >:
> > >> >>> > >> >> > > >>>>>>
> > >> >>> > >> >> > > >>>>>> I am currently working through the type hints
> > pull
> > >> >>> > request...
> > >> >>> > >> >> > > >>>>>>
> > >> >>> > >> >> > > >>>>>> Right now, I actually think that we should
> > postpone
> > >> >>> this
> > >> >>> > for
> > >> >>> > >> the
> > >> >>> > >> >> > > next
> > >> >>> > >> >> > > >>>>>> bugfix release.
> > >> >>> > >> >> > > >>>>>>
> > >> >>> > >> >> > > >>>>>> This pull request changes actually some tricky
> > >> >>> mechanisms
> > >> >>> > in
> > >> >>> > >> the
> > >> >>> > >> >> > > Java
> > >> >>> > >> >> > > >>>> API
> > >> >>> > >> >> > > >>>>>> (it delays the type information), which may
> have
> > >> >>> > implications
> > >> >>> > >> >> that
> > >> >>> > >> >> > > me
> > >> >>> > >> >> > > >>>> and
> > >> >>> > >> >> > > >>>>>> Timo have not fully caught now.
> > >> >>> > >> >> > > >>>>>>
> > >> >>> > >> >> > > >>>>>> I don't feel Merging this last minute - this is
> > >> prone
> > >> >>> to
> > >> >>> > >> >> introduce
> > >> >>> > >> >> > > >>>>> errors.
> > >> >>> > >> >> > > >>>>>>
> > >> >>> > >> >> > > >>>>>> Any opinions on that?
> > >> >>> > >> >> > > >>>>>>
> > >> >>> > >> >> > > >>>>>>
> > >> >>> > >> >> > > >>>>>>
> > >> >>> > >> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
> > >> >>> > >> sewen@apache.org
> > >> >>> > >> >> >
> > >> >>> > >> >> > > >>>> wrote:
> > >> >>> > >> >> > > >>>>>>>
> > >> >>> > >> >> > > >>>>>>> +1 for adding the closure cleaner...
> > >> >>> > >> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha
> Krettek" <
> > >> >>> > >> >> > > aljoscha@apache.org
> > >> >>> > >> >> > > >>>>> :
> > >> >>> > >> >> > > >>>>>>>
> > >> >>> > >> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as
> > well?
> > >> >>> > >> >> > > >>>>>>>>
> > >> >>> > >> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton
> > Balassi
> > >> >>> > >> >> > > >>>>>>>> <ba...@gmail.com> wrote:
> > >> >>> > >> >> > > >>>>>>>>> Cool, thanks.
> > >> >>> > >> >> > > >>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan
> > Ewen <
> > >> >>> > >> >> > sewen@apache.org
> > >> >>> > >> >> > > >
> > >> >>> > >> >> > > >>>>>>>> wrote:
> > >> >>> > >> >> > > >>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>> Hi!
> > >> >>> > >> >> > > >>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made
> > some
> > >> >>> final
> > >> >>> > >> >> > adjustments
> > >> >>> > >> >> > > >>>>>>>> yesterday
> > >> >>> > >> >> > > >>>>>>>>>> evening. I'll review and merge it now, then
> > we
> > >> can
> > >> >>> > fork
> > >> >>> > >> the
> > >> >>> > >> >> > > >>>> branch.
> > >> >>> > >> >> > > >>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>> Cheers,
> > >> >>> > >> >> > > >>>>>>>>>> Stephan
> > >> >>> > >> >> > > >>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton
> > >> Balassi <
> > >> >>> > >> >> > > >>>>>>>> balassi.marton@gmail.com
> > >> >>> > >> >> > > >>>>>>>>>> wrote:
> > >> >>> > >> >> > > >>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>> Hey,
> > >> >>> > >> >> > > >>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it
> seems
> > >> every
> > >> >>> > import
> > >> >>> > >> >> one
> > >> >>> > >> >> > > >>>> has
> > >> >>> > >> >> > > >>>>>> been
> > >> >>> > >> >> > > >>>>>>>>>>> merged. As for the optional ones the
> > following
> > >> two
> > >> >>> > are
> > >> >>> > >> >> still
> > >> >>> > >> >> > > >>>>>> pending:
> > >> >>> > >> >> > > >>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces,
> > >> Abstract
> > >> >>> > >> Classes as
> > >> >>> > >> >> > > >>>> POJOs
> > >> >>> > >> >> > > >>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java
> > API
> > >> >>> > operators
> > >> >>> > >> >> > > >>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has
> > just
> > >> >>> > updated
> > >> >>> > >> it.
> > >> >>> > >> >> > > >>>> Should
> > >> >>> > >> >> > > >>>>>> we
> > >> >>> > >> >> > > >>>>>>>> wait
> > >> >>> > >> >> > > >>>>>>>>>>> for it?
> > >> >>> > >> >> > > >>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>> Cheers,
> > >> >>> > >> >> > > >>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>> Marton
> > >> >>> > >> >> > > >>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk
> > Celebi <
> > >> >>> > >> >> uce@apache.org
> > >> >>> > >> >> > >
> > >> >>> > >> >> > > >>>>>> wrote:
> > >> >>> > >> >> > > >>>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan
> > Ewen
> > >> <
> > >> >>> > >> >> > > >>>>> sewen@apache.org>
> > >> >>> > >> >> > > >>>>>>>>>> wrote:
> > >> >>> > >> >> > > >>>>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>>>
> > >> ----------------------------------------------
> > >> >>> > >> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
> > >> >>> > >> >> > > >>>>>>>>>>>>>
> > >> ----------------------------------------------
> > >> >>> > >> >> > > >>>>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner
> > prefers
> > >> >>> > splits
> > >> >>> > >> with
> > >> >>> > >> >> > > >>>>> less
> > >> >>> > >> >> > > >>>>>>>>>> degrees
> > >> >>> > >> >> > > >>>>>>>>>>> of
> > >> >>> > >> >> > > >>>>>>>>>>>>> freedom
> > >> >>> > >> >> > > >>>>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for
> > >> >>> > HadoopInputWrapper
> > >> >>> > >> and
> > >> >>> > >> >> > > >>>>>>>>>> NullWritable
> > >> >>> > >> >> > > >>>>>>>>>>>>> support
> > >> >>> > >> >> > > >>>>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and
> > new
> > >> >>> Tuple
> > >> >>> > >> APIs +
> > >> >>> > >> >> > > >>>> fix
> > >> >>> > >> >> > > >>>>>> of
> > >> >>> > >> >> > > >>>>>>>>>>>>> ExecutionEnvironment
> > >> >>> > >> >> > > >>>>>>>>>>>>> (this is partially merged, there are a
> few
> > >> POM
> > >> >>> > entries
> > >> >>> > >> >> > > >>>>> missing
> > >> >>> > >> >> > > >>>>>>>> for
> > >> >>> > >> >> > > >>>>>>>>>>>> Hadoop 1
> > >> >>> > >> >> > > >>>>>>>>>>>>> support)
> > >> >>> > >> >> > > >>>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>> The first two PRs are still open. I will
> > have
> > >> a
> > >> >>> > look at
> > >> >>> > >> >> them
> > >> >>> > >> >> > > >>>> as
> > >> >>> > >> >> > > >>>>>>>> well
> > >> >>> > >> >> > > >>>>>>>>>>>> (Robert already tested one).
> > >> >>> > >> >> > > >>>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>> @Robert:
> > >> >>> > >> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by
> > >> 1b69749
> > >> >>> > >> ("Enable
> > >> >>> > >> >> > > >>>>>>>> flink-hbase
> > >> >>> > >> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
> > >> >>> > >> >> > > >>>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>>
> > >> >>> > >> >> > > >>>>>>>>>>>> It would be nice if had a look at the
> > >> remaining
> > >> >>> > >> important
> > >> >>> > >> >> > > >>>> ones
> > >> >>> > >> >> > > >>>>>>>> today.
> > >> >>> > >> >> > > >>>>>>>>>> :-)
> > >> >>> > >> >> > > >>
> > >> >>> > >> >> > >
> > >> >>> > >> >> >
> > >> >>> > >> >>
> > >> >>> > >>
> > >> >>> >
> > >> >>>
> > >> >>
> > >> >>
> > >>
> >
>
Re: Forking off the 0.8 release branch.
Posted by Robert Metzger <rm...@apache.org>.
>
> When you said "finish the release" meaning distribute/publish a TLP
> release in the incubating branch repo?
Marton did like 40% of the release work by now. I think it would be best if
Marton gets his chance to finish the release. Sadly, the TLP migration
seems to block it right now.
The release will look like a TLP release even though our repo is called
"incubator-flink". We already got our release directory, so the artifacts
won't be published from the incubator.
>From my point of view only the ldap group + nexus setup is missing for a
TLP release.
Once we have our new repo, we can just push the release branch to that repo
as well. The commit hash (thats the one really relevant for the release)
won't change.
On Tue, Jan 6, 2015 at 7:09 PM, Henry Saputra <he...@gmail.com>
wrote:
> Hi Márton,
>
> Yes, we could and should move to non-incubating repo. I think Robert
> and Stephan are working with Infra to make it happen.
>
> My question is more should we wait till migration happen or should we
> publish non-incubating release artifact to ASF diet and mvn central
> from our incubating source repository instead.
>
> - Henry
>
> On Mon, Jan 5, 2015 at 2:37 PM, Márton Balassi <ba...@gmail.com>
> wrote:
> > I assume that infra graduation means that we can move to the
> non-incubating
> > repo as well.
> >
> > Also to the best of my knowledge the release is not connected to the
> > incubating repo itself. Of course it can be listed on github as well, but
> > what makes an apache release is that it can be downloaded from the apache
> > distribution mirrors (where it is signed correctly) and from maven
> central
> > (provided by the apache repository infrastructure). But please correct me
> > if I'm wrong.
> >
> > On Mon, Jan 5, 2015 at 11:20 PM, Henry Saputra <he...@gmail.com>
> > wrote:
> >
> >> When you said "finish the release" meaning distribute/publish a TLP
> >> release in the incubating branch repo?
> >>
> >> - Henry
> >>
> >> On Mon, Jan 5, 2015 at 6:38 AM, Robert Metzger <rm...@apache.org>
> >> wrote:
> >> > Allright .. I've asked infra and they plan to do the graduation this
> week
> >> > ("hopefully today/tomorrow").
> >> > If that is really going to happen in the next days, I would suggest to
> >> let
> >> > Marton finish the release. If there are any major delays due to INFRA,
> >> I'll
> >> > do the release.
> >> >
> >> > On Fri, Jan 2, 2015 at 10:37 AM, Robert Metzger <rm...@apache.org>
> >> wrote:
> >> >
> >> >> Thanks for the update.
> >> >>
> >> >> Happy new year to everyone.
> >> >>
> >> >> It seems that we have to wait for INFRA to finish the LDAP group
> >> creation
> >> >> for the new TLP first, since this is connected to the maven
> repository.
> >> >> If nothing happened until Monday, I'll ask infra on their IRC chat if
> >> they
> >> >> can resolve the LDAP group creation.
> >> >>
> >> >>
> >> >> Robert
> >> >>
> >> >>
> >> >>
> >> >> On Fri, Jan 2, 2015 at 9:45 AM, Márton Balassi <
> >> balassi.marton@gmail.com>
> >> >> wrote:
> >> >>
> >> >>> Happy new year Flinkers,
> >> >>>
> >> >>> I'm sorry that I could not report any progress on the release yet.
> It
> >> was
> >> >>> finally clarified that we are actually blocked by the apache
> >> >>> infrastructure
> >> >>> at the moment. [1]
> >> >>>
> >> >>> [1] https://issues.apache.org/jira/browse/INFRA-8954
> >> >>>
> >> >>> Marton
> >> >>>
> >> >>> On Fri, Dec 19, 2014 at 11:00 PM, Henry Saputra <
> >> henry.saputra@gmail.com>
> >> >>> wrote:
> >> >>>
> >> >>> > Thanks for the update Marton.
> >> >>> >
> >> >>> > So with we are graduating it is coming as blessing but
> unfortunately
> >> >>> > adding more work to the release process.
> >> >>> >
> >> >>> > Please do let us know if you need any help with the release.
> >> >>> >
> >> >>> > - Henry
> >> >>> >
> >> >>> > On Fri, Dec 19, 2014 at 12:38 PM, Márton Balassi
> >> >>> > <ba...@gmail.com> wrote:
> >> >>> > > +1 on quickstart, I'm having a look at it tomorrow.
> >> >>> > >
> >> >>> > > Robert also pointed out the the DISCLAIMER file (for incubation,
> >> >>> > currently
> >> >>> > > also added to the distribution) is no longer needed neither on
> the
> >> >>> master
> >> >>> > > nor on the release branch. Other minor things in the repo
> regarding
> >> >>> the
> >> >>> > > graduation:
> >> >>> > >
> >> >>> > > * Eliminating the incubating subscript from the project
> version
> >> >>> > > * Updating the the docs (mostly mentioned in variables,
> >> sometimes in
> >> >>> > > since given version that should not be changed)
> >> >>> > > * Updating the quickstart scripts (more related to simply
> >> releasing)
> >> >>> > >
> >> >>> > > I'm deleting the DISCLAIMER from the repo and the assemblies,
> >> bumping
> >> >>> the
> >> >>> > > version and updating the parts of the docs that can be done
> prior
> >> to
> >> >>> the
> >> >>> > > release.
> >> >>> > >
> >> >>> > > As for the state of the relese: With the help of Robert I have
> >> >>> acquired
> >> >>> > the
> >> >>> > > necessary knowledge and set up the tools needed for the
> release. I
> >> >>> have
> >> >>> > > still minor issues with maven, but I'm confident that the
> solution
> >> is
> >> >>> > near.
> >> >>> > > I also fell motivated to write down my experiences in a
> >> documentation
> >> >>> to
> >> >>> > > spare some time for up and coming release managers.
> >> >>> > >
> >> >>> > > Best,
> >> >>> > >
> >> >>> > > Marton
> >> >>> > >
> >> >>> > > On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <
> >> >>> aljoscha@apache.org>
> >> >>> > > wrote:
> >> >>> > >>
> >> >>> > >> +1
> >> >>> > >>
> >> >>> > >> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <
> >> rmetzger@apache.org
> >> >>> >
> >> >>> > >> wrote:
> >> >>> > >> > Hi guys,
> >> >>> > >> >
> >> >>> > >> > I vote to make this issue a release blocker:
> >> >>> > >> > https://issues.apache.org/jira/browse/FLINK-1225
> >> >>> > >> > Two users ran into the issue within 2 days. The quickstart is
> >> mean
> >> >>> to
> >> >>> > >> give
> >> >>> > >> > new users a good experience.
> >> >>> > >> >
> >> >>> > >> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <
> >> sewen@apache.org>
> >> >>> > wrote:
> >> >>> > >> >>
> >> >>> > >> >> Hi!
> >> >>> > >> >>
> >> >>> > >> >> I forked a branch "release-0.8" and bumped the master
> version
> >> to
> >> >>> > >> >> "0.9-incubating-SNAPSHOT".
> >> >>> > >> >>
> >> >>> > >> >> The closure cleaner is merged. Robert has opened a PR for
> Kryo
> >> - I
> >> >>> > would
> >> >>> > >> >> suggest to merge that to "master", cherry-pick to
> "release-0.8"
> >> >>> and
> >> >>> > >> then:
> >> >>> > >> >> Merry releasing!
> >> >>> > >> >>
> >> >>> > >> >> Greetings,
> >> >>> > >> >> Stephan
> >> >>> > >> >>
> >> >>> > >> >>
> >> >>> > >> >>
> >> >>> > >> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
> >> >>> > >> balassi.marton@gmail.com>
> >> >>> > >> >> wrote:
> >> >>> > >> >> >
> >> >>> > >> >> > @Timo&Stephan: The streaming code uses this since last
> week
> >> [1],
> >> >>> > Timo
> >> >>> > >> >> > starting working on the issue prior way before that - so
> it
> >> also
> >> >>> > has
> >> >>> > >> to
> >> >>> > >> >> do
> >> >>> > >> >> > with the streaming team pushing last minute features to be
> >> >>> > honest...
> >> >>> > >> >> >
> >> >>> > >> >> > Then are we waiting for the Java Clousure cleaner and the
> >> Kyro
> >> >>> > >> support, I
> >> >>> > >> >> > guess.
> >> >>> > >> >> > Aljoscha has already issued a PR for the former, some
> >> additional
> >> >>> > >> testing
> >> >>> > >> >> is
> >> >>> > >> >> > needed from the looks of it. [2]
> >> >>> > >> >> >
> >> >>> > >> >> > [1]
> >> >>> > >> >> >
> >> >>> > >> >> >
> >> >>> > >> >>
> >> >>> > >>
> >> >>> >
> >> >>>
> >>
> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
> >> >>> > >> >> > [2] https://github.com/apache/incubator-flink/pull/269
> >> >>> > >> >> >
> >> >>> > >> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <
> >> >>> flink@twalthr.com>
> >> >>> > >> wrote:
> >> >>> > >> >> > >
> >> >>> > >> >> > > Yes, I also think so. Stability is more important.
> >> >>> > >> >> > >
> >> >>> > >> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <
> >> >>> sewen@apache.org
> >> >>> > >:
> >> >>> > >> >> > > >
> >> >>> > >> >> > > > Yes, the fact that we both did not realize that until
> now
> >> >>> sort
> >> >>> > of
> >> >>> > >> >> > reveals
> >> >>> > >> >> > > > that there are more implications than anticipated.
> That
> >> is
> >> >>> > never
> >> >>> > >> good
> >> >>> > >> >> > for
> >> >>> > >> >> > > > "last minute" patches.
> >> >>> > >> >> > > >
> >> >>> > >> >> > > > That's why I would like to merge it into 0.8.1 and
> 0.9,
> >> >>> rather
> >> >>> > >> than
> >> >>> > >> >> > 0.8.0
> >> >>> > >> >> > > > That gives the code a bit more testing/use and us a
> bit
> >> more
> >> >>> > time
> >> >>> > >> to
> >> >>> > >> >> > > > thoroughly think the implications through.
> >> >>> > >> >> > > >
> >> >>> > >> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <
> >> >>> > flink@twalthr.com
> >> >>> > >> >
> >> >>> > >> >> > > wrote:
> >> >>> > >> >> > > >>
> >> >>> > >> >> > > >> Sorry I totally forgot to check the streaming API. Do
> >> they
> >> >>> use
> >> >>> > >> the
> >> >>> > >> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
> >> >>> > >> >> > > >>
> >> >>> > >> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
> >> >>> > >> rmetzger@apache.org
> >> >>> > >> >> >:
> >> >>> > >> >> > > >>>
> >> >>> > >> >> > > >>> I've worked on adding Kryo support to Flink today. I
> >> would
> >> >>> > >> really
> >> >>> > >> >> > like
> >> >>> > >> >> > > to
> >> >>> > >> >> > > >>> include this into the release. Many users were
> >> complaining
> >> >>> > about
> >> >>> > >> >> > this (
> >> >>> > >> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
> >> >>> > >> >> > > >>>
> >> >>> > >> >> > > >>> I've based my work on top of Timo's pull request. If
> >> we're
> >> >>> > not
> >> >>> > >> >> going
> >> >>> > >> >> > to
> >> >>> > >> >> > > >>> merge it, I will have to rebase my code to the
> current
> >> >>> > master.
> >> >>> > >> ...
> >> >>> > >> >> > I'll
> >> >>> > >> >> > > >> try
> >> >>> > >> >> > > >>> and see if its easily doable.
> >> >>> > >> >> > > >>>
> >> >>> > >> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
> >> >>> > >> sewen@apache.org>
> >> >>> > >> >> > > wrote:
> >> >>> > >> >> > > >>>>
> >> >>> > >> >> > > >>>> Yes, one thing I just realized is that the
> streaming
> >> API
> >> >>> is
> >> >>> > not
> >> >>> > >> >> > aware
> >> >>> > >> >> > > of
> >> >>> > >> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
> >> >>> > >> >> > > >>>>
> >> >>> > >> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
> >> >>> > >> >> fhueske@gmail.com>
> >> >>> > >> >> > > >> wrote:
> >> >>> > >> >> > > >>>>>
> >> >>> > >> >> > > >>>>> +1 for stability first
> >> >>> > >> >> > > >>>>>
> >> >>> > >> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <
> >> >>> sewen@apache.org
> >> >>> > >:
> >> >>> > >> >> > > >>>>>>
> >> >>> > >> >> > > >>>>>> I am currently working through the type hints
> pull
> >> >>> > request...
> >> >>> > >> >> > > >>>>>>
> >> >>> > >> >> > > >>>>>> Right now, I actually think that we should
> postpone
> >> >>> this
> >> >>> > for
> >> >>> > >> the
> >> >>> > >> >> > > next
> >> >>> > >> >> > > >>>>>> bugfix release.
> >> >>> > >> >> > > >>>>>>
> >> >>> > >> >> > > >>>>>> This pull request changes actually some tricky
> >> >>> mechanisms
> >> >>> > in
> >> >>> > >> the
> >> >>> > >> >> > > Java
> >> >>> > >> >> > > >>>> API
> >> >>> > >> >> > > >>>>>> (it delays the type information), which may have
> >> >>> > implications
> >> >>> > >> >> that
> >> >>> > >> >> > > me
> >> >>> > >> >> > > >>>> and
> >> >>> > >> >> > > >>>>>> Timo have not fully caught now.
> >> >>> > >> >> > > >>>>>>
> >> >>> > >> >> > > >>>>>> I don't feel Merging this last minute - this is
> >> prone
> >> >>> to
> >> >>> > >> >> introduce
> >> >>> > >> >> > > >>>>> errors.
> >> >>> > >> >> > > >>>>>>
> >> >>> > >> >> > > >>>>>> Any opinions on that?
> >> >>> > >> >> > > >>>>>>
> >> >>> > >> >> > > >>>>>>
> >> >>> > >> >> > > >>>>>>
> >> >>> > >> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
> >> >>> > >> sewen@apache.org
> >> >>> > >> >> >
> >> >>> > >> >> > > >>>> wrote:
> >> >>> > >> >> > > >>>>>>>
> >> >>> > >> >> > > >>>>>>> +1 for adding the closure cleaner...
> >> >>> > >> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
> >> >>> > >> >> > > aljoscha@apache.org
> >> >>> > >> >> > > >>>>> :
> >> >>> > >> >> > > >>>>>>>
> >> >>> > >> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as
> well?
> >> >>> > >> >> > > >>>>>>>>
> >> >>> > >> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton
> Balassi
> >> >>> > >> >> > > >>>>>>>> <ba...@gmail.com> wrote:
> >> >>> > >> >> > > >>>>>>>>> Cool, thanks.
> >> >>> > >> >> > > >>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan
> Ewen <
> >> >>> > >> >> > sewen@apache.org
> >> >>> > >> >> > > >
> >> >>> > >> >> > > >>>>>>>> wrote:
> >> >>> > >> >> > > >>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>> Hi!
> >> >>> > >> >> > > >>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made
> some
> >> >>> final
> >> >>> > >> >> > adjustments
> >> >>> > >> >> > > >>>>>>>> yesterday
> >> >>> > >> >> > > >>>>>>>>>> evening. I'll review and merge it now, then
> we
> >> can
> >> >>> > fork
> >> >>> > >> the
> >> >>> > >> >> > > >>>> branch.
> >> >>> > >> >> > > >>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>> Cheers,
> >> >>> > >> >> > > >>>>>>>>>> Stephan
> >> >>> > >> >> > > >>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton
> >> Balassi <
> >> >>> > >> >> > > >>>>>>>> balassi.marton@gmail.com
> >> >>> > >> >> > > >>>>>>>>>> wrote:
> >> >>> > >> >> > > >>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>> Hey,
> >> >>> > >> >> > > >>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems
> >> every
> >> >>> > import
> >> >>> > >> >> one
> >> >>> > >> >> > > >>>> has
> >> >>> > >> >> > > >>>>>> been
> >> >>> > >> >> > > >>>>>>>>>>> merged. As for the optional ones the
> following
> >> two
> >> >>> > are
> >> >>> > >> >> still
> >> >>> > >> >> > > >>>>>> pending:
> >> >>> > >> >> > > >>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces,
> >> Abstract
> >> >>> > >> Classes as
> >> >>> > >> >> > > >>>> POJOs
> >> >>> > >> >> > > >>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java
> API
> >> >>> > operators
> >> >>> > >> >> > > >>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has
> just
> >> >>> > updated
> >> >>> > >> it.
> >> >>> > >> >> > > >>>> Should
> >> >>> > >> >> > > >>>>>> we
> >> >>> > >> >> > > >>>>>>>> wait
> >> >>> > >> >> > > >>>>>>>>>>> for it?
> >> >>> > >> >> > > >>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>> Cheers,
> >> >>> > >> >> > > >>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>> Marton
> >> >>> > >> >> > > >>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk
> Celebi <
> >> >>> > >> >> uce@apache.org
> >> >>> > >> >> > >
> >> >>> > >> >> > > >>>>>> wrote:
> >> >>> > >> >> > > >>>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan
> Ewen
> >> <
> >> >>> > >> >> > > >>>>> sewen@apache.org>
> >> >>> > >> >> > > >>>>>>>>>> wrote:
> >> >>> > >> >> > > >>>>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>>>
> >> ----------------------------------------------
> >> >>> > >> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
> >> >>> > >> >> > > >>>>>>>>>>>>>
> >> ----------------------------------------------
> >> >>> > >> >> > > >>>>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner
> prefers
> >> >>> > splits
> >> >>> > >> with
> >> >>> > >> >> > > >>>>> less
> >> >>> > >> >> > > >>>>>>>>>> degrees
> >> >>> > >> >> > > >>>>>>>>>>> of
> >> >>> > >> >> > > >>>>>>>>>>>>> freedom
> >> >>> > >> >> > > >>>>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for
> >> >>> > HadoopInputWrapper
> >> >>> > >> and
> >> >>> > >> >> > > >>>>>>>>>> NullWritable
> >> >>> > >> >> > > >>>>>>>>>>>>> support
> >> >>> > >> >> > > >>>>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and
> new
> >> >>> Tuple
> >> >>> > >> APIs +
> >> >>> > >> >> > > >>>> fix
> >> >>> > >> >> > > >>>>>> of
> >> >>> > >> >> > > >>>>>>>>>>>>> ExecutionEnvironment
> >> >>> > >> >> > > >>>>>>>>>>>>> (this is partially merged, there are a few
> >> POM
> >> >>> > entries
> >> >>> > >> >> > > >>>>> missing
> >> >>> > >> >> > > >>>>>>>> for
> >> >>> > >> >> > > >>>>>>>>>>>> Hadoop 1
> >> >>> > >> >> > > >>>>>>>>>>>>> support)
> >> >>> > >> >> > > >>>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>> The first two PRs are still open. I will
> have
> >> a
> >> >>> > look at
> >> >>> > >> >> them
> >> >>> > >> >> > > >>>> as
> >> >>> > >> >> > > >>>>>>>> well
> >> >>> > >> >> > > >>>>>>>>>>>> (Robert already tested one).
> >> >>> > >> >> > > >>>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>> @Robert:
> >> >>> > >> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by
> >> 1b69749
> >> >>> > >> ("Enable
> >> >>> > >> >> > > >>>>>>>> flink-hbase
> >> >>> > >> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
> >> >>> > >> >> > > >>>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>>
> >> >>> > >> >> > > >>>>>>>>>>>> It would be nice if had a look at the
> >> remaining
> >> >>> > >> important
> >> >>> > >> >> > > >>>> ones
> >> >>> > >> >> > > >>>>>>>> today.
> >> >>> > >> >> > > >>>>>>>>>> :-)
> >> >>> > >> >> > > >>
> >> >>> > >> >> > >
> >> >>> > >> >> >
> >> >>> > >> >>
> >> >>> > >>
> >> >>> >
> >> >>>
> >> >>
> >> >>
> >>
>
Re: Forking off the 0.8 release branch.
Posted by Henry Saputra <he...@gmail.com>.
Hi Márton,
Yes, we could and should move to non-incubating repo. I think Robert
and Stephan are working with Infra to make it happen.
My question is more should we wait till migration happen or should we
publish non-incubating release artifact to ASF diet and mvn central
from our incubating source repository instead.
- Henry
On Mon, Jan 5, 2015 at 2:37 PM, Márton Balassi <ba...@gmail.com> wrote:
> I assume that infra graduation means that we can move to the non-incubating
> repo as well.
>
> Also to the best of my knowledge the release is not connected to the
> incubating repo itself. Of course it can be listed on github as well, but
> what makes an apache release is that it can be downloaded from the apache
> distribution mirrors (where it is signed correctly) and from maven central
> (provided by the apache repository infrastructure). But please correct me
> if I'm wrong.
>
> On Mon, Jan 5, 2015 at 11:20 PM, Henry Saputra <he...@gmail.com>
> wrote:
>
>> When you said "finish the release" meaning distribute/publish a TLP
>> release in the incubating branch repo?
>>
>> - Henry
>>
>> On Mon, Jan 5, 2015 at 6:38 AM, Robert Metzger <rm...@apache.org>
>> wrote:
>> > Allright .. I've asked infra and they plan to do the graduation this week
>> > ("hopefully today/tomorrow").
>> > If that is really going to happen in the next days, I would suggest to
>> let
>> > Marton finish the release. If there are any major delays due to INFRA,
>> I'll
>> > do the release.
>> >
>> > On Fri, Jan 2, 2015 at 10:37 AM, Robert Metzger <rm...@apache.org>
>> wrote:
>> >
>> >> Thanks for the update.
>> >>
>> >> Happy new year to everyone.
>> >>
>> >> It seems that we have to wait for INFRA to finish the LDAP group
>> creation
>> >> for the new TLP first, since this is connected to the maven repository.
>> >> If nothing happened until Monday, I'll ask infra on their IRC chat if
>> they
>> >> can resolve the LDAP group creation.
>> >>
>> >>
>> >> Robert
>> >>
>> >>
>> >>
>> >> On Fri, Jan 2, 2015 at 9:45 AM, Márton Balassi <
>> balassi.marton@gmail.com>
>> >> wrote:
>> >>
>> >>> Happy new year Flinkers,
>> >>>
>> >>> I'm sorry that I could not report any progress on the release yet. It
>> was
>> >>> finally clarified that we are actually blocked by the apache
>> >>> infrastructure
>> >>> at the moment. [1]
>> >>>
>> >>> [1] https://issues.apache.org/jira/browse/INFRA-8954
>> >>>
>> >>> Marton
>> >>>
>> >>> On Fri, Dec 19, 2014 at 11:00 PM, Henry Saputra <
>> henry.saputra@gmail.com>
>> >>> wrote:
>> >>>
>> >>> > Thanks for the update Marton.
>> >>> >
>> >>> > So with we are graduating it is coming as blessing but unfortunately
>> >>> > adding more work to the release process.
>> >>> >
>> >>> > Please do let us know if you need any help with the release.
>> >>> >
>> >>> > - Henry
>> >>> >
>> >>> > On Fri, Dec 19, 2014 at 12:38 PM, Márton Balassi
>> >>> > <ba...@gmail.com> wrote:
>> >>> > > +1 on quickstart, I'm having a look at it tomorrow.
>> >>> > >
>> >>> > > Robert also pointed out the the DISCLAIMER file (for incubation,
>> >>> > currently
>> >>> > > also added to the distribution) is no longer needed neither on the
>> >>> master
>> >>> > > nor on the release branch. Other minor things in the repo regarding
>> >>> the
>> >>> > > graduation:
>> >>> > >
>> >>> > > * Eliminating the incubating subscript from the project version
>> >>> > > * Updating the the docs (mostly mentioned in variables,
>> sometimes in
>> >>> > > since given version that should not be changed)
>> >>> > > * Updating the quickstart scripts (more related to simply
>> releasing)
>> >>> > >
>> >>> > > I'm deleting the DISCLAIMER from the repo and the assemblies,
>> bumping
>> >>> the
>> >>> > > version and updating the parts of the docs that can be done prior
>> to
>> >>> the
>> >>> > > release.
>> >>> > >
>> >>> > > As for the state of the relese: With the help of Robert I have
>> >>> acquired
>> >>> > the
>> >>> > > necessary knowledge and set up the tools needed for the release. I
>> >>> have
>> >>> > > still minor issues with maven, but I'm confident that the solution
>> is
>> >>> > near.
>> >>> > > I also fell motivated to write down my experiences in a
>> documentation
>> >>> to
>> >>> > > spare some time for up and coming release managers.
>> >>> > >
>> >>> > > Best,
>> >>> > >
>> >>> > > Marton
>> >>> > >
>> >>> > > On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <
>> >>> aljoscha@apache.org>
>> >>> > > wrote:
>> >>> > >>
>> >>> > >> +1
>> >>> > >>
>> >>> > >> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <
>> rmetzger@apache.org
>> >>> >
>> >>> > >> wrote:
>> >>> > >> > Hi guys,
>> >>> > >> >
>> >>> > >> > I vote to make this issue a release blocker:
>> >>> > >> > https://issues.apache.org/jira/browse/FLINK-1225
>> >>> > >> > Two users ran into the issue within 2 days. The quickstart is
>> mean
>> >>> to
>> >>> > >> give
>> >>> > >> > new users a good experience.
>> >>> > >> >
>> >>> > >> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <
>> sewen@apache.org>
>> >>> > wrote:
>> >>> > >> >>
>> >>> > >> >> Hi!
>> >>> > >> >>
>> >>> > >> >> I forked a branch "release-0.8" and bumped the master version
>> to
>> >>> > >> >> "0.9-incubating-SNAPSHOT".
>> >>> > >> >>
>> >>> > >> >> The closure cleaner is merged. Robert has opened a PR for Kryo
>> - I
>> >>> > would
>> >>> > >> >> suggest to merge that to "master", cherry-pick to "release-0.8"
>> >>> and
>> >>> > >> then:
>> >>> > >> >> Merry releasing!
>> >>> > >> >>
>> >>> > >> >> Greetings,
>> >>> > >> >> Stephan
>> >>> > >> >>
>> >>> > >> >>
>> >>> > >> >>
>> >>> > >> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
>> >>> > >> balassi.marton@gmail.com>
>> >>> > >> >> wrote:
>> >>> > >> >> >
>> >>> > >> >> > @Timo&Stephan: The streaming code uses this since last week
>> [1],
>> >>> > Timo
>> >>> > >> >> > starting working on the issue prior way before that - so it
>> also
>> >>> > has
>> >>> > >> to
>> >>> > >> >> do
>> >>> > >> >> > with the streaming team pushing last minute features to be
>> >>> > honest...
>> >>> > >> >> >
>> >>> > >> >> > Then are we waiting for the Java Clousure cleaner and the
>> Kyro
>> >>> > >> support, I
>> >>> > >> >> > guess.
>> >>> > >> >> > Aljoscha has already issued a PR for the former, some
>> additional
>> >>> > >> testing
>> >>> > >> >> is
>> >>> > >> >> > needed from the looks of it. [2]
>> >>> > >> >> >
>> >>> > >> >> > [1]
>> >>> > >> >> >
>> >>> > >> >> >
>> >>> > >> >>
>> >>> > >>
>> >>> >
>> >>>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
>> >>> > >> >> > [2] https://github.com/apache/incubator-flink/pull/269
>> >>> > >> >> >
>> >>> > >> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <
>> >>> flink@twalthr.com>
>> >>> > >> wrote:
>> >>> > >> >> > >
>> >>> > >> >> > > Yes, I also think so. Stability is more important.
>> >>> > >> >> > >
>> >>> > >> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <
>> >>> sewen@apache.org
>> >>> > >:
>> >>> > >> >> > > >
>> >>> > >> >> > > > Yes, the fact that we both did not realize that until now
>> >>> sort
>> >>> > of
>> >>> > >> >> > reveals
>> >>> > >> >> > > > that there are more implications than anticipated. That
>> is
>> >>> > never
>> >>> > >> good
>> >>> > >> >> > for
>> >>> > >> >> > > > "last minute" patches.
>> >>> > >> >> > > >
>> >>> > >> >> > > > That's why I would like to merge it into 0.8.1 and 0.9,
>> >>> rather
>> >>> > >> than
>> >>> > >> >> > 0.8.0
>> >>> > >> >> > > > That gives the code a bit more testing/use and us a bit
>> more
>> >>> > time
>> >>> > >> to
>> >>> > >> >> > > > thoroughly think the implications through.
>> >>> > >> >> > > >
>> >>> > >> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <
>> >>> > flink@twalthr.com
>> >>> > >> >
>> >>> > >> >> > > wrote:
>> >>> > >> >> > > >>
>> >>> > >> >> > > >> Sorry I totally forgot to check the streaming API. Do
>> they
>> >>> use
>> >>> > >> the
>> >>> > >> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
>> >>> > >> >> > > >>
>> >>> > >> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
>> >>> > >> rmetzger@apache.org
>> >>> > >> >> >:
>> >>> > >> >> > > >>>
>> >>> > >> >> > > >>> I've worked on adding Kryo support to Flink today. I
>> would
>> >>> > >> really
>> >>> > >> >> > like
>> >>> > >> >> > > to
>> >>> > >> >> > > >>> include this into the release. Many users were
>> complaining
>> >>> > about
>> >>> > >> >> > this (
>> >>> > >> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
>> >>> > >> >> > > >>>
>> >>> > >> >> > > >>> I've based my work on top of Timo's pull request. If
>> we're
>> >>> > not
>> >>> > >> >> going
>> >>> > >> >> > to
>> >>> > >> >> > > >>> merge it, I will have to rebase my code to the current
>> >>> > master.
>> >>> > >> ...
>> >>> > >> >> > I'll
>> >>> > >> >> > > >> try
>> >>> > >> >> > > >>> and see if its easily doable.
>> >>> > >> >> > > >>>
>> >>> > >> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
>> >>> > >> sewen@apache.org>
>> >>> > >> >> > > wrote:
>> >>> > >> >> > > >>>>
>> >>> > >> >> > > >>>> Yes, one thing I just realized is that the streaming
>> API
>> >>> is
>> >>> > not
>> >>> > >> >> > aware
>> >>> > >> >> > > of
>> >>> > >> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
>> >>> > >> >> > > >>>>
>> >>> > >> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
>> >>> > >> >> fhueske@gmail.com>
>> >>> > >> >> > > >> wrote:
>> >>> > >> >> > > >>>>>
>> >>> > >> >> > > >>>>> +1 for stability first
>> >>> > >> >> > > >>>>>
>> >>> > >> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <
>> >>> sewen@apache.org
>> >>> > >:
>> >>> > >> >> > > >>>>>>
>> >>> > >> >> > > >>>>>> I am currently working through the type hints pull
>> >>> > request...
>> >>> > >> >> > > >>>>>>
>> >>> > >> >> > > >>>>>> Right now, I actually think that we should postpone
>> >>> this
>> >>> > for
>> >>> > >> the
>> >>> > >> >> > > next
>> >>> > >> >> > > >>>>>> bugfix release.
>> >>> > >> >> > > >>>>>>
>> >>> > >> >> > > >>>>>> This pull request changes actually some tricky
>> >>> mechanisms
>> >>> > in
>> >>> > >> the
>> >>> > >> >> > > Java
>> >>> > >> >> > > >>>> API
>> >>> > >> >> > > >>>>>> (it delays the type information), which may have
>> >>> > implications
>> >>> > >> >> that
>> >>> > >> >> > > me
>> >>> > >> >> > > >>>> and
>> >>> > >> >> > > >>>>>> Timo have not fully caught now.
>> >>> > >> >> > > >>>>>>
>> >>> > >> >> > > >>>>>> I don't feel Merging this last minute - this is
>> prone
>> >>> to
>> >>> > >> >> introduce
>> >>> > >> >> > > >>>>> errors.
>> >>> > >> >> > > >>>>>>
>> >>> > >> >> > > >>>>>> Any opinions on that?
>> >>> > >> >> > > >>>>>>
>> >>> > >> >> > > >>>>>>
>> >>> > >> >> > > >>>>>>
>> >>> > >> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
>> >>> > >> sewen@apache.org
>> >>> > >> >> >
>> >>> > >> >> > > >>>> wrote:
>> >>> > >> >> > > >>>>>>>
>> >>> > >> >> > > >>>>>>> +1 for adding the closure cleaner...
>> >>> > >> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
>> >>> > >> >> > > aljoscha@apache.org
>> >>> > >> >> > > >>>>> :
>> >>> > >> >> > > >>>>>>>
>> >>> > >> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
>> >>> > >> >> > > >>>>>>>>
>> >>> > >> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
>> >>> > >> >> > > >>>>>>>> <ba...@gmail.com> wrote:
>> >>> > >> >> > > >>>>>>>>> Cool, thanks.
>> >>> > >> >> > > >>>>>>>>>
>> >>> > >> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
>> >>> > >> >> > sewen@apache.org
>> >>> > >> >> > > >
>> >>> > >> >> > > >>>>>>>> wrote:
>> >>> > >> >> > > >>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>> Hi!
>> >>> > >> >> > > >>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made some
>> >>> final
>> >>> > >> >> > adjustments
>> >>> > >> >> > > >>>>>>>> yesterday
>> >>> > >> >> > > >>>>>>>>>> evening. I'll review and merge it now, then we
>> can
>> >>> > fork
>> >>> > >> the
>> >>> > >> >> > > >>>> branch.
>> >>> > >> >> > > >>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>> Cheers,
>> >>> > >> >> > > >>>>>>>>>> Stephan
>> >>> > >> >> > > >>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton
>> Balassi <
>> >>> > >> >> > > >>>>>>>> balassi.marton@gmail.com
>> >>> > >> >> > > >>>>>>>>>> wrote:
>> >>> > >> >> > > >>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>> Hey,
>> >>> > >> >> > > >>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems
>> every
>> >>> > import
>> >>> > >> >> one
>> >>> > >> >> > > >>>> has
>> >>> > >> >> > > >>>>>> been
>> >>> > >> >> > > >>>>>>>>>>> merged. As for the optional ones the following
>> two
>> >>> > are
>> >>> > >> >> still
>> >>> > >> >> > > >>>>>> pending:
>> >>> > >> >> > > >>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces,
>> Abstract
>> >>> > >> Classes as
>> >>> > >> >> > > >>>> POJOs
>> >>> > >> >> > > >>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API
>> >>> > operators
>> >>> > >> >> > > >>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just
>> >>> > updated
>> >>> > >> it.
>> >>> > >> >> > > >>>> Should
>> >>> > >> >> > > >>>>>> we
>> >>> > >> >> > > >>>>>>>> wait
>> >>> > >> >> > > >>>>>>>>>>> for it?
>> >>> > >> >> > > >>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>> Cheers,
>> >>> > >> >> > > >>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>> Marton
>> >>> > >> >> > > >>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <
>> >>> > >> >> uce@apache.org
>> >>> > >> >> > >
>> >>> > >> >> > > >>>>>> wrote:
>> >>> > >> >> > > >>>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen
>> <
>> >>> > >> >> > > >>>>> sewen@apache.org>
>> >>> > >> >> > > >>>>>>>>>> wrote:
>> >>> > >> >> > > >>>>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>>>
>> ----------------------------------------------
>> >>> > >> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
>> >>> > >> >> > > >>>>>>>>>>>>>
>> ----------------------------------------------
>> >>> > >> >> > > >>>>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers
>> >>> > splits
>> >>> > >> with
>> >>> > >> >> > > >>>>> less
>> >>> > >> >> > > >>>>>>>>>> degrees
>> >>> > >> >> > > >>>>>>>>>>> of
>> >>> > >> >> > > >>>>>>>>>>>>> freedom
>> >>> > >> >> > > >>>>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for
>> >>> > HadoopInputWrapper
>> >>> > >> and
>> >>> > >> >> > > >>>>>>>>>> NullWritable
>> >>> > >> >> > > >>>>>>>>>>>>> support
>> >>> > >> >> > > >>>>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new
>> >>> Tuple
>> >>> > >> APIs +
>> >>> > >> >> > > >>>> fix
>> >>> > >> >> > > >>>>>> of
>> >>> > >> >> > > >>>>>>>>>>>>> ExecutionEnvironment
>> >>> > >> >> > > >>>>>>>>>>>>> (this is partially merged, there are a few
>> POM
>> >>> > entries
>> >>> > >> >> > > >>>>> missing
>> >>> > >> >> > > >>>>>>>> for
>> >>> > >> >> > > >>>>>>>>>>>> Hadoop 1
>> >>> > >> >> > > >>>>>>>>>>>>> support)
>> >>> > >> >> > > >>>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>> The first two PRs are still open. I will have
>> a
>> >>> > look at
>> >>> > >> >> them
>> >>> > >> >> > > >>>> as
>> >>> > >> >> > > >>>>>>>> well
>> >>> > >> >> > > >>>>>>>>>>>> (Robert already tested one).
>> >>> > >> >> > > >>>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>> @Robert:
>> >>> > >> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by
>> 1b69749
>> >>> > >> ("Enable
>> >>> > >> >> > > >>>>>>>> flink-hbase
>> >>> > >> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
>> >>> > >> >> > > >>>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>>
>> >>> > >> >> > > >>>>>>>>>>>> It would be nice if had a look at the
>> remaining
>> >>> > >> important
>> >>> > >> >> > > >>>> ones
>> >>> > >> >> > > >>>>>>>> today.
>> >>> > >> >> > > >>>>>>>>>> :-)
>> >>> > >> >> > > >>
>> >>> > >> >> > >
>> >>> > >> >> >
>> >>> > >> >>
>> >>> > >>
>> >>> >
>> >>>
>> >>
>> >>
>>
Re: Forking off the 0.8 release branch.
Posted by Márton Balassi <ba...@gmail.com>.
I assume that infra graduation means that we can move to the non-incubating
repo as well.
Also to the best of my knowledge the release is not connected to the
incubating repo itself. Of course it can be listed on github as well, but
what makes an apache release is that it can be downloaded from the apache
distribution mirrors (where it is signed correctly) and from maven central
(provided by the apache repository infrastructure). But please correct me
if I'm wrong.
On Mon, Jan 5, 2015 at 11:20 PM, Henry Saputra <he...@gmail.com>
wrote:
> When you said "finish the release" meaning distribute/publish a TLP
> release in the incubating branch repo?
>
> - Henry
>
> On Mon, Jan 5, 2015 at 6:38 AM, Robert Metzger <rm...@apache.org>
> wrote:
> > Allright .. I've asked infra and they plan to do the graduation this week
> > ("hopefully today/tomorrow").
> > If that is really going to happen in the next days, I would suggest to
> let
> > Marton finish the release. If there are any major delays due to INFRA,
> I'll
> > do the release.
> >
> > On Fri, Jan 2, 2015 at 10:37 AM, Robert Metzger <rm...@apache.org>
> wrote:
> >
> >> Thanks for the update.
> >>
> >> Happy new year to everyone.
> >>
> >> It seems that we have to wait for INFRA to finish the LDAP group
> creation
> >> for the new TLP first, since this is connected to the maven repository.
> >> If nothing happened until Monday, I'll ask infra on their IRC chat if
> they
> >> can resolve the LDAP group creation.
> >>
> >>
> >> Robert
> >>
> >>
> >>
> >> On Fri, Jan 2, 2015 at 9:45 AM, Márton Balassi <
> balassi.marton@gmail.com>
> >> wrote:
> >>
> >>> Happy new year Flinkers,
> >>>
> >>> I'm sorry that I could not report any progress on the release yet. It
> was
> >>> finally clarified that we are actually blocked by the apache
> >>> infrastructure
> >>> at the moment. [1]
> >>>
> >>> [1] https://issues.apache.org/jira/browse/INFRA-8954
> >>>
> >>> Marton
> >>>
> >>> On Fri, Dec 19, 2014 at 11:00 PM, Henry Saputra <
> henry.saputra@gmail.com>
> >>> wrote:
> >>>
> >>> > Thanks for the update Marton.
> >>> >
> >>> > So with we are graduating it is coming as blessing but unfortunately
> >>> > adding more work to the release process.
> >>> >
> >>> > Please do let us know if you need any help with the release.
> >>> >
> >>> > - Henry
> >>> >
> >>> > On Fri, Dec 19, 2014 at 12:38 PM, Márton Balassi
> >>> > <ba...@gmail.com> wrote:
> >>> > > +1 on quickstart, I'm having a look at it tomorrow.
> >>> > >
> >>> > > Robert also pointed out the the DISCLAIMER file (for incubation,
> >>> > currently
> >>> > > also added to the distribution) is no longer needed neither on the
> >>> master
> >>> > > nor on the release branch. Other minor things in the repo regarding
> >>> the
> >>> > > graduation:
> >>> > >
> >>> > > * Eliminating the incubating subscript from the project version
> >>> > > * Updating the the docs (mostly mentioned in variables,
> sometimes in
> >>> > > since given version that should not be changed)
> >>> > > * Updating the quickstart scripts (more related to simply
> releasing)
> >>> > >
> >>> > > I'm deleting the DISCLAIMER from the repo and the assemblies,
> bumping
> >>> the
> >>> > > version and updating the parts of the docs that can be done prior
> to
> >>> the
> >>> > > release.
> >>> > >
> >>> > > As for the state of the relese: With the help of Robert I have
> >>> acquired
> >>> > the
> >>> > > necessary knowledge and set up the tools needed for the release. I
> >>> have
> >>> > > still minor issues with maven, but I'm confident that the solution
> is
> >>> > near.
> >>> > > I also fell motivated to write down my experiences in a
> documentation
> >>> to
> >>> > > spare some time for up and coming release managers.
> >>> > >
> >>> > > Best,
> >>> > >
> >>> > > Marton
> >>> > >
> >>> > > On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <
> >>> aljoscha@apache.org>
> >>> > > wrote:
> >>> > >>
> >>> > >> +1
> >>> > >>
> >>> > >> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <
> rmetzger@apache.org
> >>> >
> >>> > >> wrote:
> >>> > >> > Hi guys,
> >>> > >> >
> >>> > >> > I vote to make this issue a release blocker:
> >>> > >> > https://issues.apache.org/jira/browse/FLINK-1225
> >>> > >> > Two users ran into the issue within 2 days. The quickstart is
> mean
> >>> to
> >>> > >> give
> >>> > >> > new users a good experience.
> >>> > >> >
> >>> > >> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <
> sewen@apache.org>
> >>> > wrote:
> >>> > >> >>
> >>> > >> >> Hi!
> >>> > >> >>
> >>> > >> >> I forked a branch "release-0.8" and bumped the master version
> to
> >>> > >> >> "0.9-incubating-SNAPSHOT".
> >>> > >> >>
> >>> > >> >> The closure cleaner is merged. Robert has opened a PR for Kryo
> - I
> >>> > would
> >>> > >> >> suggest to merge that to "master", cherry-pick to "release-0.8"
> >>> and
> >>> > >> then:
> >>> > >> >> Merry releasing!
> >>> > >> >>
> >>> > >> >> Greetings,
> >>> > >> >> Stephan
> >>> > >> >>
> >>> > >> >>
> >>> > >> >>
> >>> > >> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
> >>> > >> balassi.marton@gmail.com>
> >>> > >> >> wrote:
> >>> > >> >> >
> >>> > >> >> > @Timo&Stephan: The streaming code uses this since last week
> [1],
> >>> > Timo
> >>> > >> >> > starting working on the issue prior way before that - so it
> also
> >>> > has
> >>> > >> to
> >>> > >> >> do
> >>> > >> >> > with the streaming team pushing last minute features to be
> >>> > honest...
> >>> > >> >> >
> >>> > >> >> > Then are we waiting for the Java Clousure cleaner and the
> Kyro
> >>> > >> support, I
> >>> > >> >> > guess.
> >>> > >> >> > Aljoscha has already issued a PR for the former, some
> additional
> >>> > >> testing
> >>> > >> >> is
> >>> > >> >> > needed from the looks of it. [2]
> >>> > >> >> >
> >>> > >> >> > [1]
> >>> > >> >> >
> >>> > >> >> >
> >>> > >> >>
> >>> > >>
> >>> >
> >>>
> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
> >>> > >> >> > [2] https://github.com/apache/incubator-flink/pull/269
> >>> > >> >> >
> >>> > >> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <
> >>> flink@twalthr.com>
> >>> > >> wrote:
> >>> > >> >> > >
> >>> > >> >> > > Yes, I also think so. Stability is more important.
> >>> > >> >> > >
> >>> > >> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <
> >>> sewen@apache.org
> >>> > >:
> >>> > >> >> > > >
> >>> > >> >> > > > Yes, the fact that we both did not realize that until now
> >>> sort
> >>> > of
> >>> > >> >> > reveals
> >>> > >> >> > > > that there are more implications than anticipated. That
> is
> >>> > never
> >>> > >> good
> >>> > >> >> > for
> >>> > >> >> > > > "last minute" patches.
> >>> > >> >> > > >
> >>> > >> >> > > > That's why I would like to merge it into 0.8.1 and 0.9,
> >>> rather
> >>> > >> than
> >>> > >> >> > 0.8.0
> >>> > >> >> > > > That gives the code a bit more testing/use and us a bit
> more
> >>> > time
> >>> > >> to
> >>> > >> >> > > > thoroughly think the implications through.
> >>> > >> >> > > >
> >>> > >> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <
> >>> > flink@twalthr.com
> >>> > >> >
> >>> > >> >> > > wrote:
> >>> > >> >> > > >>
> >>> > >> >> > > >> Sorry I totally forgot to check the streaming API. Do
> they
> >>> use
> >>> > >> the
> >>> > >> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
> >>> > >> >> > > >>
> >>> > >> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
> >>> > >> rmetzger@apache.org
> >>> > >> >> >:
> >>> > >> >> > > >>>
> >>> > >> >> > > >>> I've worked on adding Kryo support to Flink today. I
> would
> >>> > >> really
> >>> > >> >> > like
> >>> > >> >> > > to
> >>> > >> >> > > >>> include this into the release. Many users were
> complaining
> >>> > about
> >>> > >> >> > this (
> >>> > >> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
> >>> > >> >> > > >>>
> >>> > >> >> > > >>> I've based my work on top of Timo's pull request. If
> we're
> >>> > not
> >>> > >> >> going
> >>> > >> >> > to
> >>> > >> >> > > >>> merge it, I will have to rebase my code to the current
> >>> > master.
> >>> > >> ...
> >>> > >> >> > I'll
> >>> > >> >> > > >> try
> >>> > >> >> > > >>> and see if its easily doable.
> >>> > >> >> > > >>>
> >>> > >> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
> >>> > >> sewen@apache.org>
> >>> > >> >> > > wrote:
> >>> > >> >> > > >>>>
> >>> > >> >> > > >>>> Yes, one thing I just realized is that the streaming
> API
> >>> is
> >>> > not
> >>> > >> >> > aware
> >>> > >> >> > > of
> >>> > >> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
> >>> > >> >> > > >>>>
> >>> > >> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
> >>> > >> >> fhueske@gmail.com>
> >>> > >> >> > > >> wrote:
> >>> > >> >> > > >>>>>
> >>> > >> >> > > >>>>> +1 for stability first
> >>> > >> >> > > >>>>>
> >>> > >> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <
> >>> sewen@apache.org
> >>> > >:
> >>> > >> >> > > >>>>>>
> >>> > >> >> > > >>>>>> I am currently working through the type hints pull
> >>> > request...
> >>> > >> >> > > >>>>>>
> >>> > >> >> > > >>>>>> Right now, I actually think that we should postpone
> >>> this
> >>> > for
> >>> > >> the
> >>> > >> >> > > next
> >>> > >> >> > > >>>>>> bugfix release.
> >>> > >> >> > > >>>>>>
> >>> > >> >> > > >>>>>> This pull request changes actually some tricky
> >>> mechanisms
> >>> > in
> >>> > >> the
> >>> > >> >> > > Java
> >>> > >> >> > > >>>> API
> >>> > >> >> > > >>>>>> (it delays the type information), which may have
> >>> > implications
> >>> > >> >> that
> >>> > >> >> > > me
> >>> > >> >> > > >>>> and
> >>> > >> >> > > >>>>>> Timo have not fully caught now.
> >>> > >> >> > > >>>>>>
> >>> > >> >> > > >>>>>> I don't feel Merging this last minute - this is
> prone
> >>> to
> >>> > >> >> introduce
> >>> > >> >> > > >>>>> errors.
> >>> > >> >> > > >>>>>>
> >>> > >> >> > > >>>>>> Any opinions on that?
> >>> > >> >> > > >>>>>>
> >>> > >> >> > > >>>>>>
> >>> > >> >> > > >>>>>>
> >>> > >> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
> >>> > >> sewen@apache.org
> >>> > >> >> >
> >>> > >> >> > > >>>> wrote:
> >>> > >> >> > > >>>>>>>
> >>> > >> >> > > >>>>>>> +1 for adding the closure cleaner...
> >>> > >> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
> >>> > >> >> > > aljoscha@apache.org
> >>> > >> >> > > >>>>> :
> >>> > >> >> > > >>>>>>>
> >>> > >> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
> >>> > >> >> > > >>>>>>>>
> >>> > >> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> >>> > >> >> > > >>>>>>>> <ba...@gmail.com> wrote:
> >>> > >> >> > > >>>>>>>>> Cool, thanks.
> >>> > >> >> > > >>>>>>>>>
> >>> > >> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
> >>> > >> >> > sewen@apache.org
> >>> > >> >> > > >
> >>> > >> >> > > >>>>>>>> wrote:
> >>> > >> >> > > >>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>> Hi!
> >>> > >> >> > > >>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made some
> >>> final
> >>> > >> >> > adjustments
> >>> > >> >> > > >>>>>>>> yesterday
> >>> > >> >> > > >>>>>>>>>> evening. I'll review and merge it now, then we
> can
> >>> > fork
> >>> > >> the
> >>> > >> >> > > >>>> branch.
> >>> > >> >> > > >>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>> Cheers,
> >>> > >> >> > > >>>>>>>>>> Stephan
> >>> > >> >> > > >>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton
> Balassi <
> >>> > >> >> > > >>>>>>>> balassi.marton@gmail.com
> >>> > >> >> > > >>>>>>>>>> wrote:
> >>> > >> >> > > >>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>> Hey,
> >>> > >> >> > > >>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems
> every
> >>> > import
> >>> > >> >> one
> >>> > >> >> > > >>>> has
> >>> > >> >> > > >>>>>> been
> >>> > >> >> > > >>>>>>>>>>> merged. As for the optional ones the following
> two
> >>> > are
> >>> > >> >> still
> >>> > >> >> > > >>>>>> pending:
> >>> > >> >> > > >>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces,
> Abstract
> >>> > >> Classes as
> >>> > >> >> > > >>>> POJOs
> >>> > >> >> > > >>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API
> >>> > operators
> >>> > >> >> > > >>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just
> >>> > updated
> >>> > >> it.
> >>> > >> >> > > >>>> Should
> >>> > >> >> > > >>>>>> we
> >>> > >> >> > > >>>>>>>> wait
> >>> > >> >> > > >>>>>>>>>>> for it?
> >>> > >> >> > > >>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>> Cheers,
> >>> > >> >> > > >>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>> Marton
> >>> > >> >> > > >>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <
> >>> > >> >> uce@apache.org
> >>> > >> >> > >
> >>> > >> >> > > >>>>>> wrote:
> >>> > >> >> > > >>>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen
> <
> >>> > >> >> > > >>>>> sewen@apache.org>
> >>> > >> >> > > >>>>>>>>>> wrote:
> >>> > >> >> > > >>>>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>>>
> ----------------------------------------------
> >>> > >> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
> >>> > >> >> > > >>>>>>>>>>>>>
> ----------------------------------------------
> >>> > >> >> > > >>>>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers
> >>> > splits
> >>> > >> with
> >>> > >> >> > > >>>>> less
> >>> > >> >> > > >>>>>>>>>> degrees
> >>> > >> >> > > >>>>>>>>>>> of
> >>> > >> >> > > >>>>>>>>>>>>> freedom
> >>> > >> >> > > >>>>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for
> >>> > HadoopInputWrapper
> >>> > >> and
> >>> > >> >> > > >>>>>>>>>> NullWritable
> >>> > >> >> > > >>>>>>>>>>>>> support
> >>> > >> >> > > >>>>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new
> >>> Tuple
> >>> > >> APIs +
> >>> > >> >> > > >>>> fix
> >>> > >> >> > > >>>>>> of
> >>> > >> >> > > >>>>>>>>>>>>> ExecutionEnvironment
> >>> > >> >> > > >>>>>>>>>>>>> (this is partially merged, there are a few
> POM
> >>> > entries
> >>> > >> >> > > >>>>> missing
> >>> > >> >> > > >>>>>>>> for
> >>> > >> >> > > >>>>>>>>>>>> Hadoop 1
> >>> > >> >> > > >>>>>>>>>>>>> support)
> >>> > >> >> > > >>>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>> The first two PRs are still open. I will have
> a
> >>> > look at
> >>> > >> >> them
> >>> > >> >> > > >>>> as
> >>> > >> >> > > >>>>>>>> well
> >>> > >> >> > > >>>>>>>>>>>> (Robert already tested one).
> >>> > >> >> > > >>>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>> @Robert:
> >>> > >> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by
> 1b69749
> >>> > >> ("Enable
> >>> > >> >> > > >>>>>>>> flink-hbase
> >>> > >> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
> >>> > >> >> > > >>>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>>
> >>> > >> >> > > >>>>>>>>>>>> It would be nice if had a look at the
> remaining
> >>> > >> important
> >>> > >> >> > > >>>> ones
> >>> > >> >> > > >>>>>>>> today.
> >>> > >> >> > > >>>>>>>>>> :-)
> >>> > >> >> > > >>
> >>> > >> >> > >
> >>> > >> >> >
> >>> > >> >>
> >>> > >>
> >>> >
> >>>
> >>
> >>
>
Re: Forking off the 0.8 release branch.
Posted by Henry Saputra <he...@gmail.com>.
When you said "finish the release" meaning distribute/publish a TLP
release in the incubating branch repo?
- Henry
On Mon, Jan 5, 2015 at 6:38 AM, Robert Metzger <rm...@apache.org> wrote:
> Allright .. I've asked infra and they plan to do the graduation this week
> ("hopefully today/tomorrow").
> If that is really going to happen in the next days, I would suggest to let
> Marton finish the release. If there are any major delays due to INFRA, I'll
> do the release.
>
> On Fri, Jan 2, 2015 at 10:37 AM, Robert Metzger <rm...@apache.org> wrote:
>
>> Thanks for the update.
>>
>> Happy new year to everyone.
>>
>> It seems that we have to wait for INFRA to finish the LDAP group creation
>> for the new TLP first, since this is connected to the maven repository.
>> If nothing happened until Monday, I'll ask infra on their IRC chat if they
>> can resolve the LDAP group creation.
>>
>>
>> Robert
>>
>>
>>
>> On Fri, Jan 2, 2015 at 9:45 AM, Márton Balassi <ba...@gmail.com>
>> wrote:
>>
>>> Happy new year Flinkers,
>>>
>>> I'm sorry that I could not report any progress on the release yet. It was
>>> finally clarified that we are actually blocked by the apache
>>> infrastructure
>>> at the moment. [1]
>>>
>>> [1] https://issues.apache.org/jira/browse/INFRA-8954
>>>
>>> Marton
>>>
>>> On Fri, Dec 19, 2014 at 11:00 PM, Henry Saputra <he...@gmail.com>
>>> wrote:
>>>
>>> > Thanks for the update Marton.
>>> >
>>> > So with we are graduating it is coming as blessing but unfortunately
>>> > adding more work to the release process.
>>> >
>>> > Please do let us know if you need any help with the release.
>>> >
>>> > - Henry
>>> >
>>> > On Fri, Dec 19, 2014 at 12:38 PM, Márton Balassi
>>> > <ba...@gmail.com> wrote:
>>> > > +1 on quickstart, I'm having a look at it tomorrow.
>>> > >
>>> > > Robert also pointed out the the DISCLAIMER file (for incubation,
>>> > currently
>>> > > also added to the distribution) is no longer needed neither on the
>>> master
>>> > > nor on the release branch. Other minor things in the repo regarding
>>> the
>>> > > graduation:
>>> > >
>>> > > * Eliminating the incubating subscript from the project version
>>> > > * Updating the the docs (mostly mentioned in variables, sometimes in
>>> > > since given version that should not be changed)
>>> > > * Updating the quickstart scripts (more related to simply releasing)
>>> > >
>>> > > I'm deleting the DISCLAIMER from the repo and the assemblies, bumping
>>> the
>>> > > version and updating the parts of the docs that can be done prior to
>>> the
>>> > > release.
>>> > >
>>> > > As for the state of the relese: With the help of Robert I have
>>> acquired
>>> > the
>>> > > necessary knowledge and set up the tools needed for the release. I
>>> have
>>> > > still minor issues with maven, but I'm confident that the solution is
>>> > near.
>>> > > I also fell motivated to write down my experiences in a documentation
>>> to
>>> > > spare some time for up and coming release managers.
>>> > >
>>> > > Best,
>>> > >
>>> > > Marton
>>> > >
>>> > > On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <
>>> aljoscha@apache.org>
>>> > > wrote:
>>> > >>
>>> > >> +1
>>> > >>
>>> > >> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <rmetzger@apache.org
>>> >
>>> > >> wrote:
>>> > >> > Hi guys,
>>> > >> >
>>> > >> > I vote to make this issue a release blocker:
>>> > >> > https://issues.apache.org/jira/browse/FLINK-1225
>>> > >> > Two users ran into the issue within 2 days. The quickstart is mean
>>> to
>>> > >> give
>>> > >> > new users a good experience.
>>> > >> >
>>> > >> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <se...@apache.org>
>>> > wrote:
>>> > >> >>
>>> > >> >> Hi!
>>> > >> >>
>>> > >> >> I forked a branch "release-0.8" and bumped the master version to
>>> > >> >> "0.9-incubating-SNAPSHOT".
>>> > >> >>
>>> > >> >> The closure cleaner is merged. Robert has opened a PR for Kryo - I
>>> > would
>>> > >> >> suggest to merge that to "master", cherry-pick to "release-0.8"
>>> and
>>> > >> then:
>>> > >> >> Merry releasing!
>>> > >> >>
>>> > >> >> Greetings,
>>> > >> >> Stephan
>>> > >> >>
>>> > >> >>
>>> > >> >>
>>> > >> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
>>> > >> balassi.marton@gmail.com>
>>> > >> >> wrote:
>>> > >> >> >
>>> > >> >> > @Timo&Stephan: The streaming code uses this since last week [1],
>>> > Timo
>>> > >> >> > starting working on the issue prior way before that - so it also
>>> > has
>>> > >> to
>>> > >> >> do
>>> > >> >> > with the streaming team pushing last minute features to be
>>> > honest...
>>> > >> >> >
>>> > >> >> > Then are we waiting for the Java Clousure cleaner and the Kyro
>>> > >> support, I
>>> > >> >> > guess.
>>> > >> >> > Aljoscha has already issued a PR for the former, some additional
>>> > >> testing
>>> > >> >> is
>>> > >> >> > needed from the looks of it. [2]
>>> > >> >> >
>>> > >> >> > [1]
>>> > >> >> >
>>> > >> >> >
>>> > >> >>
>>> > >>
>>> >
>>> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
>>> > >> >> > [2] https://github.com/apache/incubator-flink/pull/269
>>> > >> >> >
>>> > >> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <
>>> flink@twalthr.com>
>>> > >> wrote:
>>> > >> >> > >
>>> > >> >> > > Yes, I also think so. Stability is more important.
>>> > >> >> > >
>>> > >> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <
>>> sewen@apache.org
>>> > >:
>>> > >> >> > > >
>>> > >> >> > > > Yes, the fact that we both did not realize that until now
>>> sort
>>> > of
>>> > >> >> > reveals
>>> > >> >> > > > that there are more implications than anticipated. That is
>>> > never
>>> > >> good
>>> > >> >> > for
>>> > >> >> > > > "last minute" patches.
>>> > >> >> > > >
>>> > >> >> > > > That's why I would like to merge it into 0.8.1 and 0.9,
>>> rather
>>> > >> than
>>> > >> >> > 0.8.0
>>> > >> >> > > > That gives the code a bit more testing/use and us a bit more
>>> > time
>>> > >> to
>>> > >> >> > > > thoroughly think the implications through.
>>> > >> >> > > >
>>> > >> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <
>>> > flink@twalthr.com
>>> > >> >
>>> > >> >> > > wrote:
>>> > >> >> > > >>
>>> > >> >> > > >> Sorry I totally forgot to check the streaming API. Do they
>>> use
>>> > >> the
>>> > >> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
>>> > >> >> > > >>
>>> > >> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
>>> > >> rmetzger@apache.org
>>> > >> >> >:
>>> > >> >> > > >>>
>>> > >> >> > > >>> I've worked on adding Kryo support to Flink today. I would
>>> > >> really
>>> > >> >> > like
>>> > >> >> > > to
>>> > >> >> > > >>> include this into the release. Many users were complaining
>>> > about
>>> > >> >> > this (
>>> > >> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
>>> > >> >> > > >>>
>>> > >> >> > > >>> I've based my work on top of Timo's pull request. If we're
>>> > not
>>> > >> >> going
>>> > >> >> > to
>>> > >> >> > > >>> merge it, I will have to rebase my code to the current
>>> > master.
>>> > >> ...
>>> > >> >> > I'll
>>> > >> >> > > >> try
>>> > >> >> > > >>> and see if its easily doable.
>>> > >> >> > > >>>
>>> > >> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
>>> > >> sewen@apache.org>
>>> > >> >> > > wrote:
>>> > >> >> > > >>>>
>>> > >> >> > > >>>> Yes, one thing I just realized is that the streaming API
>>> is
>>> > not
>>> > >> >> > aware
>>> > >> >> > > of
>>> > >> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
>>> > >> >> > > >>>>
>>> > >> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
>>> > >> >> fhueske@gmail.com>
>>> > >> >> > > >> wrote:
>>> > >> >> > > >>>>>
>>> > >> >> > > >>>>> +1 for stability first
>>> > >> >> > > >>>>>
>>> > >> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <
>>> sewen@apache.org
>>> > >:
>>> > >> >> > > >>>>>>
>>> > >> >> > > >>>>>> I am currently working through the type hints pull
>>> > request...
>>> > >> >> > > >>>>>>
>>> > >> >> > > >>>>>> Right now, I actually think that we should postpone
>>> this
>>> > for
>>> > >> the
>>> > >> >> > > next
>>> > >> >> > > >>>>>> bugfix release.
>>> > >> >> > > >>>>>>
>>> > >> >> > > >>>>>> This pull request changes actually some tricky
>>> mechanisms
>>> > in
>>> > >> the
>>> > >> >> > > Java
>>> > >> >> > > >>>> API
>>> > >> >> > > >>>>>> (it delays the type information), which may have
>>> > implications
>>> > >> >> that
>>> > >> >> > > me
>>> > >> >> > > >>>> and
>>> > >> >> > > >>>>>> Timo have not fully caught now.
>>> > >> >> > > >>>>>>
>>> > >> >> > > >>>>>> I don't feel Merging this last minute - this is prone
>>> to
>>> > >> >> introduce
>>> > >> >> > > >>>>> errors.
>>> > >> >> > > >>>>>>
>>> > >> >> > > >>>>>> Any opinions on that?
>>> > >> >> > > >>>>>>
>>> > >> >> > > >>>>>>
>>> > >> >> > > >>>>>>
>>> > >> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
>>> > >> sewen@apache.org
>>> > >> >> >
>>> > >> >> > > >>>> wrote:
>>> > >> >> > > >>>>>>>
>>> > >> >> > > >>>>>>> +1 for adding the closure cleaner...
>>> > >> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
>>> > >> >> > > aljoscha@apache.org
>>> > >> >> > > >>>>> :
>>> > >> >> > > >>>>>>>
>>> > >> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
>>> > >> >> > > >>>>>>>>
>>> > >> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
>>> > >> >> > > >>>>>>>> <ba...@gmail.com> wrote:
>>> > >> >> > > >>>>>>>>> Cool, thanks.
>>> > >> >> > > >>>>>>>>>
>>> > >> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
>>> > >> >> > sewen@apache.org
>>> > >> >> > > >
>>> > >> >> > > >>>>>>>> wrote:
>>> > >> >> > > >>>>>>>>>>
>>> > >> >> > > >>>>>>>>>> Hi!
>>> > >> >> > > >>>>>>>>>>
>>> > >> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made some
>>> final
>>> > >> >> > adjustments
>>> > >> >> > > >>>>>>>> yesterday
>>> > >> >> > > >>>>>>>>>> evening. I'll review and merge it now, then we can
>>> > fork
>>> > >> the
>>> > >> >> > > >>>> branch.
>>> > >> >> > > >>>>>>>>>>
>>> > >> >> > > >>>>>>>>>> Cheers,
>>> > >> >> > > >>>>>>>>>> Stephan
>>> > >> >> > > >>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>
>>> > >> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
>>> > >> >> > > >>>>>>>> balassi.marton@gmail.com
>>> > >> >> > > >>>>>>>>>> wrote:
>>> > >> >> > > >>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>> Hey,
>>> > >> >> > > >>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems every
>>> > import
>>> > >> >> one
>>> > >> >> > > >>>> has
>>> > >> >> > > >>>>>> been
>>> > >> >> > > >>>>>>>>>>> merged. As for the optional ones the following two
>>> > are
>>> > >> >> still
>>> > >> >> > > >>>>>> pending:
>>> > >> >> > > >>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract
>>> > >> Classes as
>>> > >> >> > > >>>> POJOs
>>> > >> >> > > >>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API
>>> > operators
>>> > >> >> > > >>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just
>>> > updated
>>> > >> it.
>>> > >> >> > > >>>> Should
>>> > >> >> > > >>>>>> we
>>> > >> >> > > >>>>>>>> wait
>>> > >> >> > > >>>>>>>>>>> for it?
>>> > >> >> > > >>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>> Cheers,
>>> > >> >> > > >>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>> Marton
>>> > >> >> > > >>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <
>>> > >> >> uce@apache.org
>>> > >> >> > >
>>> > >> >> > > >>>>>> wrote:
>>> > >> >> > > >>>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
>>> > >> >> > > >>>>> sewen@apache.org>
>>> > >> >> > > >>>>>>>>>> wrote:
>>> > >> >> > > >>>>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>>> ----------------------------------------------
>>> > >> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
>>> > >> >> > > >>>>>>>>>>>>> ----------------------------------------------
>>> > >> >> > > >>>>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers
>>> > splits
>>> > >> with
>>> > >> >> > > >>>>> less
>>> > >> >> > > >>>>>>>>>> degrees
>>> > >> >> > > >>>>>>>>>>> of
>>> > >> >> > > >>>>>>>>>>>>> freedom
>>> > >> >> > > >>>>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for
>>> > HadoopInputWrapper
>>> > >> and
>>> > >> >> > > >>>>>>>>>> NullWritable
>>> > >> >> > > >>>>>>>>>>>>> support
>>> > >> >> > > >>>>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new
>>> Tuple
>>> > >> APIs +
>>> > >> >> > > >>>> fix
>>> > >> >> > > >>>>>> of
>>> > >> >> > > >>>>>>>>>>>>> ExecutionEnvironment
>>> > >> >> > > >>>>>>>>>>>>> (this is partially merged, there are a few POM
>>> > entries
>>> > >> >> > > >>>>> missing
>>> > >> >> > > >>>>>>>> for
>>> > >> >> > > >>>>>>>>>>>> Hadoop 1
>>> > >> >> > > >>>>>>>>>>>>> support)
>>> > >> >> > > >>>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>> The first two PRs are still open. I will have a
>>> > look at
>>> > >> >> them
>>> > >> >> > > >>>> as
>>> > >> >> > > >>>>>>>> well
>>> > >> >> > > >>>>>>>>>>>> (Robert already tested one).
>>> > >> >> > > >>>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>> @Robert:
>>> > >> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749
>>> > >> ("Enable
>>> > >> >> > > >>>>>>>> flink-hbase
>>> > >> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
>>> > >> >> > > >>>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>>
>>> > >> >> > > >>>>>>>>>>>> It would be nice if had a look at the remaining
>>> > >> important
>>> > >> >> > > >>>> ones
>>> > >> >> > > >>>>>>>> today.
>>> > >> >> > > >>>>>>>>>> :-)
>>> > >> >> > > >>
>>> > >> >> > >
>>> > >> >> >
>>> > >> >>
>>> > >>
>>> >
>>>
>>
>>
Re: Forking off the 0.8 release branch.
Posted by Robert Metzger <rm...@apache.org>.
Allright .. I've asked infra and they plan to do the graduation this week
("hopefully today/tomorrow").
If that is really going to happen in the next days, I would suggest to let
Marton finish the release. If there are any major delays due to INFRA, I'll
do the release.
On Fri, Jan 2, 2015 at 10:37 AM, Robert Metzger <rm...@apache.org> wrote:
> Thanks for the update.
>
> Happy new year to everyone.
>
> It seems that we have to wait for INFRA to finish the LDAP group creation
> for the new TLP first, since this is connected to the maven repository.
> If nothing happened until Monday, I'll ask infra on their IRC chat if they
> can resolve the LDAP group creation.
>
>
> Robert
>
>
>
> On Fri, Jan 2, 2015 at 9:45 AM, Márton Balassi <ba...@gmail.com>
> wrote:
>
>> Happy new year Flinkers,
>>
>> I'm sorry that I could not report any progress on the release yet. It was
>> finally clarified that we are actually blocked by the apache
>> infrastructure
>> at the moment. [1]
>>
>> [1] https://issues.apache.org/jira/browse/INFRA-8954
>>
>> Marton
>>
>> On Fri, Dec 19, 2014 at 11:00 PM, Henry Saputra <he...@gmail.com>
>> wrote:
>>
>> > Thanks for the update Marton.
>> >
>> > So with we are graduating it is coming as blessing but unfortunately
>> > adding more work to the release process.
>> >
>> > Please do let us know if you need any help with the release.
>> >
>> > - Henry
>> >
>> > On Fri, Dec 19, 2014 at 12:38 PM, Márton Balassi
>> > <ba...@gmail.com> wrote:
>> > > +1 on quickstart, I'm having a look at it tomorrow.
>> > >
>> > > Robert also pointed out the the DISCLAIMER file (for incubation,
>> > currently
>> > > also added to the distribution) is no longer needed neither on the
>> master
>> > > nor on the release branch. Other minor things in the repo regarding
>> the
>> > > graduation:
>> > >
>> > > * Eliminating the incubating subscript from the project version
>> > > * Updating the the docs (mostly mentioned in variables, sometimes in
>> > > since given version that should not be changed)
>> > > * Updating the quickstart scripts (more related to simply releasing)
>> > >
>> > > I'm deleting the DISCLAIMER from the repo and the assemblies, bumping
>> the
>> > > version and updating the parts of the docs that can be done prior to
>> the
>> > > release.
>> > >
>> > > As for the state of the relese: With the help of Robert I have
>> acquired
>> > the
>> > > necessary knowledge and set up the tools needed for the release. I
>> have
>> > > still minor issues with maven, but I'm confident that the solution is
>> > near.
>> > > I also fell motivated to write down my experiences in a documentation
>> to
>> > > spare some time for up and coming release managers.
>> > >
>> > > Best,
>> > >
>> > > Marton
>> > >
>> > > On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <
>> aljoscha@apache.org>
>> > > wrote:
>> > >>
>> > >> +1
>> > >>
>> > >> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <rmetzger@apache.org
>> >
>> > >> wrote:
>> > >> > Hi guys,
>> > >> >
>> > >> > I vote to make this issue a release blocker:
>> > >> > https://issues.apache.org/jira/browse/FLINK-1225
>> > >> > Two users ran into the issue within 2 days. The quickstart is mean
>> to
>> > >> give
>> > >> > new users a good experience.
>> > >> >
>> > >> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <se...@apache.org>
>> > wrote:
>> > >> >>
>> > >> >> Hi!
>> > >> >>
>> > >> >> I forked a branch "release-0.8" and bumped the master version to
>> > >> >> "0.9-incubating-SNAPSHOT".
>> > >> >>
>> > >> >> The closure cleaner is merged. Robert has opened a PR for Kryo - I
>> > would
>> > >> >> suggest to merge that to "master", cherry-pick to "release-0.8"
>> and
>> > >> then:
>> > >> >> Merry releasing!
>> > >> >>
>> > >> >> Greetings,
>> > >> >> Stephan
>> > >> >>
>> > >> >>
>> > >> >>
>> > >> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
>> > >> balassi.marton@gmail.com>
>> > >> >> wrote:
>> > >> >> >
>> > >> >> > @Timo&Stephan: The streaming code uses this since last week [1],
>> > Timo
>> > >> >> > starting working on the issue prior way before that - so it also
>> > has
>> > >> to
>> > >> >> do
>> > >> >> > with the streaming team pushing last minute features to be
>> > honest...
>> > >> >> >
>> > >> >> > Then are we waiting for the Java Clousure cleaner and the Kyro
>> > >> support, I
>> > >> >> > guess.
>> > >> >> > Aljoscha has already issued a PR for the former, some additional
>> > >> testing
>> > >> >> is
>> > >> >> > needed from the looks of it. [2]
>> > >> >> >
>> > >> >> > [1]
>> > >> >> >
>> > >> >> >
>> > >> >>
>> > >>
>> >
>> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
>> > >> >> > [2] https://github.com/apache/incubator-flink/pull/269
>> > >> >> >
>> > >> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <
>> flink@twalthr.com>
>> > >> wrote:
>> > >> >> > >
>> > >> >> > > Yes, I also think so. Stability is more important.
>> > >> >> > >
>> > >> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <
>> sewen@apache.org
>> > >:
>> > >> >> > > >
>> > >> >> > > > Yes, the fact that we both did not realize that until now
>> sort
>> > of
>> > >> >> > reveals
>> > >> >> > > > that there are more implications than anticipated. That is
>> > never
>> > >> good
>> > >> >> > for
>> > >> >> > > > "last minute" patches.
>> > >> >> > > >
>> > >> >> > > > That's why I would like to merge it into 0.8.1 and 0.9,
>> rather
>> > >> than
>> > >> >> > 0.8.0
>> > >> >> > > > That gives the code a bit more testing/use and us a bit more
>> > time
>> > >> to
>> > >> >> > > > thoroughly think the implications through.
>> > >> >> > > >
>> > >> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <
>> > flink@twalthr.com
>> > >> >
>> > >> >> > > wrote:
>> > >> >> > > >>
>> > >> >> > > >> Sorry I totally forgot to check the streaming API. Do they
>> use
>> > >> the
>> > >> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
>> > >> >> > > >>
>> > >> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
>> > >> rmetzger@apache.org
>> > >> >> >:
>> > >> >> > > >>>
>> > >> >> > > >>> I've worked on adding Kryo support to Flink today. I would
>> > >> really
>> > >> >> > like
>> > >> >> > > to
>> > >> >> > > >>> include this into the release. Many users were complaining
>> > about
>> > >> >> > this (
>> > >> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
>> > >> >> > > >>>
>> > >> >> > > >>> I've based my work on top of Timo's pull request. If we're
>> > not
>> > >> >> going
>> > >> >> > to
>> > >> >> > > >>> merge it, I will have to rebase my code to the current
>> > master.
>> > >> ...
>> > >> >> > I'll
>> > >> >> > > >> try
>> > >> >> > > >>> and see if its easily doable.
>> > >> >> > > >>>
>> > >> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
>> > >> sewen@apache.org>
>> > >> >> > > wrote:
>> > >> >> > > >>>>
>> > >> >> > > >>>> Yes, one thing I just realized is that the streaming API
>> is
>> > not
>> > >> >> > aware
>> > >> >> > > of
>> > >> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
>> > >> >> > > >>>>
>> > >> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
>> > >> >> fhueske@gmail.com>
>> > >> >> > > >> wrote:
>> > >> >> > > >>>>>
>> > >> >> > > >>>>> +1 for stability first
>> > >> >> > > >>>>>
>> > >> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <
>> sewen@apache.org
>> > >:
>> > >> >> > > >>>>>>
>> > >> >> > > >>>>>> I am currently working through the type hints pull
>> > request...
>> > >> >> > > >>>>>>
>> > >> >> > > >>>>>> Right now, I actually think that we should postpone
>> this
>> > for
>> > >> the
>> > >> >> > > next
>> > >> >> > > >>>>>> bugfix release.
>> > >> >> > > >>>>>>
>> > >> >> > > >>>>>> This pull request changes actually some tricky
>> mechanisms
>> > in
>> > >> the
>> > >> >> > > Java
>> > >> >> > > >>>> API
>> > >> >> > > >>>>>> (it delays the type information), which may have
>> > implications
>> > >> >> that
>> > >> >> > > me
>> > >> >> > > >>>> and
>> > >> >> > > >>>>>> Timo have not fully caught now.
>> > >> >> > > >>>>>>
>> > >> >> > > >>>>>> I don't feel Merging this last minute - this is prone
>> to
>> > >> >> introduce
>> > >> >> > > >>>>> errors.
>> > >> >> > > >>>>>>
>> > >> >> > > >>>>>> Any opinions on that?
>> > >> >> > > >>>>>>
>> > >> >> > > >>>>>>
>> > >> >> > > >>>>>>
>> > >> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
>> > >> sewen@apache.org
>> > >> >> >
>> > >> >> > > >>>> wrote:
>> > >> >> > > >>>>>>>
>> > >> >> > > >>>>>>> +1 for adding the closure cleaner...
>> > >> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
>> > >> >> > > aljoscha@apache.org
>> > >> >> > > >>>>> :
>> > >> >> > > >>>>>>>
>> > >> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
>> > >> >> > > >>>>>>>>
>> > >> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
>> > >> >> > > >>>>>>>> <ba...@gmail.com> wrote:
>> > >> >> > > >>>>>>>>> Cool, thanks.
>> > >> >> > > >>>>>>>>>
>> > >> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
>> > >> >> > sewen@apache.org
>> > >> >> > > >
>> > >> >> > > >>>>>>>> wrote:
>> > >> >> > > >>>>>>>>>>
>> > >> >> > > >>>>>>>>>> Hi!
>> > >> >> > > >>>>>>>>>>
>> > >> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made some
>> final
>> > >> >> > adjustments
>> > >> >> > > >>>>>>>> yesterday
>> > >> >> > > >>>>>>>>>> evening. I'll review and merge it now, then we can
>> > fork
>> > >> the
>> > >> >> > > >>>> branch.
>> > >> >> > > >>>>>>>>>>
>> > >> >> > > >>>>>>>>>> Cheers,
>> > >> >> > > >>>>>>>>>> Stephan
>> > >> >> > > >>>>>>>>>>
>> > >> >> > > >>>>>>>>>>
>> > >> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
>> > >> >> > > >>>>>>>> balassi.marton@gmail.com
>> > >> >> > > >>>>>>>>>> wrote:
>> > >> >> > > >>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>> Hey,
>> > >> >> > > >>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems every
>> > import
>> > >> >> one
>> > >> >> > > >>>> has
>> > >> >> > > >>>>>> been
>> > >> >> > > >>>>>>>>>>> merged. As for the optional ones the following two
>> > are
>> > >> >> still
>> > >> >> > > >>>>>> pending:
>> > >> >> > > >>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract
>> > >> Classes as
>> > >> >> > > >>>> POJOs
>> > >> >> > > >>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API
>> > operators
>> > >> >> > > >>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just
>> > updated
>> > >> it.
>> > >> >> > > >>>> Should
>> > >> >> > > >>>>>> we
>> > >> >> > > >>>>>>>> wait
>> > >> >> > > >>>>>>>>>>> for it?
>> > >> >> > > >>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>> Cheers,
>> > >> >> > > >>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>> Marton
>> > >> >> > > >>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <
>> > >> >> uce@apache.org
>> > >> >> > >
>> > >> >> > > >>>>>> wrote:
>> > >> >> > > >>>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
>> > >> >> > > >>>>> sewen@apache.org>
>> > >> >> > > >>>>>>>>>> wrote:
>> > >> >> > > >>>>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>>> ----------------------------------------------
>> > >> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
>> > >> >> > > >>>>>>>>>>>>> ----------------------------------------------
>> > >> >> > > >>>>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers
>> > splits
>> > >> with
>> > >> >> > > >>>>> less
>> > >> >> > > >>>>>>>>>> degrees
>> > >> >> > > >>>>>>>>>>> of
>> > >> >> > > >>>>>>>>>>>>> freedom
>> > >> >> > > >>>>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for
>> > HadoopInputWrapper
>> > >> and
>> > >> >> > > >>>>>>>>>> NullWritable
>> > >> >> > > >>>>>>>>>>>>> support
>> > >> >> > > >>>>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new
>> Tuple
>> > >> APIs +
>> > >> >> > > >>>> fix
>> > >> >> > > >>>>>> of
>> > >> >> > > >>>>>>>>>>>>> ExecutionEnvironment
>> > >> >> > > >>>>>>>>>>>>> (this is partially merged, there are a few POM
>> > entries
>> > >> >> > > >>>>> missing
>> > >> >> > > >>>>>>>> for
>> > >> >> > > >>>>>>>>>>>> Hadoop 1
>> > >> >> > > >>>>>>>>>>>>> support)
>> > >> >> > > >>>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>> The first two PRs are still open. I will have a
>> > look at
>> > >> >> them
>> > >> >> > > >>>> as
>> > >> >> > > >>>>>>>> well
>> > >> >> > > >>>>>>>>>>>> (Robert already tested one).
>> > >> >> > > >>>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>> @Robert:
>> > >> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749
>> > >> ("Enable
>> > >> >> > > >>>>>>>> flink-hbase
>> > >> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
>> > >> >> > > >>>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>>
>> > >> >> > > >>>>>>>>>>>> It would be nice if had a look at the remaining
>> > >> important
>> > >> >> > > >>>> ones
>> > >> >> > > >>>>>>>> today.
>> > >> >> > > >>>>>>>>>> :-)
>> > >> >> > > >>
>> > >> >> > >
>> > >> >> >
>> > >> >>
>> > >>
>> >
>>
>
>
Re: Forking off the 0.8 release branch.
Posted by Robert Metzger <rm...@apache.org>.
Thanks for the update.
Happy new year to everyone.
It seems that we have to wait for INFRA to finish the LDAP group creation
for the new TLP first, since this is connected to the maven repository.
If nothing happened until Monday, I'll ask infra on their IRC chat if they
can resolve the LDAP group creation.
Robert
On Fri, Jan 2, 2015 at 9:45 AM, Márton Balassi <ba...@gmail.com>
wrote:
> Happy new year Flinkers,
>
> I'm sorry that I could not report any progress on the release yet. It was
> finally clarified that we are actually blocked by the apache infrastructure
> at the moment. [1]
>
> [1] https://issues.apache.org/jira/browse/INFRA-8954
>
> Marton
>
> On Fri, Dec 19, 2014 at 11:00 PM, Henry Saputra <he...@gmail.com>
> wrote:
>
> > Thanks for the update Marton.
> >
> > So with we are graduating it is coming as blessing but unfortunately
> > adding more work to the release process.
> >
> > Please do let us know if you need any help with the release.
> >
> > - Henry
> >
> > On Fri, Dec 19, 2014 at 12:38 PM, Márton Balassi
> > <ba...@gmail.com> wrote:
> > > +1 on quickstart, I'm having a look at it tomorrow.
> > >
> > > Robert also pointed out the the DISCLAIMER file (for incubation,
> > currently
> > > also added to the distribution) is no longer needed neither on the
> master
> > > nor on the release branch. Other minor things in the repo regarding the
> > > graduation:
> > >
> > > * Eliminating the incubating subscript from the project version
> > > * Updating the the docs (mostly mentioned in variables, sometimes in
> > > since given version that should not be changed)
> > > * Updating the quickstart scripts (more related to simply releasing)
> > >
> > > I'm deleting the DISCLAIMER from the repo and the assemblies, bumping
> the
> > > version and updating the parts of the docs that can be done prior to
> the
> > > release.
> > >
> > > As for the state of the relese: With the help of Robert I have acquired
> > the
> > > necessary knowledge and set up the tools needed for the release. I have
> > > still minor issues with maven, but I'm confident that the solution is
> > near.
> > > I also fell motivated to write down my experiences in a documentation
> to
> > > spare some time for up and coming release managers.
> > >
> > > Best,
> > >
> > > Marton
> > >
> > > On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <aljoscha@apache.org
> >
> > > wrote:
> > >>
> > >> +1
> > >>
> > >> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <rm...@apache.org>
> > >> wrote:
> > >> > Hi guys,
> > >> >
> > >> > I vote to make this issue a release blocker:
> > >> > https://issues.apache.org/jira/browse/FLINK-1225
> > >> > Two users ran into the issue within 2 days. The quickstart is mean
> to
> > >> give
> > >> > new users a good experience.
> > >> >
> > >> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <se...@apache.org>
> > wrote:
> > >> >>
> > >> >> Hi!
> > >> >>
> > >> >> I forked a branch "release-0.8" and bumped the master version to
> > >> >> "0.9-incubating-SNAPSHOT".
> > >> >>
> > >> >> The closure cleaner is merged. Robert has opened a PR for Kryo - I
> > would
> > >> >> suggest to merge that to "master", cherry-pick to "release-0.8" and
> > >> then:
> > >> >> Merry releasing!
> > >> >>
> > >> >> Greetings,
> > >> >> Stephan
> > >> >>
> > >> >>
> > >> >>
> > >> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
> > >> balassi.marton@gmail.com>
> > >> >> wrote:
> > >> >> >
> > >> >> > @Timo&Stephan: The streaming code uses this since last week [1],
> > Timo
> > >> >> > starting working on the issue prior way before that - so it also
> > has
> > >> to
> > >> >> do
> > >> >> > with the streaming team pushing last minute features to be
> > honest...
> > >> >> >
> > >> >> > Then are we waiting for the Java Clousure cleaner and the Kyro
> > >> support, I
> > >> >> > guess.
> > >> >> > Aljoscha has already issued a PR for the former, some additional
> > >> testing
> > >> >> is
> > >> >> > needed from the looks of it. [2]
> > >> >> >
> > >> >> > [1]
> > >> >> >
> > >> >> >
> > >> >>
> > >>
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
> > >> >> > [2] https://github.com/apache/incubator-flink/pull/269
> > >> >> >
> > >> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <flink@twalthr.com
> >
> > >> wrote:
> > >> >> > >
> > >> >> > > Yes, I also think so. Stability is more important.
> > >> >> > >
> > >> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <
> sewen@apache.org
> > >:
> > >> >> > > >
> > >> >> > > > Yes, the fact that we both did not realize that until now
> sort
> > of
> > >> >> > reveals
> > >> >> > > > that there are more implications than anticipated. That is
> > never
> > >> good
> > >> >> > for
> > >> >> > > > "last minute" patches.
> > >> >> > > >
> > >> >> > > > That's why I would like to merge it into 0.8.1 and 0.9,
> rather
> > >> than
> > >> >> > 0.8.0
> > >> >> > > > That gives the code a bit more testing/use and us a bit more
> > time
> > >> to
> > >> >> > > > thoroughly think the implications through.
> > >> >> > > >
> > >> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <
> > flink@twalthr.com
> > >> >
> > >> >> > > wrote:
> > >> >> > > >>
> > >> >> > > >> Sorry I totally forgot to check the streaming API. Do they
> use
> > >> the
> > >> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
> > >> >> > > >>
> > >> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
> > >> rmetzger@apache.org
> > >> >> >:
> > >> >> > > >>>
> > >> >> > > >>> I've worked on adding Kryo support to Flink today. I would
> > >> really
> > >> >> > like
> > >> >> > > to
> > >> >> > > >>> include this into the release. Many users were complaining
> > about
> > >> >> > this (
> > >> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
> > >> >> > > >>>
> > >> >> > > >>> I've based my work on top of Timo's pull request. If we're
> > not
> > >> >> going
> > >> >> > to
> > >> >> > > >>> merge it, I will have to rebase my code to the current
> > master.
> > >> ...
> > >> >> > I'll
> > >> >> > > >> try
> > >> >> > > >>> and see if its easily doable.
> > >> >> > > >>>
> > >> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
> > >> sewen@apache.org>
> > >> >> > > wrote:
> > >> >> > > >>>>
> > >> >> > > >>>> Yes, one thing I just realized is that the streaming API
> is
> > not
> > >> >> > aware
> > >> >> > > of
> > >> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
> > >> >> > > >>>>
> > >> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
> > >> >> fhueske@gmail.com>
> > >> >> > > >> wrote:
> > >> >> > > >>>>>
> > >> >> > > >>>>> +1 for stability first
> > >> >> > > >>>>>
> > >> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <
> sewen@apache.org
> > >:
> > >> >> > > >>>>>>
> > >> >> > > >>>>>> I am currently working through the type hints pull
> > request...
> > >> >> > > >>>>>>
> > >> >> > > >>>>>> Right now, I actually think that we should postpone this
> > for
> > >> the
> > >> >> > > next
> > >> >> > > >>>>>> bugfix release.
> > >> >> > > >>>>>>
> > >> >> > > >>>>>> This pull request changes actually some tricky
> mechanisms
> > in
> > >> the
> > >> >> > > Java
> > >> >> > > >>>> API
> > >> >> > > >>>>>> (it delays the type information), which may have
> > implications
> > >> >> that
> > >> >> > > me
> > >> >> > > >>>> and
> > >> >> > > >>>>>> Timo have not fully caught now.
> > >> >> > > >>>>>>
> > >> >> > > >>>>>> I don't feel Merging this last minute - this is prone to
> > >> >> introduce
> > >> >> > > >>>>> errors.
> > >> >> > > >>>>>>
> > >> >> > > >>>>>> Any opinions on that?
> > >> >> > > >>>>>>
> > >> >> > > >>>>>>
> > >> >> > > >>>>>>
> > >> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
> > >> sewen@apache.org
> > >> >> >
> > >> >> > > >>>> wrote:
> > >> >> > > >>>>>>>
> > >> >> > > >>>>>>> +1 for adding the closure cleaner...
> > >> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
> > >> >> > > aljoscha@apache.org
> > >> >> > > >>>>> :
> > >> >> > > >>>>>>>
> > >> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
> > >> >> > > >>>>>>>>
> > >> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> > >> >> > > >>>>>>>> <ba...@gmail.com> wrote:
> > >> >> > > >>>>>>>>> Cool, thanks.
> > >> >> > > >>>>>>>>>
> > >> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
> > >> >> > sewen@apache.org
> > >> >> > > >
> > >> >> > > >>>>>>>> wrote:
> > >> >> > > >>>>>>>>>>
> > >> >> > > >>>>>>>>>> Hi!
> > >> >> > > >>>>>>>>>>
> > >> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made some final
> > >> >> > adjustments
> > >> >> > > >>>>>>>> yesterday
> > >> >> > > >>>>>>>>>> evening. I'll review and merge it now, then we can
> > fork
> > >> the
> > >> >> > > >>>> branch.
> > >> >> > > >>>>>>>>>>
> > >> >> > > >>>>>>>>>> Cheers,
> > >> >> > > >>>>>>>>>> Stephan
> > >> >> > > >>>>>>>>>>
> > >> >> > > >>>>>>>>>>
> > >> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> > >> >> > > >>>>>>>> balassi.marton@gmail.com
> > >> >> > > >>>>>>>>>> wrote:
> > >> >> > > >>>>>>>>>>>
> > >> >> > > >>>>>>>>>>> Hey,
> > >> >> > > >>>>>>>>>>>
> > >> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems every
> > import
> > >> >> one
> > >> >> > > >>>> has
> > >> >> > > >>>>>> been
> > >> >> > > >>>>>>>>>>> merged. As for the optional ones the following two
> > are
> > >> >> still
> > >> >> > > >>>>>> pending:
> > >> >> > > >>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>
> > >> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract
> > >> Classes as
> > >> >> > > >>>> POJOs
> > >> >> > > >>>>>>>>>>>
> > >> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API
> > operators
> > >> >> > > >>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>
> > >> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just
> > updated
> > >> it.
> > >> >> > > >>>> Should
> > >> >> > > >>>>>> we
> > >> >> > > >>>>>>>> wait
> > >> >> > > >>>>>>>>>>> for it?
> > >> >> > > >>>>>>>>>>>
> > >> >> > > >>>>>>>>>>> Cheers,
> > >> >> > > >>>>>>>>>>>
> > >> >> > > >>>>>>>>>>> Marton
> > >> >> > > >>>>>>>>>>>
> > >> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <
> > >> >> uce@apache.org
> > >> >> > >
> > >> >> > > >>>>>> wrote:
> > >> >> > > >>>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
> > >> >> > > >>>>> sewen@apache.org>
> > >> >> > > >>>>>>>>>> wrote:
> > >> >> > > >>>>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>>> ----------------------------------------------
> > >> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
> > >> >> > > >>>>>>>>>>>>> ----------------------------------------------
> > >> >> > > >>>>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers
> > splits
> > >> with
> > >> >> > > >>>>> less
> > >> >> > > >>>>>>>>>> degrees
> > >> >> > > >>>>>>>>>>> of
> > >> >> > > >>>>>>>>>>>>> freedom
> > >> >> > > >>>>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for
> > HadoopInputWrapper
> > >> and
> > >> >> > > >>>>>>>>>> NullWritable
> > >> >> > > >>>>>>>>>>>>> support
> > >> >> > > >>>>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new
> Tuple
> > >> APIs +
> > >> >> > > >>>> fix
> > >> >> > > >>>>>> of
> > >> >> > > >>>>>>>>>>>>> ExecutionEnvironment
> > >> >> > > >>>>>>>>>>>>> (this is partially merged, there are a few POM
> > entries
> > >> >> > > >>>>> missing
> > >> >> > > >>>>>>>> for
> > >> >> > > >>>>>>>>>>>> Hadoop 1
> > >> >> > > >>>>>>>>>>>>> support)
> > >> >> > > >>>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>> The first two PRs are still open. I will have a
> > look at
> > >> >> them
> > >> >> > > >>>> as
> > >> >> > > >>>>>>>> well
> > >> >> > > >>>>>>>>>>>> (Robert already tested one).
> > >> >> > > >>>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>> @Robert:
> > >> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749
> > >> ("Enable
> > >> >> > > >>>>>>>> flink-hbase
> > >> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
> > >> >> > > >>>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>>
> > >> >> > > >>>>>>>>>>>> It would be nice if had a look at the remaining
> > >> important
> > >> >> > > >>>> ones
> > >> >> > > >>>>>>>> today.
> > >> >> > > >>>>>>>>>> :-)
> > >> >> > > >>
> > >> >> > >
> > >> >> >
> > >> >>
> > >>
> >
>
Re: Forking off the 0.8 release branch.
Posted by Márton Balassi <ba...@gmail.com>.
Happy new year Flinkers,
I'm sorry that I could not report any progress on the release yet. It was
finally clarified that we are actually blocked by the apache infrastructure
at the moment. [1]
[1] https://issues.apache.org/jira/browse/INFRA-8954
Marton
On Fri, Dec 19, 2014 at 11:00 PM, Henry Saputra <he...@gmail.com>
wrote:
> Thanks for the update Marton.
>
> So with we are graduating it is coming as blessing but unfortunately
> adding more work to the release process.
>
> Please do let us know if you need any help with the release.
>
> - Henry
>
> On Fri, Dec 19, 2014 at 12:38 PM, Márton Balassi
> <ba...@gmail.com> wrote:
> > +1 on quickstart, I'm having a look at it tomorrow.
> >
> > Robert also pointed out the the DISCLAIMER file (for incubation,
> currently
> > also added to the distribution) is no longer needed neither on the master
> > nor on the release branch. Other minor things in the repo regarding the
> > graduation:
> >
> > * Eliminating the incubating subscript from the project version
> > * Updating the the docs (mostly mentioned in variables, sometimes in
> > since given version that should not be changed)
> > * Updating the quickstart scripts (more related to simply releasing)
> >
> > I'm deleting the DISCLAIMER from the repo and the assemblies, bumping the
> > version and updating the parts of the docs that can be done prior to the
> > release.
> >
> > As for the state of the relese: With the help of Robert I have acquired
> the
> > necessary knowledge and set up the tools needed for the release. I have
> > still minor issues with maven, but I'm confident that the solution is
> near.
> > I also fell motivated to write down my experiences in a documentation to
> > spare some time for up and coming release managers.
> >
> > Best,
> >
> > Marton
> >
> > On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <al...@apache.org>
> > wrote:
> >>
> >> +1
> >>
> >> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <rm...@apache.org>
> >> wrote:
> >> > Hi guys,
> >> >
> >> > I vote to make this issue a release blocker:
> >> > https://issues.apache.org/jira/browse/FLINK-1225
> >> > Two users ran into the issue within 2 days. The quickstart is mean to
> >> give
> >> > new users a good experience.
> >> >
> >> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <se...@apache.org>
> wrote:
> >> >>
> >> >> Hi!
> >> >>
> >> >> I forked a branch "release-0.8" and bumped the master version to
> >> >> "0.9-incubating-SNAPSHOT".
> >> >>
> >> >> The closure cleaner is merged. Robert has opened a PR for Kryo - I
> would
> >> >> suggest to merge that to "master", cherry-pick to "release-0.8" and
> >> then:
> >> >> Merry releasing!
> >> >>
> >> >> Greetings,
> >> >> Stephan
> >> >>
> >> >>
> >> >>
> >> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
> >> balassi.marton@gmail.com>
> >> >> wrote:
> >> >> >
> >> >> > @Timo&Stephan: The streaming code uses this since last week [1],
> Timo
> >> >> > starting working on the issue prior way before that - so it also
> has
> >> to
> >> >> do
> >> >> > with the streaming team pushing last minute features to be
> honest...
> >> >> >
> >> >> > Then are we waiting for the Java Clousure cleaner and the Kyro
> >> support, I
> >> >> > guess.
> >> >> > Aljoscha has already issued a PR for the former, some additional
> >> testing
> >> >> is
> >> >> > needed from the looks of it. [2]
> >> >> >
> >> >> > [1]
> >> >> >
> >> >> >
> >> >>
> >>
> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
> >> >> > [2] https://github.com/apache/incubator-flink/pull/269
> >> >> >
> >> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <fl...@twalthr.com>
> >> wrote:
> >> >> > >
> >> >> > > Yes, I also think so. Stability is more important.
> >> >> > >
> >> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <sewen@apache.org
> >:
> >> >> > > >
> >> >> > > > Yes, the fact that we both did not realize that until now sort
> of
> >> >> > reveals
> >> >> > > > that there are more implications than anticipated. That is
> never
> >> good
> >> >> > for
> >> >> > > > "last minute" patches.
> >> >> > > >
> >> >> > > > That's why I would like to merge it into 0.8.1 and 0.9, rather
> >> than
> >> >> > 0.8.0
> >> >> > > > That gives the code a bit more testing/use and us a bit more
> time
> >> to
> >> >> > > > thoroughly think the implications through.
> >> >> > > >
> >> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <
> flink@twalthr.com
> >> >
> >> >> > > wrote:
> >> >> > > >>
> >> >> > > >> Sorry I totally forgot to check the streaming API. Do they use
> >> the
> >> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
> >> >> > > >>
> >> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
> >> rmetzger@apache.org
> >> >> >:
> >> >> > > >>>
> >> >> > > >>> I've worked on adding Kryo support to Flink today. I would
> >> really
> >> >> > like
> >> >> > > to
> >> >> > > >>> include this into the release. Many users were complaining
> about
> >> >> > this (
> >> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
> >> >> > > >>>
> >> >> > > >>> I've based my work on top of Timo's pull request. If we're
> not
> >> >> going
> >> >> > to
> >> >> > > >>> merge it, I will have to rebase my code to the current
> master.
> >> ...
> >> >> > I'll
> >> >> > > >> try
> >> >> > > >>> and see if its easily doable.
> >> >> > > >>>
> >> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
> >> sewen@apache.org>
> >> >> > > wrote:
> >> >> > > >>>>
> >> >> > > >>>> Yes, one thing I just realized is that the streaming API is
> not
> >> >> > aware
> >> >> > > of
> >> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
> >> >> > > >>>>
> >> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
> >> >> fhueske@gmail.com>
> >> >> > > >> wrote:
> >> >> > > >>>>>
> >> >> > > >>>>> +1 for stability first
> >> >> > > >>>>>
> >> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <sewen@apache.org
> >:
> >> >> > > >>>>>>
> >> >> > > >>>>>> I am currently working through the type hints pull
> request...
> >> >> > > >>>>>>
> >> >> > > >>>>>> Right now, I actually think that we should postpone this
> for
> >> the
> >> >> > > next
> >> >> > > >>>>>> bugfix release.
> >> >> > > >>>>>>
> >> >> > > >>>>>> This pull request changes actually some tricky mechanisms
> in
> >> the
> >> >> > > Java
> >> >> > > >>>> API
> >> >> > > >>>>>> (it delays the type information), which may have
> implications
> >> >> that
> >> >> > > me
> >> >> > > >>>> and
> >> >> > > >>>>>> Timo have not fully caught now.
> >> >> > > >>>>>>
> >> >> > > >>>>>> I don't feel Merging this last minute - this is prone to
> >> >> introduce
> >> >> > > >>>>> errors.
> >> >> > > >>>>>>
> >> >> > > >>>>>> Any opinions on that?
> >> >> > > >>>>>>
> >> >> > > >>>>>>
> >> >> > > >>>>>>
> >> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
> >> sewen@apache.org
> >> >> >
> >> >> > > >>>> wrote:
> >> >> > > >>>>>>>
> >> >> > > >>>>>>> +1 for adding the closure cleaner...
> >> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
> >> >> > > aljoscha@apache.org
> >> >> > > >>>>> :
> >> >> > > >>>>>>>
> >> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
> >> >> > > >>>>>>>>
> >> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> >> >> > > >>>>>>>> <ba...@gmail.com> wrote:
> >> >> > > >>>>>>>>> Cool, thanks.
> >> >> > > >>>>>>>>>
> >> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
> >> >> > sewen@apache.org
> >> >> > > >
> >> >> > > >>>>>>>> wrote:
> >> >> > > >>>>>>>>>>
> >> >> > > >>>>>>>>>> Hi!
> >> >> > > >>>>>>>>>>
> >> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made some final
> >> >> > adjustments
> >> >> > > >>>>>>>> yesterday
> >> >> > > >>>>>>>>>> evening. I'll review and merge it now, then we can
> fork
> >> the
> >> >> > > >>>> branch.
> >> >> > > >>>>>>>>>>
> >> >> > > >>>>>>>>>> Cheers,
> >> >> > > >>>>>>>>>> Stephan
> >> >> > > >>>>>>>>>>
> >> >> > > >>>>>>>>>>
> >> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> >> >> > > >>>>>>>> balassi.marton@gmail.com
> >> >> > > >>>>>>>>>> wrote:
> >> >> > > >>>>>>>>>>>
> >> >> > > >>>>>>>>>>> Hey,
> >> >> > > >>>>>>>>>>>
> >> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems every
> import
> >> >> one
> >> >> > > >>>> has
> >> >> > > >>>>>> been
> >> >> > > >>>>>>>>>>> merged. As for the optional ones the following two
> are
> >> >> still
> >> >> > > >>>>>> pending:
> >> >> > > >>>>>>>>>>>
> >> >> > > >>>>>>>>>>>
> >> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract
> >> Classes as
> >> >> > > >>>> POJOs
> >> >> > > >>>>>>>>>>>
> >> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API
> operators
> >> >> > > >>>>>>>>>>>
> >> >> > > >>>>>>>>>>>
> >> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just
> updated
> >> it.
> >> >> > > >>>> Should
> >> >> > > >>>>>> we
> >> >> > > >>>>>>>> wait
> >> >> > > >>>>>>>>>>> for it?
> >> >> > > >>>>>>>>>>>
> >> >> > > >>>>>>>>>>> Cheers,
> >> >> > > >>>>>>>>>>>
> >> >> > > >>>>>>>>>>> Marton
> >> >> > > >>>>>>>>>>>
> >> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <
> >> >> uce@apache.org
> >> >> > >
> >> >> > > >>>>>> wrote:
> >> >> > > >>>>>>>>>>>>
> >> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
> >> >> > > >>>>> sewen@apache.org>
> >> >> > > >>>>>>>>>> wrote:
> >> >> > > >>>>>>>>>>>>>
> >> >> > > >>>>>>>>>>>>> ----------------------------------------------
> >> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
> >> >> > > >>>>>>>>>>>>> ----------------------------------------------
> >> >> > > >>>>>>>>>>>>>
> >> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers
> splits
> >> with
> >> >> > > >>>>> less
> >> >> > > >>>>>>>>>> degrees
> >> >> > > >>>>>>>>>>> of
> >> >> > > >>>>>>>>>>>>> freedom
> >> >> > > >>>>>>>>>>>>>
> >> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for
> HadoopInputWrapper
> >> and
> >> >> > > >>>>>>>>>> NullWritable
> >> >> > > >>>>>>>>>>>>> support
> >> >> > > >>>>>>>>>>>>>
> >> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple
> >> APIs +
> >> >> > > >>>> fix
> >> >> > > >>>>>> of
> >> >> > > >>>>>>>>>>>>> ExecutionEnvironment
> >> >> > > >>>>>>>>>>>>> (this is partially merged, there are a few POM
> entries
> >> >> > > >>>>> missing
> >> >> > > >>>>>>>> for
> >> >> > > >>>>>>>>>>>> Hadoop 1
> >> >> > > >>>>>>>>>>>>> support)
> >> >> > > >>>>>>>>>>>>
> >> >> > > >>>>>>>>>>>> The first two PRs are still open. I will have a
> look at
> >> >> them
> >> >> > > >>>> as
> >> >> > > >>>>>>>> well
> >> >> > > >>>>>>>>>>>> (Robert already tested one).
> >> >> > > >>>>>>>>>>>>
> >> >> > > >>>>>>>>>>>> @Robert:
> >> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749
> >> ("Enable
> >> >> > > >>>>>>>> flink-hbase
> >> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
> >> >> > > >>>>>>>>>>>>
> >> >> > > >>>>>>>>>>>>
> >> >> > > >>>>>>>>>>>> It would be nice if had a look at the remaining
> >> important
> >> >> > > >>>> ones
> >> >> > > >>>>>>>> today.
> >> >> > > >>>>>>>>>> :-)
> >> >> > > >>
> >> >> > >
> >> >> >
> >> >>
> >>
>
Re: Forking off the 0.8 release branch.
Posted by Henry Saputra <he...@gmail.com>.
Thanks for the update Marton.
So with we are graduating it is coming as blessing but unfortunately
adding more work to the release process.
Please do let us know if you need any help with the release.
- Henry
On Fri, Dec 19, 2014 at 12:38 PM, Márton Balassi
<ba...@gmail.com> wrote:
> +1 on quickstart, I'm having a look at it tomorrow.
>
> Robert also pointed out the the DISCLAIMER file (for incubation, currently
> also added to the distribution) is no longer needed neither on the master
> nor on the release branch. Other minor things in the repo regarding the
> graduation:
>
> * Eliminating the incubating subscript from the project version
> * Updating the the docs (mostly mentioned in variables, sometimes in
> since given version that should not be changed)
> * Updating the quickstart scripts (more related to simply releasing)
>
> I'm deleting the DISCLAIMER from the repo and the assemblies, bumping the
> version and updating the parts of the docs that can be done prior to the
> release.
>
> As for the state of the relese: With the help of Robert I have acquired the
> necessary knowledge and set up the tools needed for the release. I have
> still minor issues with maven, but I'm confident that the solution is near.
> I also fell motivated to write down my experiences in a documentation to
> spare some time for up and coming release managers.
>
> Best,
>
> Marton
>
> On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <al...@apache.org>
> wrote:
>>
>> +1
>>
>> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <rm...@apache.org>
>> wrote:
>> > Hi guys,
>> >
>> > I vote to make this issue a release blocker:
>> > https://issues.apache.org/jira/browse/FLINK-1225
>> > Two users ran into the issue within 2 days. The quickstart is mean to
>> give
>> > new users a good experience.
>> >
>> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <se...@apache.org> wrote:
>> >>
>> >> Hi!
>> >>
>> >> I forked a branch "release-0.8" and bumped the master version to
>> >> "0.9-incubating-SNAPSHOT".
>> >>
>> >> The closure cleaner is merged. Robert has opened a PR for Kryo - I would
>> >> suggest to merge that to "master", cherry-pick to "release-0.8" and
>> then:
>> >> Merry releasing!
>> >>
>> >> Greetings,
>> >> Stephan
>> >>
>> >>
>> >>
>> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
>> balassi.marton@gmail.com>
>> >> wrote:
>> >> >
>> >> > @Timo&Stephan: The streaming code uses this since last week [1], Timo
>> >> > starting working on the issue prior way before that - so it also has
>> to
>> >> do
>> >> > with the streaming team pushing last minute features to be honest...
>> >> >
>> >> > Then are we waiting for the Java Clousure cleaner and the Kyro
>> support, I
>> >> > guess.
>> >> > Aljoscha has already issued a PR for the former, some additional
>> testing
>> >> is
>> >> > needed from the looks of it. [2]
>> >> >
>> >> > [1]
>> >> >
>> >> >
>> >>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
>> >> > [2] https://github.com/apache/incubator-flink/pull/269
>> >> >
>> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <fl...@twalthr.com>
>> wrote:
>> >> > >
>> >> > > Yes, I also think so. Stability is more important.
>> >> > >
>> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <se...@apache.org>:
>> >> > > >
>> >> > > > Yes, the fact that we both did not realize that until now sort of
>> >> > reveals
>> >> > > > that there are more implications than anticipated. That is never
>> good
>> >> > for
>> >> > > > "last minute" patches.
>> >> > > >
>> >> > > > That's why I would like to merge it into 0.8.1 and 0.9, rather
>> than
>> >> > 0.8.0
>> >> > > > That gives the code a bit more testing/use and us a bit more time
>> to
>> >> > > > thoroughly think the implications through.
>> >> > > >
>> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <flink@twalthr.com
>> >
>> >> > > wrote:
>> >> > > >>
>> >> > > >> Sorry I totally forgot to check the streaming API. Do they use
>> the
>> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
>> >> > > >>
>> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
>> rmetzger@apache.org
>> >> >:
>> >> > > >>>
>> >> > > >>> I've worked on adding Kryo support to Flink today. I would
>> really
>> >> > like
>> >> > > to
>> >> > > >>> include this into the release. Many users were complaining about
>> >> > this (
>> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
>> >> > > >>>
>> >> > > >>> I've based my work on top of Timo's pull request. If we're not
>> >> going
>> >> > to
>> >> > > >>> merge it, I will have to rebase my code to the current master.
>> ...
>> >> > I'll
>> >> > > >> try
>> >> > > >>> and see if its easily doable.
>> >> > > >>>
>> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
>> sewen@apache.org>
>> >> > > wrote:
>> >> > > >>>>
>> >> > > >>>> Yes, one thing I just realized is that the streaming API is not
>> >> > aware
>> >> > > of
>> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
>> >> > > >>>>
>> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
>> >> fhueske@gmail.com>
>> >> > > >> wrote:
>> >> > > >>>>>
>> >> > > >>>>> +1 for stability first
>> >> > > >>>>>
>> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
>> >> > > >>>>>>
>> >> > > >>>>>> I am currently working through the type hints pull request...
>> >> > > >>>>>>
>> >> > > >>>>>> Right now, I actually think that we should postpone this for
>> the
>> >> > > next
>> >> > > >>>>>> bugfix release.
>> >> > > >>>>>>
>> >> > > >>>>>> This pull request changes actually some tricky mechanisms in
>> the
>> >> > > Java
>> >> > > >>>> API
>> >> > > >>>>>> (it delays the type information), which may have implications
>> >> that
>> >> > > me
>> >> > > >>>> and
>> >> > > >>>>>> Timo have not fully caught now.
>> >> > > >>>>>>
>> >> > > >>>>>> I don't feel Merging this last minute - this is prone to
>> >> introduce
>> >> > > >>>>> errors.
>> >> > > >>>>>>
>> >> > > >>>>>> Any opinions on that?
>> >> > > >>>>>>
>> >> > > >>>>>>
>> >> > > >>>>>>
>> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
>> sewen@apache.org
>> >> >
>> >> > > >>>> wrote:
>> >> > > >>>>>>>
>> >> > > >>>>>>> +1 for adding the closure cleaner...
>> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
>> >> > > aljoscha@apache.org
>> >> > > >>>>> :
>> >> > > >>>>>>>
>> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
>> >> > > >>>>>>>>
>> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
>> >> > > >>>>>>>> <ba...@gmail.com> wrote:
>> >> > > >>>>>>>>> Cool, thanks.
>> >> > > >>>>>>>>>
>> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
>> >> > sewen@apache.org
>> >> > > >
>> >> > > >>>>>>>> wrote:
>> >> > > >>>>>>>>>>
>> >> > > >>>>>>>>>> Hi!
>> >> > > >>>>>>>>>>
>> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made some final
>> >> > adjustments
>> >> > > >>>>>>>> yesterday
>> >> > > >>>>>>>>>> evening. I'll review and merge it now, then we can fork
>> the
>> >> > > >>>> branch.
>> >> > > >>>>>>>>>>
>> >> > > >>>>>>>>>> Cheers,
>> >> > > >>>>>>>>>> Stephan
>> >> > > >>>>>>>>>>
>> >> > > >>>>>>>>>>
>> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
>> >> > > >>>>>>>> balassi.marton@gmail.com
>> >> > > >>>>>>>>>> wrote:
>> >> > > >>>>>>>>>>>
>> >> > > >>>>>>>>>>> Hey,
>> >> > > >>>>>>>>>>>
>> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems every import
>> >> one
>> >> > > >>>> has
>> >> > > >>>>>> been
>> >> > > >>>>>>>>>>> merged. As for the optional ones the following two are
>> >> still
>> >> > > >>>>>> pending:
>> >> > > >>>>>>>>>>>
>> >> > > >>>>>>>>>>>
>> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract
>> Classes as
>> >> > > >>>> POJOs
>> >> > > >>>>>>>>>>>
>> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API operators
>> >> > > >>>>>>>>>>>
>> >> > > >>>>>>>>>>>
>> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just updated
>> it.
>> >> > > >>>> Should
>> >> > > >>>>>> we
>> >> > > >>>>>>>> wait
>> >> > > >>>>>>>>>>> for it?
>> >> > > >>>>>>>>>>>
>> >> > > >>>>>>>>>>> Cheers,
>> >> > > >>>>>>>>>>>
>> >> > > >>>>>>>>>>> Marton
>> >> > > >>>>>>>>>>>
>> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <
>> >> uce@apache.org
>> >> > >
>> >> > > >>>>>> wrote:
>> >> > > >>>>>>>>>>>>
>> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
>> >> > > >>>>> sewen@apache.org>
>> >> > > >>>>>>>>>> wrote:
>> >> > > >>>>>>>>>>>>>
>> >> > > >>>>>>>>>>>>> ----------------------------------------------
>> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
>> >> > > >>>>>>>>>>>>> ----------------------------------------------
>> >> > > >>>>>>>>>>>>>
>> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers splits
>> with
>> >> > > >>>>> less
>> >> > > >>>>>>>>>> degrees
>> >> > > >>>>>>>>>>> of
>> >> > > >>>>>>>>>>>>> freedom
>> >> > > >>>>>>>>>>>>>
>> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper
>> and
>> >> > > >>>>>>>>>> NullWritable
>> >> > > >>>>>>>>>>>>> support
>> >> > > >>>>>>>>>>>>>
>> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple
>> APIs +
>> >> > > >>>> fix
>> >> > > >>>>>> of
>> >> > > >>>>>>>>>>>>> ExecutionEnvironment
>> >> > > >>>>>>>>>>>>> (this is partially merged, there are a few POM entries
>> >> > > >>>>> missing
>> >> > > >>>>>>>> for
>> >> > > >>>>>>>>>>>> Hadoop 1
>> >> > > >>>>>>>>>>>>> support)
>> >> > > >>>>>>>>>>>>
>> >> > > >>>>>>>>>>>> The first two PRs are still open. I will have a look at
>> >> them
>> >> > > >>>> as
>> >> > > >>>>>>>> well
>> >> > > >>>>>>>>>>>> (Robert already tested one).
>> >> > > >>>>>>>>>>>>
>> >> > > >>>>>>>>>>>> @Robert:
>> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749
>> ("Enable
>> >> > > >>>>>>>> flink-hbase
>> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
>> >> > > >>>>>>>>>>>>
>> >> > > >>>>>>>>>>>>
>> >> > > >>>>>>>>>>>> It would be nice if had a look at the remaining
>> important
>> >> > > >>>> ones
>> >> > > >>>>>>>> today.
>> >> > > >>>>>>>>>> :-)
>> >> > > >>
>> >> > >
>> >> >
>> >>
>>
Re: Forking off the 0.8 release branch.
Posted by Márton Balassi <ba...@gmail.com>.
+1 on quickstart, I'm having a look at it tomorrow.
Robert also pointed out the the DISCLAIMER file (for incubation, currently
also added to the distribution) is no longer needed neither on the master
nor on the release branch. Other minor things in the repo regarding the
graduation:
* Eliminating the incubating subscript from the project version
* Updating the the docs (mostly mentioned in variables, sometimes in
since given version that should not be changed)
* Updating the quickstart scripts (more related to simply releasing)
I'm deleting the DISCLAIMER from the repo and the assemblies, bumping the
version and updating the parts of the docs that can be done prior to the
release.
As for the state of the relese: With the help of Robert I have acquired the
necessary knowledge and set up the tools needed for the release. I have
still minor issues with maven, but I'm confident that the solution is near.
I also fell motivated to write down my experiences in a documentation to
spare some time for up and coming release managers.
Best,
Marton
On Fri, Dec 19, 2014 at 9:13 PM, Aljoscha Krettek <al...@apache.org>
wrote:
>
> +1
>
> On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <rm...@apache.org>
> wrote:
> > Hi guys,
> >
> > I vote to make this issue a release blocker:
> > https://issues.apache.org/jira/browse/FLINK-1225
> > Two users ran into the issue within 2 days. The quickstart is mean to
> give
> > new users a good experience.
> >
> > On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <se...@apache.org> wrote:
> >>
> >> Hi!
> >>
> >> I forked a branch "release-0.8" and bumped the master version to
> >> "0.9-incubating-SNAPSHOT".
> >>
> >> The closure cleaner is merged. Robert has opened a PR for Kryo - I would
> >> suggest to merge that to "master", cherry-pick to "release-0.8" and
> then:
> >> Merry releasing!
> >>
> >> Greetings,
> >> Stephan
> >>
> >>
> >>
> >> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <
> balassi.marton@gmail.com>
> >> wrote:
> >> >
> >> > @Timo&Stephan: The streaming code uses this since last week [1], Timo
> >> > starting working on the issue prior way before that - so it also has
> to
> >> do
> >> > with the streaming team pushing last minute features to be honest...
> >> >
> >> > Then are we waiting for the Java Clousure cleaner and the Kyro
> support, I
> >> > guess.
> >> > Aljoscha has already issued a PR for the former, some additional
> testing
> >> is
> >> > needed from the looks of it. [2]
> >> >
> >> > [1]
> >> >
> >> >
> >>
> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
> >> > [2] https://github.com/apache/incubator-flink/pull/269
> >> >
> >> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <fl...@twalthr.com>
> wrote:
> >> > >
> >> > > Yes, I also think so. Stability is more important.
> >> > >
> >> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <se...@apache.org>:
> >> > > >
> >> > > > Yes, the fact that we both did not realize that until now sort of
> >> > reveals
> >> > > > that there are more implications than anticipated. That is never
> good
> >> > for
> >> > > > "last minute" patches.
> >> > > >
> >> > > > That's why I would like to merge it into 0.8.1 and 0.9, rather
> than
> >> > 0.8.0
> >> > > > That gives the code a bit more testing/use and us a bit more time
> to
> >> > > > thoroughly think the implications through.
> >> > > >
> >> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <flink@twalthr.com
> >
> >> > > wrote:
> >> > > >>
> >> > > >> Sorry I totally forgot to check the streaming API. Do they use
> the
> >> > > >> getXXXReturnTypes() methods of the TypeExtractor?
> >> > > >>
> >> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <
> rmetzger@apache.org
> >> >:
> >> > > >>>
> >> > > >>> I've worked on adding Kryo support to Flink today. I would
> really
> >> > like
> >> > > to
> >> > > >>> include this into the release. Many users were complaining about
> >> > this (
> >> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
> >> > > >>>
> >> > > >>> I've based my work on top of Timo's pull request. If we're not
> >> going
> >> > to
> >> > > >>> merge it, I will have to rebase my code to the current master.
> ...
> >> > I'll
> >> > > >> try
> >> > > >>> and see if its easily doable.
> >> > > >>>
> >> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <
> sewen@apache.org>
> >> > > wrote:
> >> > > >>>>
> >> > > >>>> Yes, one thing I just realized is that the streaming API is not
> >> > aware
> >> > > of
> >> > > >>>> MissingTypeInfos and it may cause weird behavior.
> >> > > >>>>
> >> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
> >> fhueske@gmail.com>
> >> > > >> wrote:
> >> > > >>>>>
> >> > > >>>>> +1 for stability first
> >> > > >>>>>
> >> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
> >> > > >>>>>>
> >> > > >>>>>> I am currently working through the type hints pull request...
> >> > > >>>>>>
> >> > > >>>>>> Right now, I actually think that we should postpone this for
> the
> >> > > next
> >> > > >>>>>> bugfix release.
> >> > > >>>>>>
> >> > > >>>>>> This pull request changes actually some tricky mechanisms in
> the
> >> > > Java
> >> > > >>>> API
> >> > > >>>>>> (it delays the type information), which may have implications
> >> that
> >> > > me
> >> > > >>>> and
> >> > > >>>>>> Timo have not fully caught now.
> >> > > >>>>>>
> >> > > >>>>>> I don't feel Merging this last minute - this is prone to
> >> introduce
> >> > > >>>>> errors.
> >> > > >>>>>>
> >> > > >>>>>> Any opinions on that?
> >> > > >>>>>>
> >> > > >>>>>>
> >> > > >>>>>>
> >> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <
> sewen@apache.org
> >> >
> >> > > >>>> wrote:
> >> > > >>>>>>>
> >> > > >>>>>>> +1 for adding the closure cleaner...
> >> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
> >> > > aljoscha@apache.org
> >> > > >>>>> :
> >> > > >>>>>>>
> >> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
> >> > > >>>>>>>>
> >> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> >> > > >>>>>>>> <ba...@gmail.com> wrote:
> >> > > >>>>>>>>> Cool, thanks.
> >> > > >>>>>>>>>
> >> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
> >> > sewen@apache.org
> >> > > >
> >> > > >>>>>>>> wrote:
> >> > > >>>>>>>>>>
> >> > > >>>>>>>>>> Hi!
> >> > > >>>>>>>>>>
> >> > > >>>>>>>>>> The type hints PR is ready now, Timo made some final
> >> > adjustments
> >> > > >>>>>>>> yesterday
> >> > > >>>>>>>>>> evening. I'll review and merge it now, then we can fork
> the
> >> > > >>>> branch.
> >> > > >>>>>>>>>>
> >> > > >>>>>>>>>> Cheers,
> >> > > >>>>>>>>>> Stephan
> >> > > >>>>>>>>>>
> >> > > >>>>>>>>>>
> >> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> >> > > >>>>>>>> balassi.marton@gmail.com
> >> > > >>>>>>>>>> wrote:
> >> > > >>>>>>>>>>>
> >> > > >>>>>>>>>>> Hey,
> >> > > >>>>>>>>>>>
> >> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems every import
> >> one
> >> > > >>>> has
> >> > > >>>>>> been
> >> > > >>>>>>>>>>> merged. As for the optional ones the following two are
> >> still
> >> > > >>>>>> pending:
> >> > > >>>>>>>>>>>
> >> > > >>>>>>>>>>>
> >> > > >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract
> Classes as
> >> > > >>>> POJOs
> >> > > >>>>>>>>>>>
> >> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API operators
> >> > > >>>>>>>>>>>
> >> > > >>>>>>>>>>>
> >> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just updated
> it.
> >> > > >>>> Should
> >> > > >>>>>> we
> >> > > >>>>>>>> wait
> >> > > >>>>>>>>>>> for it?
> >> > > >>>>>>>>>>>
> >> > > >>>>>>>>>>> Cheers,
> >> > > >>>>>>>>>>>
> >> > > >>>>>>>>>>> Marton
> >> > > >>>>>>>>>>>
> >> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <
> >> uce@apache.org
> >> > >
> >> > > >>>>>> wrote:
> >> > > >>>>>>>>>>>>
> >> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
> >> > > >>>>> sewen@apache.org>
> >> > > >>>>>>>>>> wrote:
> >> > > >>>>>>>>>>>>>
> >> > > >>>>>>>>>>>>> ----------------------------------------------
> >> > > >>>>>>>>>>>>> Important Pull Requests to merge:
> >> > > >>>>>>>>>>>>> ----------------------------------------------
> >> > > >>>>>>>>>>>>>
> >> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers splits
> with
> >> > > >>>>> less
> >> > > >>>>>>>>>> degrees
> >> > > >>>>>>>>>>> of
> >> > > >>>>>>>>>>>>> freedom
> >> > > >>>>>>>>>>>>>
> >> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper
> and
> >> > > >>>>>>>>>> NullWritable
> >> > > >>>>>>>>>>>>> support
> >> > > >>>>>>>>>>>>>
> >> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple
> APIs +
> >> > > >>>> fix
> >> > > >>>>>> of
> >> > > >>>>>>>>>>>>> ExecutionEnvironment
> >> > > >>>>>>>>>>>>> (this is partially merged, there are a few POM entries
> >> > > >>>>> missing
> >> > > >>>>>>>> for
> >> > > >>>>>>>>>>>> Hadoop 1
> >> > > >>>>>>>>>>>>> support)
> >> > > >>>>>>>>>>>>
> >> > > >>>>>>>>>>>> The first two PRs are still open. I will have a look at
> >> them
> >> > > >>>> as
> >> > > >>>>>>>> well
> >> > > >>>>>>>>>>>> (Robert already tested one).
> >> > > >>>>>>>>>>>>
> >> > > >>>>>>>>>>>> @Robert:
> >> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749
> ("Enable
> >> > > >>>>>>>> flink-hbase
> >> > > >>>>>>>>>>>> module for hadoop1 build as well")?
> >> > > >>>>>>>>>>>>
> >> > > >>>>>>>>>>>>
> >> > > >>>>>>>>>>>> It would be nice if had a look at the remaining
> important
> >> > > >>>> ones
> >> > > >>>>>>>> today.
> >> > > >>>>>>>>>> :-)
> >> > > >>
> >> > >
> >> >
> >>
>
Re: Forking off the 0.8 release branch.
Posted by Aljoscha Krettek <al...@apache.org>.
+1
On Fri, Dec 19, 2014 at 8:45 PM, Robert Metzger <rm...@apache.org> wrote:
> Hi guys,
>
> I vote to make this issue a release blocker:
> https://issues.apache.org/jira/browse/FLINK-1225
> Two users ran into the issue within 2 days. The quickstart is mean to give
> new users a good experience.
>
> On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <se...@apache.org> wrote:
>>
>> Hi!
>>
>> I forked a branch "release-0.8" and bumped the master version to
>> "0.9-incubating-SNAPSHOT".
>>
>> The closure cleaner is merged. Robert has opened a PR for Kryo - I would
>> suggest to merge that to "master", cherry-pick to "release-0.8" and then:
>> Merry releasing!
>>
>> Greetings,
>> Stephan
>>
>>
>>
>> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <ba...@gmail.com>
>> wrote:
>> >
>> > @Timo&Stephan: The streaming code uses this since last week [1], Timo
>> > starting working on the issue prior way before that - so it also has to
>> do
>> > with the streaming team pushing last minute features to be honest...
>> >
>> > Then are we waiting for the Java Clousure cleaner and the Kyro support, I
>> > guess.
>> > Aljoscha has already issued a PR for the former, some additional testing
>> is
>> > needed from the looks of it. [2]
>> >
>> > [1]
>> >
>> >
>> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
>> > [2] https://github.com/apache/incubator-flink/pull/269
>> >
>> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <fl...@twalthr.com> wrote:
>> > >
>> > > Yes, I also think so. Stability is more important.
>> > >
>> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <se...@apache.org>:
>> > > >
>> > > > Yes, the fact that we both did not realize that until now sort of
>> > reveals
>> > > > that there are more implications than anticipated. That is never good
>> > for
>> > > > "last minute" patches.
>> > > >
>> > > > That's why I would like to merge it into 0.8.1 and 0.9, rather than
>> > 0.8.0
>> > > > That gives the code a bit more testing/use and us a bit more time to
>> > > > thoroughly think the implications through.
>> > > >
>> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <fl...@twalthr.com>
>> > > wrote:
>> > > >>
>> > > >> Sorry I totally forgot to check the streaming API. Do they use the
>> > > >> getXXXReturnTypes() methods of the TypeExtractor?
>> > > >>
>> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <rmetzger@apache.org
>> >:
>> > > >>>
>> > > >>> I've worked on adding Kryo support to Flink today. I would really
>> > like
>> > > to
>> > > >>> include this into the release. Many users were complaining about
>> > this (
>> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
>> > > >>>
>> > > >>> I've based my work on top of Timo's pull request. If we're not
>> going
>> > to
>> > > >>> merge it, I will have to rebase my code to the current master. ...
>> > I'll
>> > > >> try
>> > > >>> and see if its easily doable.
>> > > >>>
>> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <se...@apache.org>
>> > > wrote:
>> > > >>>>
>> > > >>>> Yes, one thing I just realized is that the streaming API is not
>> > aware
>> > > of
>> > > >>>> MissingTypeInfos and it may cause weird behavior.
>> > > >>>>
>> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
>> fhueske@gmail.com>
>> > > >> wrote:
>> > > >>>>>
>> > > >>>>> +1 for stability first
>> > > >>>>>
>> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
>> > > >>>>>>
>> > > >>>>>> I am currently working through the type hints pull request...
>> > > >>>>>>
>> > > >>>>>> Right now, I actually think that we should postpone this for the
>> > > next
>> > > >>>>>> bugfix release.
>> > > >>>>>>
>> > > >>>>>> This pull request changes actually some tricky mechanisms in the
>> > > Java
>> > > >>>> API
>> > > >>>>>> (it delays the type information), which may have implications
>> that
>> > > me
>> > > >>>> and
>> > > >>>>>> Timo have not fully caught now.
>> > > >>>>>>
>> > > >>>>>> I don't feel Merging this last minute - this is prone to
>> introduce
>> > > >>>>> errors.
>> > > >>>>>>
>> > > >>>>>> Any opinions on that?
>> > > >>>>>>
>> > > >>>>>>
>> > > >>>>>>
>> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <sewen@apache.org
>> >
>> > > >>>> wrote:
>> > > >>>>>>>
>> > > >>>>>>> +1 for adding the closure cleaner...
>> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
>> > > aljoscha@apache.org
>> > > >>>>> :
>> > > >>>>>>>
>> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
>> > > >>>>>>>>
>> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
>> > > >>>>>>>> <ba...@gmail.com> wrote:
>> > > >>>>>>>>> Cool, thanks.
>> > > >>>>>>>>>
>> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
>> > sewen@apache.org
>> > > >
>> > > >>>>>>>> wrote:
>> > > >>>>>>>>>>
>> > > >>>>>>>>>> Hi!
>> > > >>>>>>>>>>
>> > > >>>>>>>>>> The type hints PR is ready now, Timo made some final
>> > adjustments
>> > > >>>>>>>> yesterday
>> > > >>>>>>>>>> evening. I'll review and merge it now, then we can fork the
>> > > >>>> branch.
>> > > >>>>>>>>>>
>> > > >>>>>>>>>> Cheers,
>> > > >>>>>>>>>> Stephan
>> > > >>>>>>>>>>
>> > > >>>>>>>>>>
>> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
>> > > >>>>>>>> balassi.marton@gmail.com
>> > > >>>>>>>>>> wrote:
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>> Hey,
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems every import
>> one
>> > > >>>> has
>> > > >>>>>> been
>> > > >>>>>>>>>>> merged. As for the optional ones the following two are
>> still
>> > > >>>>>> pending:
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract Classes as
>> > > >>>> POJOs
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API operators
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just updated it.
>> > > >>>> Should
>> > > >>>>>> we
>> > > >>>>>>>> wait
>> > > >>>>>>>>>>> for it?
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>> Cheers,
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>> Marton
>> > > >>>>>>>>>>>
>> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <
>> uce@apache.org
>> > >
>> > > >>>>>> wrote:
>> > > >>>>>>>>>>>>
>> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
>> > > >>>>> sewen@apache.org>
>> > > >>>>>>>>>> wrote:
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>> ----------------------------------------------
>> > > >>>>>>>>>>>>> Important Pull Requests to merge:
>> > > >>>>>>>>>>>>> ----------------------------------------------
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers splits with
>> > > >>>>> less
>> > > >>>>>>>>>> degrees
>> > > >>>>>>>>>>> of
>> > > >>>>>>>>>>>>> freedom
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
>> > > >>>>>>>>>> NullWritable
>> > > >>>>>>>>>>>>> support
>> > > >>>>>>>>>>>>>
>> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple APIs +
>> > > >>>> fix
>> > > >>>>>> of
>> > > >>>>>>>>>>>>> ExecutionEnvironment
>> > > >>>>>>>>>>>>> (this is partially merged, there are a few POM entries
>> > > >>>>> missing
>> > > >>>>>>>> for
>> > > >>>>>>>>>>>> Hadoop 1
>> > > >>>>>>>>>>>>> support)
>> > > >>>>>>>>>>>>
>> > > >>>>>>>>>>>> The first two PRs are still open. I will have a look at
>> them
>> > > >>>> as
>> > > >>>>>>>> well
>> > > >>>>>>>>>>>> (Robert already tested one).
>> > > >>>>>>>>>>>>
>> > > >>>>>>>>>>>> @Robert:
>> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
>> > > >>>>>>>> flink-hbase
>> > > >>>>>>>>>>>> module for hadoop1 build as well")?
>> > > >>>>>>>>>>>>
>> > > >>>>>>>>>>>>
>> > > >>>>>>>>>>>> It would be nice if had a look at the remaining important
>> > > >>>> ones
>> > > >>>>>>>> today.
>> > > >>>>>>>>>> :-)
>> > > >>
>> > >
>> >
>>
Re: Forking off the 0.8 release branch.
Posted by Robert Metzger <rm...@apache.org>.
Hi guys,
I vote to make this issue a release blocker:
https://issues.apache.org/jira/browse/FLINK-1225
Two users ran into the issue within 2 days. The quickstart is mean to give
new users a good experience.
On Tue, Dec 16, 2014 at 10:30 PM, Stephan Ewen <se...@apache.org> wrote:
>
> Hi!
>
> I forked a branch "release-0.8" and bumped the master version to
> "0.9-incubating-SNAPSHOT".
>
> The closure cleaner is merged. Robert has opened a PR for Kryo - I would
> suggest to merge that to "master", cherry-pick to "release-0.8" and then:
> Merry releasing!
>
> Greetings,
> Stephan
>
>
>
> On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <ba...@gmail.com>
> wrote:
> >
> > @Timo&Stephan: The streaming code uses this since last week [1], Timo
> > starting working on the issue prior way before that - so it also has to
> do
> > with the streaming team pushing last minute features to be honest...
> >
> > Then are we waiting for the Java Clousure cleaner and the Kyro support, I
> > guess.
> > Aljoscha has already issued a PR for the former, some additional testing
> is
> > needed from the looks of it. [2]
> >
> > [1]
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
> > [2] https://github.com/apache/incubator-flink/pull/269
> >
> > On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <fl...@twalthr.com> wrote:
> > >
> > > Yes, I also think so. Stability is more important.
> > >
> > > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <se...@apache.org>:
> > > >
> > > > Yes, the fact that we both did not realize that until now sort of
> > reveals
> > > > that there are more implications than anticipated. That is never good
> > for
> > > > "last minute" patches.
> > > >
> > > > That's why I would like to merge it into 0.8.1 and 0.9, rather than
> > 0.8.0
> > > > That gives the code a bit more testing/use and us a bit more time to
> > > > thoroughly think the implications through.
> > > >
> > > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <fl...@twalthr.com>
> > > wrote:
> > > >>
> > > >> Sorry I totally forgot to check the streaming API. Do they use the
> > > >> getXXXReturnTypes() methods of the TypeExtractor?
> > > >>
> > > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <rmetzger@apache.org
> >:
> > > >>>
> > > >>> I've worked on adding Kryo support to Flink today. I would really
> > like
> > > to
> > > >>> include this into the release. Many users were complaining about
> > this (
> > > >>> https://issues.apache.org/jira/browse/FLINK-610).
> > > >>>
> > > >>> I've based my work on top of Timo's pull request. If we're not
> going
> > to
> > > >>> merge it, I will have to rebase my code to the current master. ...
> > I'll
> > > >> try
> > > >>> and see if its easily doable.
> > > >>>
> > > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <se...@apache.org>
> > > wrote:
> > > >>>>
> > > >>>> Yes, one thing I just realized is that the streaming API is not
> > aware
> > > of
> > > >>>> MissingTypeInfos and it may cause weird behavior.
> > > >>>>
> > > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <
> fhueske@gmail.com>
> > > >> wrote:
> > > >>>>>
> > > >>>>> +1 for stability first
> > > >>>>>
> > > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
> > > >>>>>>
> > > >>>>>> I am currently working through the type hints pull request...
> > > >>>>>>
> > > >>>>>> Right now, I actually think that we should postpone this for the
> > > next
> > > >>>>>> bugfix release.
> > > >>>>>>
> > > >>>>>> This pull request changes actually some tricky mechanisms in the
> > > Java
> > > >>>> API
> > > >>>>>> (it delays the type information), which may have implications
> that
> > > me
> > > >>>> and
> > > >>>>>> Timo have not fully caught now.
> > > >>>>>>
> > > >>>>>> I don't feel Merging this last minute - this is prone to
> introduce
> > > >>>>> errors.
> > > >>>>>>
> > > >>>>>> Any opinions on that?
> > > >>>>>>
> > > >>>>>>
> > > >>>>>>
> > > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <sewen@apache.org
> >
> > > >>>> wrote:
> > > >>>>>>>
> > > >>>>>>> +1 for adding the closure cleaner...
> > > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
> > > aljoscha@apache.org
> > > >>>>> :
> > > >>>>>>>
> > > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
> > > >>>>>>>>
> > > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> > > >>>>>>>> <ba...@gmail.com> wrote:
> > > >>>>>>>>> Cool, thanks.
> > > >>>>>>>>>
> > > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
> > sewen@apache.org
> > > >
> > > >>>>>>>> wrote:
> > > >>>>>>>>>>
> > > >>>>>>>>>> Hi!
> > > >>>>>>>>>>
> > > >>>>>>>>>> The type hints PR is ready now, Timo made some final
> > adjustments
> > > >>>>>>>> yesterday
> > > >>>>>>>>>> evening. I'll review and merge it now, then we can fork the
> > > >>>> branch.
> > > >>>>>>>>>>
> > > >>>>>>>>>> Cheers,
> > > >>>>>>>>>> Stephan
> > > >>>>>>>>>>
> > > >>>>>>>>>>
> > > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> > > >>>>>>>> balassi.marton@gmail.com
> > > >>>>>>>>>> wrote:
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> Hey,
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> Checking the PRs listed by Stephan it seems every import
> one
> > > >>>> has
> > > >>>>>> been
> > > >>>>>>>>>>> merged. As for the optional ones the following two are
> still
> > > >>>>>> pending:
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract Classes as
> > > >>>> POJOs
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API operators
> > > >>>>>>>>>>>
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just updated it.
> > > >>>> Should
> > > >>>>>> we
> > > >>>>>>>> wait
> > > >>>>>>>>>>> for it?
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> Cheers,
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> Marton
> > > >>>>>>>>>>>
> > > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <
> uce@apache.org
> > >
> > > >>>>>> wrote:
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
> > > >>>>> sewen@apache.org>
> > > >>>>>>>>>> wrote:
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> ----------------------------------------------
> > > >>>>>>>>>>>>> Important Pull Requests to merge:
> > > >>>>>>>>>>>>> ----------------------------------------------
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers splits with
> > > >>>>> less
> > > >>>>>>>>>> degrees
> > > >>>>>>>>>>> of
> > > >>>>>>>>>>>>> freedom
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
> > > >>>>>>>>>> NullWritable
> > > >>>>>>>>>>>>> support
> > > >>>>>>>>>>>>>
> > > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple APIs +
> > > >>>> fix
> > > >>>>>> of
> > > >>>>>>>>>>>>> ExecutionEnvironment
> > > >>>>>>>>>>>>> (this is partially merged, there are a few POM entries
> > > >>>>> missing
> > > >>>>>>>> for
> > > >>>>>>>>>>>> Hadoop 1
> > > >>>>>>>>>>>>> support)
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> The first two PRs are still open. I will have a look at
> them
> > > >>>> as
> > > >>>>>>>> well
> > > >>>>>>>>>>>> (Robert already tested one).
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> @Robert:
> > > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
> > > >>>>>>>> flink-hbase
> > > >>>>>>>>>>>> module for hadoop1 build as well")?
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>>
> > > >>>>>>>>>>>> It would be nice if had a look at the remaining important
> > > >>>> ones
> > > >>>>>>>> today.
> > > >>>>>>>>>> :-)
> > > >>
> > >
> >
>
Re: Forking off the 0.8 release branch.
Posted by Stephan Ewen <se...@apache.org>.
Hi!
I forked a branch "release-0.8" and bumped the master version to
"0.9-incubating-SNAPSHOT".
The closure cleaner is merged. Robert has opened a PR for Kryo - I would
suggest to merge that to "master", cherry-pick to "release-0.8" and then:
Merry releasing!
Greetings,
Stephan
On Tue, Dec 16, 2014 at 6:43 PM, Márton Balassi <ba...@gmail.com>
wrote:
>
> @Timo&Stephan: The streaming code uses this since last week [1], Timo
> starting working on the issue prior way before that - so it also has to do
> with the streaming team pushing last minute features to be honest...
>
> Then are we waiting for the Java Clousure cleaner and the Kyro support, I
> guess.
> Aljoscha has already issued a PR for the former, some additional testing is
> needed from the looks of it. [2]
>
> [1]
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
> [2] https://github.com/apache/incubator-flink/pull/269
>
> On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <fl...@twalthr.com> wrote:
> >
> > Yes, I also think so. Stability is more important.
> >
> > > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <se...@apache.org>:
> > >
> > > Yes, the fact that we both did not realize that until now sort of
> reveals
> > > that there are more implications than anticipated. That is never good
> for
> > > "last minute" patches.
> > >
> > > That's why I would like to merge it into 0.8.1 and 0.9, rather than
> 0.8.0
> > > That gives the code a bit more testing/use and us a bit more time to
> > > thoroughly think the implications through.
> > >
> > >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <fl...@twalthr.com>
> > wrote:
> > >>
> > >> Sorry I totally forgot to check the streaming API. Do they use the
> > >> getXXXReturnTypes() methods of the TypeExtractor?
> > >>
> > >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <rm...@apache.org>:
> > >>>
> > >>> I've worked on adding Kryo support to Flink today. I would really
> like
> > to
> > >>> include this into the release. Many users were complaining about
> this (
> > >>> https://issues.apache.org/jira/browse/FLINK-610).
> > >>>
> > >>> I've based my work on top of Timo's pull request. If we're not going
> to
> > >>> merge it, I will have to rebase my code to the current master. ...
> I'll
> > >> try
> > >>> and see if its easily doable.
> > >>>
> > >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <se...@apache.org>
> > wrote:
> > >>>>
> > >>>> Yes, one thing I just realized is that the streaming API is not
> aware
> > of
> > >>>> MissingTypeInfos and it may cause weird behavior.
> > >>>>
> > >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <fh...@gmail.com>
> > >> wrote:
> > >>>>>
> > >>>>> +1 for stability first
> > >>>>>
> > >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
> > >>>>>>
> > >>>>>> I am currently working through the type hints pull request...
> > >>>>>>
> > >>>>>> Right now, I actually think that we should postpone this for the
> > next
> > >>>>>> bugfix release.
> > >>>>>>
> > >>>>>> This pull request changes actually some tricky mechanisms in the
> > Java
> > >>>> API
> > >>>>>> (it delays the type information), which may have implications that
> > me
> > >>>> and
> > >>>>>> Timo have not fully caught now.
> > >>>>>>
> > >>>>>> I don't feel Merging this last minute - this is prone to introduce
> > >>>>> errors.
> > >>>>>>
> > >>>>>> Any opinions on that?
> > >>>>>>
> > >>>>>>
> > >>>>>>
> > >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org>
> > >>>> wrote:
> > >>>>>>>
> > >>>>>>> +1 for adding the closure cleaner...
> > >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
> > aljoscha@apache.org
> > >>>>> :
> > >>>>>>>
> > >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
> > >>>>>>>>
> > >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> > >>>>>>>> <ba...@gmail.com> wrote:
> > >>>>>>>>> Cool, thanks.
> > >>>>>>>>>
> > >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <
> sewen@apache.org
> > >
> > >>>>>>>> wrote:
> > >>>>>>>>>>
> > >>>>>>>>>> Hi!
> > >>>>>>>>>>
> > >>>>>>>>>> The type hints PR is ready now, Timo made some final
> adjustments
> > >>>>>>>> yesterday
> > >>>>>>>>>> evening. I'll review and merge it now, then we can fork the
> > >>>> branch.
> > >>>>>>>>>>
> > >>>>>>>>>> Cheers,
> > >>>>>>>>>> Stephan
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> > >>>>>>>> balassi.marton@gmail.com
> > >>>>>>>>>> wrote:
> > >>>>>>>>>>>
> > >>>>>>>>>>> Hey,
> > >>>>>>>>>>>
> > >>>>>>>>>>> Checking the PRs listed by Stephan it seems every import one
> > >>>> has
> > >>>>>> been
> > >>>>>>>>>>> merged. As for the optional ones the following two are still
> > >>>>>> pending:
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract Classes as
> > >>>> POJOs
> > >>>>>>>>>>>
> > >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API operators
> > >>>>>>>>>>>
> > >>>>>>>>>>>
> > >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just updated it.
> > >>>> Should
> > >>>>>> we
> > >>>>>>>> wait
> > >>>>>>>>>>> for it?
> > >>>>>>>>>>>
> > >>>>>>>>>>> Cheers,
> > >>>>>>>>>>>
> > >>>>>>>>>>> Marton
> > >>>>>>>>>>>
> > >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uce@apache.org
> >
> > >>>>>> wrote:
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
> > >>>>> sewen@apache.org>
> > >>>>>>>>>> wrote:
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> ----------------------------------------------
> > >>>>>>>>>>>>> Important Pull Requests to merge:
> > >>>>>>>>>>>>> ----------------------------------------------
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers splits with
> > >>>>> less
> > >>>>>>>>>> degrees
> > >>>>>>>>>>> of
> > >>>>>>>>>>>>> freedom
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
> > >>>>>>>>>> NullWritable
> > >>>>>>>>>>>>> support
> > >>>>>>>>>>>>>
> > >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple APIs +
> > >>>> fix
> > >>>>>> of
> > >>>>>>>>>>>>> ExecutionEnvironment
> > >>>>>>>>>>>>> (this is partially merged, there are a few POM entries
> > >>>>> missing
> > >>>>>>>> for
> > >>>>>>>>>>>> Hadoop 1
> > >>>>>>>>>>>>> support)
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> The first two PRs are still open. I will have a look at them
> > >>>> as
> > >>>>>>>> well
> > >>>>>>>>>>>> (Robert already tested one).
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> @Robert:
> > >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
> > >>>>>>>> flink-hbase
> > >>>>>>>>>>>> module for hadoop1 build as well")?
> > >>>>>>>>>>>>
> > >>>>>>>>>>>>
> > >>>>>>>>>>>> It would be nice if had a look at the remaining important
> > >>>> ones
> > >>>>>>>> today.
> > >>>>>>>>>> :-)
> > >>
> >
>
Re: Forking off the 0.8 release branch.
Posted by Márton Balassi <ba...@gmail.com>.
@Timo&Stephan: The streaming code uses this since last week [1], Timo
starting working on the issue prior way before that - so it also has to do
with the streaming team pushing last minute features to be honest...
Then are we waiting for the Java Clousure cleaner and the Kyro support, I
guess.
Aljoscha has already issued a PR for the former, some additional testing is
needed from the looks of it. [2]
[1]
https://git-wip-us.apache.org/repos/asf?p=incubator-flink.git;a=commit;h=51c1f67791307c2b9355171f7398d104befc8de5
[2] https://github.com/apache/incubator-flink/pull/269
On Tue, Dec 16, 2014 at 5:52 PM, Timo Walther <fl...@twalthr.com> wrote:
>
> Yes, I also think so. Stability is more important.
>
> > Am 16.12.2014 um 17:46 schrieb Stephan Ewen <se...@apache.org>:
> >
> > Yes, the fact that we both did not realize that until now sort of reveals
> > that there are more implications than anticipated. That is never good for
> > "last minute" patches.
> >
> > That's why I would like to merge it into 0.8.1 and 0.9, rather than 0.8.0
> > That gives the code a bit more testing/use and us a bit more time to
> > thoroughly think the implications through.
> >
> >> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <fl...@twalthr.com>
> wrote:
> >>
> >> Sorry I totally forgot to check the streaming API. Do they use the
> >> getXXXReturnTypes() methods of the TypeExtractor?
> >>
> >>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <rm...@apache.org>:
> >>>
> >>> I've worked on adding Kryo support to Flink today. I would really like
> to
> >>> include this into the release. Many users were complaining about this (
> >>> https://issues.apache.org/jira/browse/FLINK-610).
> >>>
> >>> I've based my work on top of Timo's pull request. If we're not going to
> >>> merge it, I will have to rebase my code to the current master. ... I'll
> >> try
> >>> and see if its easily doable.
> >>>
> >>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <se...@apache.org>
> wrote:
> >>>>
> >>>> Yes, one thing I just realized is that the streaming API is not aware
> of
> >>>> MissingTypeInfos and it may cause weird behavior.
> >>>>
> >>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <fh...@gmail.com>
> >> wrote:
> >>>>>
> >>>>> +1 for stability first
> >>>>>
> >>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
> >>>>>>
> >>>>>> I am currently working through the type hints pull request...
> >>>>>>
> >>>>>> Right now, I actually think that we should postpone this for the
> next
> >>>>>> bugfix release.
> >>>>>>
> >>>>>> This pull request changes actually some tricky mechanisms in the
> Java
> >>>> API
> >>>>>> (it delays the type information), which may have implications that
> me
> >>>> and
> >>>>>> Timo have not fully caught now.
> >>>>>>
> >>>>>> I don't feel Merging this last minute - this is prone to introduce
> >>>>> errors.
> >>>>>>
> >>>>>> Any opinions on that?
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org>
> >>>> wrote:
> >>>>>>>
> >>>>>>> +1 for adding the closure cleaner...
> >>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <
> aljoscha@apache.org
> >>>>> :
> >>>>>>>
> >>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
> >>>>>>>>
> >>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> >>>>>>>> <ba...@gmail.com> wrote:
> >>>>>>>>> Cool, thanks.
> >>>>>>>>>
> >>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <sewen@apache.org
> >
> >>>>>>>> wrote:
> >>>>>>>>>>
> >>>>>>>>>> Hi!
> >>>>>>>>>>
> >>>>>>>>>> The type hints PR is ready now, Timo made some final adjustments
> >>>>>>>> yesterday
> >>>>>>>>>> evening. I'll review and merge it now, then we can fork the
> >>>> branch.
> >>>>>>>>>>
> >>>>>>>>>> Cheers,
> >>>>>>>>>> Stephan
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> >>>>>>>> balassi.marton@gmail.com
> >>>>>>>>>> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>> Hey,
> >>>>>>>>>>>
> >>>>>>>>>>> Checking the PRs listed by Stephan it seems every import one
> >>>> has
> >>>>>> been
> >>>>>>>>>>> merged. As for the optional ones the following two are still
> >>>>>> pending:
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract Classes as
> >>>> POJOs
> >>>>>>>>>>>
> >>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API operators
> >>>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just updated it.
> >>>> Should
> >>>>>> we
> >>>>>>>> wait
> >>>>>>>>>>> for it?
> >>>>>>>>>>>
> >>>>>>>>>>> Cheers,
> >>>>>>>>>>>
> >>>>>>>>>>> Marton
> >>>>>>>>>>>
> >>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org>
> >>>>>> wrote:
> >>>>>>>>>>>>
> >>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
> >>>>> sewen@apache.org>
> >>>>>>>>>> wrote:
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> ----------------------------------------------
> >>>>>>>>>>>>> Important Pull Requests to merge:
> >>>>>>>>>>>>> ----------------------------------------------
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers splits with
> >>>>> less
> >>>>>>>>>> degrees
> >>>>>>>>>>> of
> >>>>>>>>>>>>> freedom
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
> >>>>>>>>>> NullWritable
> >>>>>>>>>>>>> support
> >>>>>>>>>>>>>
> >>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple APIs +
> >>>> fix
> >>>>>> of
> >>>>>>>>>>>>> ExecutionEnvironment
> >>>>>>>>>>>>> (this is partially merged, there are a few POM entries
> >>>>> missing
> >>>>>>>> for
> >>>>>>>>>>>> Hadoop 1
> >>>>>>>>>>>>> support)
> >>>>>>>>>>>>
> >>>>>>>>>>>> The first two PRs are still open. I will have a look at them
> >>>> as
> >>>>>>>> well
> >>>>>>>>>>>> (Robert already tested one).
> >>>>>>>>>>>>
> >>>>>>>>>>>> @Robert:
> >>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
> >>>>>>>> flink-hbase
> >>>>>>>>>>>> module for hadoop1 build as well")?
> >>>>>>>>>>>>
> >>>>>>>>>>>>
> >>>>>>>>>>>> It would be nice if had a look at the remaining important
> >>>> ones
> >>>>>>>> today.
> >>>>>>>>>> :-)
> >>
>
Re: Forking off the 0.8 release branch.
Posted by Timo Walther <fl...@twalthr.com>.
Yes, I also think so. Stability is more important.
> Am 16.12.2014 um 17:46 schrieb Stephan Ewen <se...@apache.org>:
>
> Yes, the fact that we both did not realize that until now sort of reveals
> that there are more implications than anticipated. That is never good for
> "last minute" patches.
>
> That's why I would like to merge it into 0.8.1 and 0.9, rather than 0.8.0
> That gives the code a bit more testing/use and us a bit more time to
> thoroughly think the implications through.
>
>> On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <fl...@twalthr.com> wrote:
>>
>> Sorry I totally forgot to check the streaming API. Do they use the
>> getXXXReturnTypes() methods of the TypeExtractor?
>>
>>> Am 16.12.2014 um 17:23 schrieb Robert Metzger <rm...@apache.org>:
>>>
>>> I've worked on adding Kryo support to Flink today. I would really like to
>>> include this into the release. Many users were complaining about this (
>>> https://issues.apache.org/jira/browse/FLINK-610).
>>>
>>> I've based my work on top of Timo's pull request. If we're not going to
>>> merge it, I will have to rebase my code to the current master. ... I'll
>> try
>>> and see if its easily doable.
>>>
>>>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <se...@apache.org> wrote:
>>>>
>>>> Yes, one thing I just realized is that the streaming API is not aware of
>>>> MissingTypeInfos and it may cause weird behavior.
>>>>
>>>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <fh...@gmail.com>
>> wrote:
>>>>>
>>>>> +1 for stability first
>>>>>
>>>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
>>>>>>
>>>>>> I am currently working through the type hints pull request...
>>>>>>
>>>>>> Right now, I actually think that we should postpone this for the next
>>>>>> bugfix release.
>>>>>>
>>>>>> This pull request changes actually some tricky mechanisms in the Java
>>>> API
>>>>>> (it delays the type information), which may have implications that me
>>>> and
>>>>>> Timo have not fully caught now.
>>>>>>
>>>>>> I don't feel Merging this last minute - this is prone to introduce
>>>>> errors.
>>>>>>
>>>>>> Any opinions on that?
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org>
>>>> wrote:
>>>>>>>
>>>>>>> +1 for adding the closure cleaner...
>>>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <aljoscha@apache.org
>>>>> :
>>>>>>>
>>>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
>>>>>>>>
>>>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
>>>>>>>> <ba...@gmail.com> wrote:
>>>>>>>>> Cool, thanks.
>>>>>>>>>
>>>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org>
>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>> Hi!
>>>>>>>>>>
>>>>>>>>>> The type hints PR is ready now, Timo made some final adjustments
>>>>>>>> yesterday
>>>>>>>>>> evening. I'll review and merge it now, then we can fork the
>>>> branch.
>>>>>>>>>>
>>>>>>>>>> Cheers,
>>>>>>>>>> Stephan
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
>>>>>>>> balassi.marton@gmail.com
>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Hey,
>>>>>>>>>>>
>>>>>>>>>>> Checking the PRs listed by Stephan it seems every import one
>>>> has
>>>>>> been
>>>>>>>>>>> merged. As for the optional ones the following two are still
>>>>>> pending:
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Add support for Subclasses, Interfaces, Abstract Classes as
>>>> POJOs
>>>>>>>>>>>
>>>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API operators
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just updated it.
>>>> Should
>>>>>> we
>>>>>>>> wait
>>>>>>>>>>> for it?
>>>>>>>>>>>
>>>>>>>>>>> Cheers,
>>>>>>>>>>>
>>>>>>>>>>> Marton
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org>
>>>>>> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
>>>>> sewen@apache.org>
>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> ----------------------------------------------
>>>>>>>>>>>>> Important Pull Requests to merge:
>>>>>>>>>>>>> ----------------------------------------------
>>>>>>>>>>>>>
>>>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers splits with
>>>>> less
>>>>>>>>>> degrees
>>>>>>>>>>> of
>>>>>>>>>>>>> freedom
>>>>>>>>>>>>>
>>>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
>>>>>>>>>> NullWritable
>>>>>>>>>>>>> support
>>>>>>>>>>>>>
>>>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple APIs +
>>>> fix
>>>>>> of
>>>>>>>>>>>>> ExecutionEnvironment
>>>>>>>>>>>>> (this is partially merged, there are a few POM entries
>>>>> missing
>>>>>>>> for
>>>>>>>>>>>> Hadoop 1
>>>>>>>>>>>>> support)
>>>>>>>>>>>>
>>>>>>>>>>>> The first two PRs are still open. I will have a look at them
>>>> as
>>>>>>>> well
>>>>>>>>>>>> (Robert already tested one).
>>>>>>>>>>>>
>>>>>>>>>>>> @Robert:
>>>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
>>>>>>>> flink-hbase
>>>>>>>>>>>> module for hadoop1 build as well")?
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> It would be nice if had a look at the remaining important
>>>> ones
>>>>>>>> today.
>>>>>>>>>> :-)
>>
Re: Forking off the 0.8 release branch.
Posted by Stephan Ewen <se...@apache.org>.
Yes, the fact that we both did not realize that until now sort of reveals
that there are more implications than anticipated. That is never good for
"last minute" patches.
That's why I would like to merge it into 0.8.1 and 0.9, rather than 0.8.0
That gives the code a bit more testing/use and us a bit more time to
thoroughly think the implications through.
On Tue, Dec 16, 2014 at 5:30 PM, Timo Walther <fl...@twalthr.com> wrote:
>
> Sorry I totally forgot to check the streaming API. Do they use the
> getXXXReturnTypes() methods of the TypeExtractor?
>
> > Am 16.12.2014 um 17:23 schrieb Robert Metzger <rm...@apache.org>:
> >
> > I've worked on adding Kryo support to Flink today. I would really like to
> > include this into the release. Many users were complaining about this (
> > https://issues.apache.org/jira/browse/FLINK-610).
> >
> > I've based my work on top of Timo's pull request. If we're not going to
> > merge it, I will have to rebase my code to the current master. ... I'll
> try
> > and see if its easily doable.
> >
> >> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <se...@apache.org> wrote:
> >>
> >> Yes, one thing I just realized is that the streaming API is not aware of
> >> MissingTypeInfos and it may cause weird behavior.
> >>
> >>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <fh...@gmail.com>
> wrote:
> >>>
> >>> +1 for stability first
> >>>
> >>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
> >>>>
> >>>> I am currently working through the type hints pull request...
> >>>>
> >>>> Right now, I actually think that we should postpone this for the next
> >>>> bugfix release.
> >>>>
> >>>> This pull request changes actually some tricky mechanisms in the Java
> >> API
> >>>> (it delays the type information), which may have implications that me
> >> and
> >>>> Timo have not fully caught now.
> >>>>
> >>>> I don't feel Merging this last minute - this is prone to introduce
> >>> errors.
> >>>>
> >>>> Any opinions on that?
> >>>>
> >>>>
> >>>>
> >>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org>
> >> wrote:
> >>>>>
> >>>>> +1 for adding the closure cleaner...
> >>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <aljoscha@apache.org
> >>> :
> >>>>>
> >>>>> Do we want the Java Closure Cleaner in 0.8 as well?
> >>>>>>
> >>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> >>>>>> <ba...@gmail.com> wrote:
> >>>>>>> Cool, thanks.
> >>>>>>>
> >>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org>
> >>>>>> wrote:
> >>>>>>>>
> >>>>>>>> Hi!
> >>>>>>>>
> >>>>>>>> The type hints PR is ready now, Timo made some final adjustments
> >>>>>> yesterday
> >>>>>>>> evening. I'll review and merge it now, then we can fork the
> >> branch.
> >>>>>>>>
> >>>>>>>> Cheers,
> >>>>>>>> Stephan
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> >>>>>> balassi.marton@gmail.com
> >>>>>>>> wrote:
> >>>>>>>>>
> >>>>>>>>> Hey,
> >>>>>>>>>
> >>>>>>>>> Checking the PRs listed by Stephan it seems every import one
> >> has
> >>>> been
> >>>>>>>>> merged. As for the optional ones the following two are still
> >>>> pending:
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Add support for Subclasses, Interfaces, Abstract Classes as
> >> POJOs
> >>>>>>>>>
> >>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API operators
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> Robert +1'd the TypeHints PR and Timo has just updated it.
> >> Should
> >>>> we
> >>>>>> wait
> >>>>>>>>> for it?
> >>>>>>>>>
> >>>>>>>>> Cheers,
> >>>>>>>>>
> >>>>>>>>> Marton
> >>>>>>>>>
> >>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org>
> >>>> wrote:
> >>>>>>>>>>
> >>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
> >>> sewen@apache.org>
> >>>>>>>> wrote:
> >>>>>>>>>>>
> >>>>>>>>>>> ----------------------------------------------
> >>>>>>>>>>> Important Pull Requests to merge:
> >>>>>>>>>>> ----------------------------------------------
> >>>>>>>>>>>
> >>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers splits with
> >>> less
> >>>>>>>> degrees
> >>>>>>>>> of
> >>>>>>>>>>> freedom
> >>>>>>>>>>>
> >>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
> >>>>>>>> NullWritable
> >>>>>>>>>>> support
> >>>>>>>>>>>
> >>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple APIs +
> >> fix
> >>>> of
> >>>>>>>>>>> ExecutionEnvironment
> >>>>>>>>>>> (this is partially merged, there are a few POM entries
> >>> missing
> >>>>>> for
> >>>>>>>>>> Hadoop 1
> >>>>>>>>>>> support)
> >>>>>>>>>>
> >>>>>>>>>> The first two PRs are still open. I will have a look at them
> >> as
> >>>>>> well
> >>>>>>>>>> (Robert already tested one).
> >>>>>>>>>>
> >>>>>>>>>> @Robert:
> >>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
> >>>>>> flink-hbase
> >>>>>>>>>> module for hadoop1 build as well")?
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>> It would be nice if had a look at the remaining important
> >> ones
> >>>>>> today.
> >>>>>>>> :-)
> >>
>
Re: Forking off the 0.8 release branch.
Posted by Timo Walther <fl...@twalthr.com>.
Sorry I totally forgot to check the streaming API. Do they use the getXXXReturnTypes() methods of the TypeExtractor?
> Am 16.12.2014 um 17:23 schrieb Robert Metzger <rm...@apache.org>:
>
> I've worked on adding Kryo support to Flink today. I would really like to
> include this into the release. Many users were complaining about this (
> https://issues.apache.org/jira/browse/FLINK-610).
>
> I've based my work on top of Timo's pull request. If we're not going to
> merge it, I will have to rebase my code to the current master. ... I'll try
> and see if its easily doable.
>
>> On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <se...@apache.org> wrote:
>>
>> Yes, one thing I just realized is that the streaming API is not aware of
>> MissingTypeInfos and it may cause weird behavior.
>>
>>> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <fh...@gmail.com> wrote:
>>>
>>> +1 for stability first
>>>
>>> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
>>>>
>>>> I am currently working through the type hints pull request...
>>>>
>>>> Right now, I actually think that we should postpone this for the next
>>>> bugfix release.
>>>>
>>>> This pull request changes actually some tricky mechanisms in the Java
>> API
>>>> (it delays the type information), which may have implications that me
>> and
>>>> Timo have not fully caught now.
>>>>
>>>> I don't feel Merging this last minute - this is prone to introduce
>>> errors.
>>>>
>>>> Any opinions on that?
>>>>
>>>>
>>>>
>>>> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org>
>> wrote:
>>>>>
>>>>> +1 for adding the closure cleaner...
>>>>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <aljoscha@apache.org
>>> :
>>>>>
>>>>> Do we want the Java Closure Cleaner in 0.8 as well?
>>>>>>
>>>>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
>>>>>> <ba...@gmail.com> wrote:
>>>>>>> Cool, thanks.
>>>>>>>
>>>>>>> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org>
>>>>>> wrote:
>>>>>>>>
>>>>>>>> Hi!
>>>>>>>>
>>>>>>>> The type hints PR is ready now, Timo made some final adjustments
>>>>>> yesterday
>>>>>>>> evening. I'll review and merge it now, then we can fork the
>> branch.
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>> Stephan
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
>>>>>> balassi.marton@gmail.com
>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>> Hey,
>>>>>>>>>
>>>>>>>>> Checking the PRs listed by Stephan it seems every import one
>> has
>>>> been
>>>>>>>>> merged. As for the optional ones the following two are still
>>>> pending:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Add support for Subclasses, Interfaces, Abstract Classes as
>> POJOs
>>>>>>>>>
>>>>>>>>> [FLINK-1245] Introduce TypeHints for Java API operators
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Robert +1'd the TypeHints PR and Timo has just updated it.
>> Should
>>>> we
>>>>>> wait
>>>>>>>>> for it?
>>>>>>>>>
>>>>>>>>> Cheers,
>>>>>>>>>
>>>>>>>>> Marton
>>>>>>>>>
>>>>>>>>> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org>
>>>> wrote:
>>>>>>>>>>
>>>>>>>>>> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
>>> sewen@apache.org>
>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> ----------------------------------------------
>>>>>>>>>>> Important Pull Requests to merge:
>>>>>>>>>>> ----------------------------------------------
>>>>>>>>>>>
>>>>>>>>>>> [FLINK-1287] LocalizableSplitAssigner prefers splits with
>>> less
>>>>>>>> degrees
>>>>>>>>> of
>>>>>>>>>>> freedom
>>>>>>>>>>>
>>>>>>>>>>> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
>>>>>>>> NullWritable
>>>>>>>>>>> support
>>>>>>>>>>>
>>>>>>>>>>> Upgraded HBase addon to HBase 0.98.x and new Tuple APIs +
>> fix
>>>> of
>>>>>>>>>>> ExecutionEnvironment
>>>>>>>>>>> (this is partially merged, there are a few POM entries
>>> missing
>>>>>> for
>>>>>>>>>> Hadoop 1
>>>>>>>>>>> support)
>>>>>>>>>>
>>>>>>>>>> The first two PRs are still open. I will have a look at them
>> as
>>>>>> well
>>>>>>>>>> (Robert already tested one).
>>>>>>>>>>
>>>>>>>>>> @Robert:
>>>>>>>>>> Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
>>>>>> flink-hbase
>>>>>>>>>> module for hadoop1 build as well")?
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> It would be nice if had a look at the remaining important
>> ones
>>>>>> today.
>>>>>>>> :-)
>>
Re: Forking off the 0.8 release branch.
Posted by Robert Metzger <rm...@apache.org>.
I've worked on adding Kryo support to Flink today. I would really like to
include this into the release. Many users were complaining about this (
https://issues.apache.org/jira/browse/FLINK-610).
I've based my work on top of Timo's pull request. If we're not going to
merge it, I will have to rebase my code to the current master. ... I'll try
and see if its easily doable.
On Tue, Dec 16, 2014 at 5:02 PM, Stephan Ewen <se...@apache.org> wrote:
>
> Yes, one thing I just realized is that the streaming API is not aware of
> MissingTypeInfos and it may cause weird behavior.
>
> On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <fh...@gmail.com> wrote:
> >
> > +1 for stability first
> >
> > 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
> > >
> > > I am currently working through the type hints pull request...
> > >
> > > Right now, I actually think that we should postpone this for the next
> > > bugfix release.
> > >
> > > This pull request changes actually some tricky mechanisms in the Java
> API
> > > (it delays the type information), which may have implications that me
> and
> > > Timo have not fully caught now.
> > >
> > > I don't feel Merging this last minute - this is prone to introduce
> > errors.
> > >
> > > Any opinions on that?
> > >
> > >
> > >
> > > On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org>
> wrote:
> > > >
> > > > +1 for adding the closure cleaner...
> > > > Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <aljoscha@apache.org
> >:
> > > >
> > > > Do we want the Java Closure Cleaner in 0.8 as well?
> > > >>
> > > >> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> > > >> <ba...@gmail.com> wrote:
> > > >> > Cool, thanks.
> > > >> >
> > > >> > On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org>
> > > >> wrote:
> > > >> >>
> > > >> >> Hi!
> > > >> >>
> > > >> >> The type hints PR is ready now, Timo made some final adjustments
> > > >> yesterday
> > > >> >> evening. I'll review and merge it now, then we can fork the
> branch.
> > > >> >>
> > > >> >> Cheers,
> > > >> >> Stephan
> > > >> >>
> > > >> >>
> > > >> >> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> > > >> balassi.marton@gmail.com
> > > >> >> >
> > > >> >> wrote:
> > > >> >> >
> > > >> >> > Hey,
> > > >> >> >
> > > >> >> > Checking the PRs listed by Stephan it seems every import one
> has
> > > been
> > > >> >> > merged. As for the optional ones the following two are still
> > > pending:
> > > >> >> >
> > > >> >> >
> > > >> >> > Add support for Subclasses, Interfaces, Abstract Classes as
> POJOs
> > > >> >> >
> > > >> >> > [FLINK-1245] Introduce TypeHints for Java API operators
> > > >> >> >
> > > >> >> >
> > > >> >> > Robert +1'd the TypeHints PR and Timo has just updated it.
> Should
> > > we
> > > >> wait
> > > >> >> > for it?
> > > >> >> >
> > > >> >> > Cheers,
> > > >> >> >
> > > >> >> > Marton
> > > >> >> >
> > > >> >> > On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org>
> > > wrote:
> > > >> >> > >
> > > >> >> > > On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
> > sewen@apache.org>
> > > >> >> wrote:
> > > >> >> > > >
> > > >> >> > > > ----------------------------------------------
> > > >> >> > > > Important Pull Requests to merge:
> > > >> >> > > > ----------------------------------------------
> > > >> >> > > >
> > > >> >> > > > [FLINK-1287] LocalizableSplitAssigner prefers splits with
> > less
> > > >> >> degrees
> > > >> >> > of
> > > >> >> > > > freedom
> > > >> >> > > >
> > > >> >> > > > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
> > > >> >> NullWritable
> > > >> >> > > > support
> > > >> >> > > >
> > > >> >> > > > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs +
> fix
> > > of
> > > >> >> > > > ExecutionEnvironment
> > > >> >> > > > (this is partially merged, there are a few POM entries
> > missing
> > > >> for
> > > >> >> > > Hadoop 1
> > > >> >> > > > support)
> > > >> >> > > >
> > > >> >> > >
> > > >> >> > > The first two PRs are still open. I will have a look at them
> as
> > > >> well
> > > >> >> > > (Robert already tested one).
> > > >> >> > >
> > > >> >> > > @Robert:
> > > >> >> > > Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
> > > >> flink-hbase
> > > >> >> > > module for hadoop1 build as well")?
> > > >> >> > >
> > > >> >> > >
> > > >> >> > > It would be nice if had a look at the remaining important
> ones
> > > >> today.
> > > >> >> :-)
> > > >> >> > >
> > > >> >> >
> > > >> >>
> > > >>
> > > >
> > >
> >
>
Re: Forking off the 0.8 release branch.
Posted by Stephan Ewen <se...@apache.org>.
Yes, one thing I just realized is that the streaming API is not aware of
MissingTypeInfos and it may cause weird behavior.
On Tue, Dec 16, 2014 at 4:56 PM, Fabian Hueske <fh...@gmail.com> wrote:
>
> +1 for stability first
>
> 2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
> >
> > I am currently working through the type hints pull request...
> >
> > Right now, I actually think that we should postpone this for the next
> > bugfix release.
> >
> > This pull request changes actually some tricky mechanisms in the Java API
> > (it delays the type information), which may have implications that me and
> > Timo have not fully caught now.
> >
> > I don't feel Merging this last minute - this is prone to introduce
> errors.
> >
> > Any opinions on that?
> >
> >
> >
> > On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org> wrote:
> > >
> > > +1 for adding the closure cleaner...
> > > Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <al...@apache.org>:
> > >
> > > Do we want the Java Closure Cleaner in 0.8 as well?
> > >>
> > >> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> > >> <ba...@gmail.com> wrote:
> > >> > Cool, thanks.
> > >> >
> > >> > On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org>
> > >> wrote:
> > >> >>
> > >> >> Hi!
> > >> >>
> > >> >> The type hints PR is ready now, Timo made some final adjustments
> > >> yesterday
> > >> >> evening. I'll review and merge it now, then we can fork the branch.
> > >> >>
> > >> >> Cheers,
> > >> >> Stephan
> > >> >>
> > >> >>
> > >> >> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> > >> balassi.marton@gmail.com
> > >> >> >
> > >> >> wrote:
> > >> >> >
> > >> >> > Hey,
> > >> >> >
> > >> >> > Checking the PRs listed by Stephan it seems every import one has
> > been
> > >> >> > merged. As for the optional ones the following two are still
> > pending:
> > >> >> >
> > >> >> >
> > >> >> > Add support for Subclasses, Interfaces, Abstract Classes as POJOs
> > >> >> >
> > >> >> > [FLINK-1245] Introduce TypeHints for Java API operators
> > >> >> >
> > >> >> >
> > >> >> > Robert +1'd the TypeHints PR and Timo has just updated it. Should
> > we
> > >> wait
> > >> >> > for it?
> > >> >> >
> > >> >> > Cheers,
> > >> >> >
> > >> >> > Marton
> > >> >> >
> > >> >> > On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org>
> > wrote:
> > >> >> > >
> > >> >> > > On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <
> sewen@apache.org>
> > >> >> wrote:
> > >> >> > > >
> > >> >> > > > ----------------------------------------------
> > >> >> > > > Important Pull Requests to merge:
> > >> >> > > > ----------------------------------------------
> > >> >> > > >
> > >> >> > > > [FLINK-1287] LocalizableSplitAssigner prefers splits with
> less
> > >> >> degrees
> > >> >> > of
> > >> >> > > > freedom
> > >> >> > > >
> > >> >> > > > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
> > >> >> NullWritable
> > >> >> > > > support
> > >> >> > > >
> > >> >> > > > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix
> > of
> > >> >> > > > ExecutionEnvironment
> > >> >> > > > (this is partially merged, there are a few POM entries
> missing
> > >> for
> > >> >> > > Hadoop 1
> > >> >> > > > support)
> > >> >> > > >
> > >> >> > >
> > >> >> > > The first two PRs are still open. I will have a look at them as
> > >> well
> > >> >> > > (Robert already tested one).
> > >> >> > >
> > >> >> > > @Robert:
> > >> >> > > Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
> > >> flink-hbase
> > >> >> > > module for hadoop1 build as well")?
> > >> >> > >
> > >> >> > >
> > >> >> > > It would be nice if had a look at the remaining important ones
> > >> today.
> > >> >> :-)
> > >> >> > >
> > >> >> >
> > >> >>
> > >>
> > >
> >
>
Re: Forking off the 0.8 release branch.
Posted by Fabian Hueske <fh...@gmail.com>.
+1 for stability first
2014-12-16 16:50 GMT+01:00 Stephan Ewen <se...@apache.org>:
>
> I am currently working through the type hints pull request...
>
> Right now, I actually think that we should postpone this for the next
> bugfix release.
>
> This pull request changes actually some tricky mechanisms in the Java API
> (it delays the type information), which may have implications that me and
> Timo have not fully caught now.
>
> I don't feel Merging this last minute - this is prone to introduce errors.
>
> Any opinions on that?
>
>
>
> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org> wrote:
> >
> > +1 for adding the closure cleaner...
> > Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <al...@apache.org>:
> >
> > Do we want the Java Closure Cleaner in 0.8 as well?
> >>
> >> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> >> <ba...@gmail.com> wrote:
> >> > Cool, thanks.
> >> >
> >> > On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org>
> >> wrote:
> >> >>
> >> >> Hi!
> >> >>
> >> >> The type hints PR is ready now, Timo made some final adjustments
> >> yesterday
> >> >> evening. I'll review and merge it now, then we can fork the branch.
> >> >>
> >> >> Cheers,
> >> >> Stephan
> >> >>
> >> >>
> >> >> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> >> balassi.marton@gmail.com
> >> >> >
> >> >> wrote:
> >> >> >
> >> >> > Hey,
> >> >> >
> >> >> > Checking the PRs listed by Stephan it seems every import one has
> been
> >> >> > merged. As for the optional ones the following two are still
> pending:
> >> >> >
> >> >> >
> >> >> > Add support for Subclasses, Interfaces, Abstract Classes as POJOs
> >> >> >
> >> >> > [FLINK-1245] Introduce TypeHints for Java API operators
> >> >> >
> >> >> >
> >> >> > Robert +1'd the TypeHints PR and Timo has just updated it. Should
> we
> >> wait
> >> >> > for it?
> >> >> >
> >> >> > Cheers,
> >> >> >
> >> >> > Marton
> >> >> >
> >> >> > On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org>
> wrote:
> >> >> > >
> >> >> > > On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org>
> >> >> wrote:
> >> >> > > >
> >> >> > > > ----------------------------------------------
> >> >> > > > Important Pull Requests to merge:
> >> >> > > > ----------------------------------------------
> >> >> > > >
> >> >> > > > [FLINK-1287] LocalizableSplitAssigner prefers splits with less
> >> >> degrees
> >> >> > of
> >> >> > > > freedom
> >> >> > > >
> >> >> > > > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
> >> >> NullWritable
> >> >> > > > support
> >> >> > > >
> >> >> > > > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix
> of
> >> >> > > > ExecutionEnvironment
> >> >> > > > (this is partially merged, there are a few POM entries missing
> >> for
> >> >> > > Hadoop 1
> >> >> > > > support)
> >> >> > > >
> >> >> > >
> >> >> > > The first two PRs are still open. I will have a look at them as
> >> well
> >> >> > > (Robert already tested one).
> >> >> > >
> >> >> > > @Robert:
> >> >> > > Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
> >> flink-hbase
> >> >> > > module for hadoop1 build as well")?
> >> >> > >
> >> >> > >
> >> >> > > It would be nice if had a look at the remaining important ones
> >> today.
> >> >> :-)
> >> >> > >
> >> >> >
> >> >>
> >>
> >
>
Re: Forking off the 0.8 release branch.
Posted by Aljoscha Krettek <al...@apache.org>.
+1 on postponing if it introduces behaviour we don't fully understand
On Tue, Dec 16, 2014 at 4:50 PM, Stephan Ewen <se...@apache.org> wrote:
> I am currently working through the type hints pull request...
>
> Right now, I actually think that we should postpone this for the next
> bugfix release.
>
> This pull request changes actually some tricky mechanisms in the Java API
> (it delays the type information), which may have implications that me and
> Timo have not fully caught now.
>
> I don't feel Merging this last minute - this is prone to introduce errors.
>
> Any opinions on that?
>
>
>
> On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org> wrote:
>>
>> +1 for adding the closure cleaner...
>> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <al...@apache.org>:
>>
>> Do we want the Java Closure Cleaner in 0.8 as well?
>>>
>>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
>>> <ba...@gmail.com> wrote:
>>> > Cool, thanks.
>>> >
>>> > On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org>
>>> wrote:
>>> >>
>>> >> Hi!
>>> >>
>>> >> The type hints PR is ready now, Timo made some final adjustments
>>> yesterday
>>> >> evening. I'll review and merge it now, then we can fork the branch.
>>> >>
>>> >> Cheers,
>>> >> Stephan
>>> >>
>>> >>
>>> >> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
>>> balassi.marton@gmail.com
>>> >> >
>>> >> wrote:
>>> >> >
>>> >> > Hey,
>>> >> >
>>> >> > Checking the PRs listed by Stephan it seems every import one has been
>>> >> > merged. As for the optional ones the following two are still pending:
>>> >> >
>>> >> >
>>> >> > Add support for Subclasses, Interfaces, Abstract Classes as POJOs
>>> >> >
>>> >> > [FLINK-1245] Introduce TypeHints for Java API operators
>>> >> >
>>> >> >
>>> >> > Robert +1'd the TypeHints PR and Timo has just updated it. Should we
>>> wait
>>> >> > for it?
>>> >> >
>>> >> > Cheers,
>>> >> >
>>> >> > Marton
>>> >> >
>>> >> > On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org> wrote:
>>> >> > >
>>> >> > > On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org>
>>> >> wrote:
>>> >> > > >
>>> >> > > > ----------------------------------------------
>>> >> > > > Important Pull Requests to merge:
>>> >> > > > ----------------------------------------------
>>> >> > > >
>>> >> > > > [FLINK-1287] LocalizableSplitAssigner prefers splits with less
>>> >> degrees
>>> >> > of
>>> >> > > > freedom
>>> >> > > >
>>> >> > > > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
>>> >> NullWritable
>>> >> > > > support
>>> >> > > >
>>> >> > > > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
>>> >> > > > ExecutionEnvironment
>>> >> > > > (this is partially merged, there are a few POM entries missing
>>> for
>>> >> > > Hadoop 1
>>> >> > > > support)
>>> >> > > >
>>> >> > >
>>> >> > > The first two PRs are still open. I will have a look at them as
>>> well
>>> >> > > (Robert already tested one).
>>> >> > >
>>> >> > > @Robert:
>>> >> > > Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
>>> flink-hbase
>>> >> > > module for hadoop1 build as well")?
>>> >> > >
>>> >> > >
>>> >> > > It would be nice if had a look at the remaining important ones
>>> today.
>>> >> :-)
>>> >> > >
>>> >> >
>>> >>
>>>
>>
Re: Forking off the 0.8 release branch.
Posted by Stephan Ewen <se...@apache.org>.
I am currently working through the type hints pull request...
Right now, I actually think that we should postpone this for the next
bugfix release.
This pull request changes actually some tricky mechanisms in the Java API
(it delays the type information), which may have implications that me and
Timo have not fully caught now.
I don't feel Merging this last minute - this is prone to introduce errors.
Any opinions on that?
On Tue, Dec 16, 2014 at 3:36 PM, Stephan Ewen <se...@apache.org> wrote:
>
> +1 for adding the closure cleaner...
> Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <al...@apache.org>:
>
> Do we want the Java Closure Cleaner in 0.8 as well?
>>
>> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
>> <ba...@gmail.com> wrote:
>> > Cool, thanks.
>> >
>> > On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org>
>> wrote:
>> >>
>> >> Hi!
>> >>
>> >> The type hints PR is ready now, Timo made some final adjustments
>> yesterday
>> >> evening. I'll review and merge it now, then we can fork the branch.
>> >>
>> >> Cheers,
>> >> Stephan
>> >>
>> >>
>> >> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
>> balassi.marton@gmail.com
>> >> >
>> >> wrote:
>> >> >
>> >> > Hey,
>> >> >
>> >> > Checking the PRs listed by Stephan it seems every import one has been
>> >> > merged. As for the optional ones the following two are still pending:
>> >> >
>> >> >
>> >> > Add support for Subclasses, Interfaces, Abstract Classes as POJOs
>> >> >
>> >> > [FLINK-1245] Introduce TypeHints for Java API operators
>> >> >
>> >> >
>> >> > Robert +1'd the TypeHints PR and Timo has just updated it. Should we
>> wait
>> >> > for it?
>> >> >
>> >> > Cheers,
>> >> >
>> >> > Marton
>> >> >
>> >> > On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org> wrote:
>> >> > >
>> >> > > On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org>
>> >> wrote:
>> >> > > >
>> >> > > > ----------------------------------------------
>> >> > > > Important Pull Requests to merge:
>> >> > > > ----------------------------------------------
>> >> > > >
>> >> > > > [FLINK-1287] LocalizableSplitAssigner prefers splits with less
>> >> degrees
>> >> > of
>> >> > > > freedom
>> >> > > >
>> >> > > > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
>> >> NullWritable
>> >> > > > support
>> >> > > >
>> >> > > > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
>> >> > > > ExecutionEnvironment
>> >> > > > (this is partially merged, there are a few POM entries missing
>> for
>> >> > > Hadoop 1
>> >> > > > support)
>> >> > > >
>> >> > >
>> >> > > The first two PRs are still open. I will have a look at them as
>> well
>> >> > > (Robert already tested one).
>> >> > >
>> >> > > @Robert:
>> >> > > Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
>> flink-hbase
>> >> > > module for hadoop1 build as well")?
>> >> > >
>> >> > >
>> >> > > It would be nice if had a look at the remaining important ones
>> today.
>> >> :-)
>> >> > >
>> >> >
>> >>
>>
>
Re: Forking off the 0.8 release branch.
Posted by Stephan Ewen <se...@apache.org>.
+1 for adding the closure cleaner...
Am 16.12.2014 15:23 schrieb "Aljoscha Krettek" <al...@apache.org>:
> Do we want the Java Closure Cleaner in 0.8 as well?
>
> On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
> <ba...@gmail.com> wrote:
> > Cool, thanks.
> >
> > On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org> wrote:
> >>
> >> Hi!
> >>
> >> The type hints PR is ready now, Timo made some final adjustments
> yesterday
> >> evening. I'll review and merge it now, then we can fork the branch.
> >>
> >> Cheers,
> >> Stephan
> >>
> >>
> >> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <
> balassi.marton@gmail.com
> >> >
> >> wrote:
> >> >
> >> > Hey,
> >> >
> >> > Checking the PRs listed by Stephan it seems every import one has been
> >> > merged. As for the optional ones the following two are still pending:
> >> >
> >> >
> >> > Add support for Subclasses, Interfaces, Abstract Classes as POJOs
> >> >
> >> > [FLINK-1245] Introduce TypeHints for Java API operators
> >> >
> >> >
> >> > Robert +1'd the TypeHints PR and Timo has just updated it. Should we
> wait
> >> > for it?
> >> >
> >> > Cheers,
> >> >
> >> > Marton
> >> >
> >> > On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org> wrote:
> >> > >
> >> > > On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org>
> >> wrote:
> >> > > >
> >> > > > ----------------------------------------------
> >> > > > Important Pull Requests to merge:
> >> > > > ----------------------------------------------
> >> > > >
> >> > > > [FLINK-1287] LocalizableSplitAssigner prefers splits with less
> >> degrees
> >> > of
> >> > > > freedom
> >> > > >
> >> > > > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
> >> NullWritable
> >> > > > support
> >> > > >
> >> > > > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
> >> > > > ExecutionEnvironment
> >> > > > (this is partially merged, there are a few POM entries missing for
> >> > > Hadoop 1
> >> > > > support)
> >> > > >
> >> > >
> >> > > The first two PRs are still open. I will have a look at them as well
> >> > > (Robert already tested one).
> >> > >
> >> > > @Robert:
> >> > > Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable
> flink-hbase
> >> > > module for hadoop1 build as well")?
> >> > >
> >> > >
> >> > > It would be nice if had a look at the remaining important ones
> today.
> >> :-)
> >> > >
> >> >
> >>
>
Re: Forking off the 0.8 release branch.
Posted by Aljoscha Krettek <al...@apache.org>.
Do we want the Java Closure Cleaner in 0.8 as well?
On Tue, Dec 16, 2014 at 10:30 AM, Márton Balassi
<ba...@gmail.com> wrote:
> Cool, thanks.
>
> On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org> wrote:
>>
>> Hi!
>>
>> The type hints PR is ready now, Timo made some final adjustments yesterday
>> evening. I'll review and merge it now, then we can fork the branch.
>>
>> Cheers,
>> Stephan
>>
>>
>> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <balassi.marton@gmail.com
>> >
>> wrote:
>> >
>> > Hey,
>> >
>> > Checking the PRs listed by Stephan it seems every import one has been
>> > merged. As for the optional ones the following two are still pending:
>> >
>> >
>> > Add support for Subclasses, Interfaces, Abstract Classes as POJOs
>> >
>> > [FLINK-1245] Introduce TypeHints for Java API operators
>> >
>> >
>> > Robert +1'd the TypeHints PR and Timo has just updated it. Should we wait
>> > for it?
>> >
>> > Cheers,
>> >
>> > Marton
>> >
>> > On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org> wrote:
>> > >
>> > > On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org>
>> wrote:
>> > > >
>> > > > ----------------------------------------------
>> > > > Important Pull Requests to merge:
>> > > > ----------------------------------------------
>> > > >
>> > > > [FLINK-1287] LocalizableSplitAssigner prefers splits with less
>> degrees
>> > of
>> > > > freedom
>> > > >
>> > > > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
>> NullWritable
>> > > > support
>> > > >
>> > > > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
>> > > > ExecutionEnvironment
>> > > > (this is partially merged, there are a few POM entries missing for
>> > > Hadoop 1
>> > > > support)
>> > > >
>> > >
>> > > The first two PRs are still open. I will have a look at them as well
>> > > (Robert already tested one).
>> > >
>> > > @Robert:
>> > > Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable flink-hbase
>> > > module for hadoop1 build as well")?
>> > >
>> > >
>> > > It would be nice if had a look at the remaining important ones today.
>> :-)
>> > >
>> >
>>
Re: Forking off the 0.8 release branch.
Posted by Márton Balassi <ba...@gmail.com>.
Cool, thanks.
On Tue, Dec 16, 2014 at 10:29 AM, Stephan Ewen <se...@apache.org> wrote:
>
> Hi!
>
> The type hints PR is ready now, Timo made some final adjustments yesterday
> evening. I'll review and merge it now, then we can fork the branch.
>
> Cheers,
> Stephan
>
>
> On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <balassi.marton@gmail.com
> >
> wrote:
> >
> > Hey,
> >
> > Checking the PRs listed by Stephan it seems every import one has been
> > merged. As for the optional ones the following two are still pending:
> >
> >
> > Add support for Subclasses, Interfaces, Abstract Classes as POJOs
> >
> > [FLINK-1245] Introduce TypeHints for Java API operators
> >
> >
> > Robert +1'd the TypeHints PR and Timo has just updated it. Should we wait
> > for it?
> >
> > Cheers,
> >
> > Marton
> >
> > On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org> wrote:
> > >
> > > On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org>
> wrote:
> > > >
> > > > ----------------------------------------------
> > > > Important Pull Requests to merge:
> > > > ----------------------------------------------
> > > >
> > > > [FLINK-1287] LocalizableSplitAssigner prefers splits with less
> degrees
> > of
> > > > freedom
> > > >
> > > > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and
> NullWritable
> > > > support
> > > >
> > > > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
> > > > ExecutionEnvironment
> > > > (this is partially merged, there are a few POM entries missing for
> > > Hadoop 1
> > > > support)
> > > >
> > >
> > > The first two PRs are still open. I will have a look at them as well
> > > (Robert already tested one).
> > >
> > > @Robert:
> > > Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable flink-hbase
> > > module for hadoop1 build as well")?
> > >
> > >
> > > It would be nice if had a look at the remaining important ones today.
> :-)
> > >
> >
>
Re: Forking off the 0.8 release branch.
Posted by Stephan Ewen <se...@apache.org>.
Hi!
The type hints PR is ready now, Timo made some final adjustments yesterday
evening. I'll review and merge it now, then we can fork the branch.
Cheers,
Stephan
On Mon, Dec 15, 2014 at 10:08 PM, Márton Balassi <ba...@gmail.com>
wrote:
>
> Hey,
>
> Checking the PRs listed by Stephan it seems every import one has been
> merged. As for the optional ones the following two are still pending:
>
>
> Add support for Subclasses, Interfaces, Abstract Classes as POJOs
>
> [FLINK-1245] Introduce TypeHints for Java API operators
>
>
> Robert +1'd the TypeHints PR and Timo has just updated it. Should we wait
> for it?
>
> Cheers,
>
> Marton
>
> On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org> wrote:
> >
> > On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org> wrote:
> > >
> > > ----------------------------------------------
> > > Important Pull Requests to merge:
> > > ----------------------------------------------
> > >
> > > [FLINK-1287] LocalizableSplitAssigner prefers splits with less degrees
> of
> > > freedom
> > >
> > > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and NullWritable
> > > support
> > >
> > > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
> > > ExecutionEnvironment
> > > (this is partially merged, there are a few POM entries missing for
> > Hadoop 1
> > > support)
> > >
> >
> > The first two PRs are still open. I will have a look at them as well
> > (Robert already tested one).
> >
> > @Robert:
> > Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable flink-hbase
> > module for hadoop1 build as well")?
> >
> >
> > It would be nice if had a look at the remaining important ones today. :-)
> >
>
Re: Forking off the 0.8 release branch.
Posted by Márton Balassi <ba...@gmail.com>.
Hey,
Checking the PRs listed by Stephan it seems every import one has been
merged. As for the optional ones the following two are still pending:
Add support for Subclasses, Interfaces, Abstract Classes as POJOs
[FLINK-1245] Introduce TypeHints for Java API operators
Robert +1'd the TypeHints PR and Timo has just updated it. Should we wait
for it?
Cheers,
Marton
On Fri, Dec 12, 2014 at 2:29 PM, Ufuk Celebi <uc...@apache.org> wrote:
>
> On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org> wrote:
> >
> > ----------------------------------------------
> > Important Pull Requests to merge:
> > ----------------------------------------------
> >
> > [FLINK-1287] LocalizableSplitAssigner prefers splits with less degrees of
> > freedom
> >
> > [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and NullWritable
> > support
> >
> > Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
> > ExecutionEnvironment
> > (this is partially merged, there are a few POM entries missing for
> Hadoop 1
> > support)
> >
>
> The first two PRs are still open. I will have a look at them as well
> (Robert already tested one).
>
> @Robert:
> Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable flink-hbase
> module for hadoop1 build as well")?
>
>
> It would be nice if had a look at the remaining important ones today. :-)
>
Re: Forking off the 0.8 release branch.
Posted by Ufuk Celebi <uc...@apache.org>.
On Wed, Dec 10, 2014 at 7:35 PM, Stephan Ewen <se...@apache.org> wrote:
>
> ----------------------------------------------
> Important Pull Requests to merge:
> ----------------------------------------------
>
> [FLINK-1287] LocalizableSplitAssigner prefers splits with less degrees of
> freedom
>
> [FLINK-1305] [FLINK-1304] Test for HadoopInputWrapper and NullWritable
> support
>
> Upgraded HBase addon to HBase 0.98.x and new Tuple APIs + fix of
> ExecutionEnvironment
> (this is partially merged, there are a few POM entries missing for Hadoop 1
> support)
>
The first two PRs are still open. I will have a look at them as well
(Robert already tested one).
@Robert:
Regarding the Hbase PR: Is it resolved by 1b69749 ("Enable flink-hbase
module for hadoop1 build as well")?
It would be nice if had a look at the remaining important ones today. :-)