You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Martin Monperrus (Jira)" <ji...@apache.org> on 2020/11/25 08:20:00 UTC

[jira] [Commented] (COLLECTIONS-773) method AbstractHashedMap#ensureCapacity is not well tested

    [ https://issues.apache.org/jira/browse/COLLECTIONS-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238596#comment-17238596 ] 

Martin Monperrus commented on COLLECTIONS-773:
----------------------------------------------

[~ggregory] WDYT? Thanks!

> method AbstractHashedMap#ensureCapacity is not well tested
> ----------------------------------------------------------
>
>                 Key: COLLECTIONS-773
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-773
>             Project: Commons Collections
>          Issue Type: Test
>          Components: Map
>    Affects Versions: Nightly Builds, 4.3, 4.4
>            Reporter: Martin Monperrus
>            Priority: Minor
>              Labels: performance, test
>
> Hi Apache 🏹!
> I notice that method AbstractHashedMap#ensureCapacity seems quite important, it is executed 11885 times by the test suite.
> Yet, when I completely remove the body of the method, leaving the method doing nothing, no test breaks.
> It that normal or should we add test or an assertion to specify its behavior?
> Thanks a lot for the great library!
> --Martin



--
This message was sent by Atlassian Jira
(v8.3.4#803005)