[GitHub] [accumulo] keith-turner commented on issue #2196: Add sanity check to table properties prior to creation of fate operation

[GitBox <gi...@apache.org>]

keith-turner commented on issue #2196:
URL: https://github.com/apache/accumulo/issues/2196#issuecomment-878342245


   As part of the FATE op to create a table the following executes to set any new table props.
   
   https://github.com/apache/accumulo/blob/80c8ee78342cfaea978882c37ebfcfc4af990fa1/server/manager/src/main/java/org/apache/accumulo/manager/tableOps/create/PopulateZookeeper.java#L61-L63
   
   The setTableProp method does a validity check and if that fails it returns false.
   
   https://github.com/apache/accumulo/blob/80c8ee78342cfaea978882c37ebfcfc4af990fa1/server/base/src/main/java/org/apache/accumulo/server/util/TablePropUtil.java#L42-L43
   
   So it seems if a user passed in invalid props to a table create op that those may be silently ignored.  Would probably be better if the table was not create and the create table operation client side got an error. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org