You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Tanujit Ghosh <ta...@gmail.com> on 2013/08/23 05:42:56 UTC
Review Request 13760: DRILL abs() function implementation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13760/
-----------------------------------------------------------
Review request for drill.
Repository: drill-git
Description
-------
Implementation of the abs() function within DRILL.
Diffs
-----
sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java 311e715
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java 78630ba
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockRecordReader.java 024aa21
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java ce5dccd
Diff: https://reviews.apache.org/r/13760/diff/
Testing
-------
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueInt
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueBigInt
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat4
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat8
Thanks,
Tanujit Ghosh
Re: Review Request 13760: DRILL-182 : abs() function implementation
Posted by Jacques Nadeau <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13760/#review25817
-----------------------------------------------------------
sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java
<https://reviews.apache.org/r/13760/#comment50364>
You should just create your own data if you're not happy with the mock scan data. A bunch of stuff rely on that being a consistent set of data.
- Jacques Nadeau
On Aug. 29, 2013, 2:47 a.m., Tanujit Ghosh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13760/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2013, 2:47 a.m.)
>
>
> Review request for drill.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Implementation of the abs() function within DRILL.
>
>
> Diffs
> -----
>
> sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java 311e715
> sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java 78630ba
> sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java ce5dccd
> sandbox/prototype/exec/java-exec/src/test/resources/functions/testMathFunctions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13760/diff/
>
>
> Testing
> -------
>
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueInt
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueBigInt
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat4
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat8
>
>
> Thanks,
>
> Tanujit Ghosh
>
>
Re: Review Request 13760: DRILL-182 : abs() function implementation
Posted by Tanujit Ghosh <ta...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13760/
-----------------------------------------------------------
(Updated Aug. 29, 2013, 2:47 a.m.)
Review request for drill.
Summary (updated)
-----------------
DRILL-182 : abs() function implementation
Repository: drill-git
Description
-------
Implementation of the abs() function within DRILL.
Diffs
-----
sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java 311e715
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java 78630ba
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java ce5dccd
sandbox/prototype/exec/java-exec/src/test/resources/functions/testMathFunctions.json PRE-CREATION
Diff: https://reviews.apache.org/r/13760/diff/
Testing
-------
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueInt
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueBigInt
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat4
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat8
Thanks,
Tanujit Ghosh
Re: Review Request 13760: DRILL abs() function implementation
Posted by Tanujit Ghosh <ta...@gmail.com>.
Gentle reminder.
On Fri, Aug 23, 2013 at 9:48 AM, Tanujit Ghosh <ta...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13760/
> Review request for drill.
> By Tanujit Ghosh.
>
> *Updated Aug. 23, 2013, 4:18 a.m.*
> Changes
>
> Uploaded the diff again as i had made a mistake the first time
>
> *Repository: * drill-git
> Description
>
> Implementation of the abs() function within DRILL.
>
> Testing
>
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueInt
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueBigInt
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat4
> org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat8
>
> Diffs (updated)
>
> - sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java
> (311e715)
> - sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java
> (78630ba)
> - sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java
> (ce5dccd)
> - sandbox/prototype/exec/java-exec/src/test/resources/functions/testMathFunctions.json
> (PRE-CREATION)
>
> View Diff <https://reviews.apache.org/r/13760/diff/>
>
--
Regards,
Tanujit
Re: Review Request 13760: DRILL abs() function implementation
Posted by Tanujit Ghosh <ta...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13760/
-----------------------------------------------------------
(Updated Aug. 23, 2013, 4:18 a.m.)
Review request for drill.
Changes
-------
Uploaded the diff again as i had made a mistake the first time
Repository: drill-git
Description
-------
Implementation of the abs() function within DRILL.
Diffs (updated)
-----
sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/FixedValueVectors.java 311e715
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/MathFunctions.java 78630ba
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFunctions.java ce5dccd
sandbox/prototype/exec/java-exec/src/test/resources/functions/testMathFunctions.json PRE-CREATION
Diff: https://reviews.apache.org/r/13760/diff/
Testing
-------
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueInt
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueBigInt
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat4
org.apache.drill.exec.physical.impl.TestSimpleFunctions.testAbsoluteValueFloat8
Thanks,
Tanujit Ghosh