[GitHub] [knox] risdenk commented on a change in pull request #159: KNOX-2027 - Need a reverse order sort on a table based on a column.

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #159: KNOX-2027 - Need a reverse order sort on a table based on a column.
URL: https://github.com/apache/knox/pull/159#discussion_r329571374
 
 

 ##########
 File path: gateway-shell/src/main/java/org/apache/knox/gateway/shell/table/KnoxShellTable.java
 ##########
 @@ -122,6 +124,10 @@ public KnoxShellTable select(String cols) {
   }
 
   public KnoxShellTable sort(String colName) {
+    return sort(colName, SortOrder.ASCENDING);
+  }
+
+  public KnoxShellTable sort(String colName, SortOrder order) {
 
 Review comment:
   Does public make sense here? Can SortOrder be passed in from the shell or will it always need to be a string?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services