You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Andreas Sewe (JIRA)" <ji...@codehaus.org> on 2012/02/09 15:22:02 UTC
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Andreas Sewe created MSKINS-28:
----------------------------------
Summary: Make it possible to center "powered by" logos in sidebar
Key: MSKINS-28
URL: https://jira.codehaus.org/browse/MSKINS-28
Project: Maven Skins
Issue Type: Wish
Components: Fluido Skin
Affects Versions: fluido-1.1
Reporter: Andreas Sewe
Priority: Minor
Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Andreas Sewe (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=294318#comment-294318 ]
Andreas Sewe commented on MSKINS-28:
------------------------------------
Thanks, Bruno. That solves the problem for one project. It gets tedious, however, if you have dozens of them, as a custom site.css is not inherited. (At least, I don't know a way to inherit a resource from parent to child project.)
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Priority: Minor
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Andreas Sewe (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=295259#comment-295259 ]
Andreas Sewe commented on MSKINS-28:
------------------------------------
Unfortunately, as I just discovered, the fix doesn't quite work as soon as you have *multiple* "powered by" logos.
Compare the left sidebars of the following two sites, for example: http://www.alia4j.org/alia4j/ (fluido 1.1) and http://stage.alia4j.org/alia4j/ (fluido 1.2). When viewing the latter in a browser whose viewport is wide enough (1920px works; alternatively adjust the logos' width using Firebug or some such), the two logos (AOSD Europe, CASED) are shown side by side, which can be quite ugly, depending on the logos' sizes and aspect ratios.
IMHO, turning the images into block-level elements and centering those would be a better solution than centering them as inline-level elements with {{text-align}}:
{quote}
img.poweredBy {
display: block;
margin-left: auto;
margin-right: auto;
}
{quote}
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Simone Tripodi
> Priority: Minor
> Fix For: fluido-1.2
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Simone Tripodi (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=295261#comment-295261 ]
Simone Tripodi commented on MSKINS-28:
--------------------------------------
Thankjs for the feedbacks Andreas - can you provide please a patch with a testcase? It will be much more than appreciated!
Many thanks in advance, all the best!
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Simone Tripodi
> Priority: Minor
> Fix For: fluido-1.2
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Andreas Sewe (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Sewe updated MSKINS-28:
-------------------------------
Attachment: maven-theme.patch
Added a patch to accompany the integration test. (CSS tested on Firefox 11 only.)
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Simone Tripodi
> Priority: Minor
> Fix For: fluido-1.2
>
> Attachments: maven-theme.patch, mskins-28-it.patch
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Simone Tripodi (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=295274#comment-295274 ]
Simone Tripodi commented on MSKINS-28:
--------------------------------------
GREAT, thanks a lot! I'll review the patch ASAP!
best,
-Simo
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Simone Tripodi
> Priority: Minor
> Fix For: fluido-1.2
>
> Attachments: mskins-28-it.patch
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Andreas Sewe (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Sewe reopened MSKINS-28:
--------------------------------
See my previous comment on problems with multiple "powered by" logos.
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Simone Tripodi
> Priority: Minor
> Fix For: fluido-1.2
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=302629#comment-302629 ]
Robert Scholte edited comment on MSKINS-28 at 7/3/12 2:51 PM:
--------------------------------------------------------------
Fixed in [r1356876|http://svn.apache.org/viewvc?rev=1356876&view=rev]
I don't see the issue with the large logo's.
I can imagine that logo's next to eachother might look odd, it just depends on the sizes. But having them under eachother seems like a safe solution.
Thanks for the patch!
was (Author: rfscholte):
Fixed in [r1356876|http://svn.apache.org/viewvc?rev=1356876&view=rev]
I don't see the issue with the large logo's.
I can imagine that logo's next to eachother might look odd, it just depends on the sizes. But having them under eachother seems like a save solution.
Thanks for the patch!
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Robert Scholte
> Priority: Minor
> Fix For: fluido-1.2.2
>
> Attachments: maven-theme.patch, mskins-28-it.patch
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Simone Tripodi (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi updated MSKINS-28:
---------------------------------
Fix Version/s: fluido-1.2
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Simone Tripodi
> Priority: Minor
> Fix For: fluido-1.2
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Simone Tripodi (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simone Tripodi closed MSKINS-28.
--------------------------------
Resolution: Fixed
fixed on {{trunk}} see [r1301988|http://svn.apache.org/viewvc?rev=1301988&view=rev] thanks Bruno for the suggestion!
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Simone Tripodi
> Priority: Minor
> Fix For: fluido-1.2
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Andreas Sewe (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=302549#comment-302549 ]
Andreas Sewe commented on MSKINS-28:
------------------------------------
I just build a 1.3-SNAPSHOT. There are still two problems present, both due to the {{img.poweredBy}} being inline rather than block-level content:
* If the images are small, several may end up next to each other.
* If an image is larger than the sidebar, however, its edges are cut off.
You can experiment with this by explicitly setting the {{logo}}'s {{width}} in your {{site.xml}}.
If you move to block-level content, you avoid the first issue as non-floating blocks cannot sit side-by-side and the second issue because the contained block pushes the boundaries of its container (the sidebar).
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Simone Tripodi
> Priority: Minor
> Fix For: fluido-1.2
>
> Attachments: maven-theme.patch, mskins-28-it.patch
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte closed MSKINS-28.
--------------------------------
Resolution: Fixed
Fix Version/s: (was: fluido-1.2)
fluido-1.2.2
Assignee: Robert Scholte (was: Simone Tripodi)
Fixed in [r1356876|http://svn.apache.org/viewvc?rev=1356876&view=rev]
I don't see the issue with the large logo's.
I can imagine that logo's next to eachother might look odd, it just depends on the sizes. But having them under eachother seems like a save solution.
Thanks for the patch!
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Robert Scholte
> Priority: Minor
> Fix For: fluido-1.2.2
>
> Attachments: maven-theme.patch, mskins-28-it.patch
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Bruno P. Kinoshita (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=293827#comment-293827 ]
Bruno P. Kinoshita commented on MSKINS-28:
------------------------------------------
Hello, in order to center align the powered-by logos, you can create a custom site.css in src/resources/css/site.css. Inside this file, put the following CSS:
#poweredBy {
text-align: center;
}
It will align the powered-by logos, without the need to change the skin's code :-)
Hope that helps.
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Priority: Minor
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=302492#comment-302492 ]
Robert Scholte commented on MSKINS-28:
--------------------------------------
@Andreas, could you verify if the patch is still required? I've updated the version of bootstrap and I don't see any real difference.
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Simone Tripodi
> Priority: Minor
> Fix For: fluido-1.2
>
> Attachments: maven-theme.patch, mskins-28-it.patch
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MSKINS-28) Make it possible to center "powered by" logos in
sidebar
Posted by "Andreas Sewe (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MSKINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Sewe updated MSKINS-28:
-------------------------------
Attachment: mskins-28-it.patch
Integration test using 5 different-sized "powered by" logos.
> Make it possible to center "powered by" logos in sidebar
> --------------------------------------------------------
>
> Key: MSKINS-28
> URL: https://jira.codehaus.org/browse/MSKINS-28
> Project: Maven Skins
> Issue Type: Wish
> Components: Fluido Skin
> Affects Versions: fluido-1.1
> Reporter: Andreas Sewe
> Assignee: Simone Tripodi
> Priority: Minor
> Fix For: fluido-1.2
>
> Attachments: mskins-28-it.patch
>
>
> Left alignment may look OK for badge-like logos like <http://maven.apache.org/skins/maven-fluido-skin/images/logos/maven-feather.png>, but is quite ugly for other types of logo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira