You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2004/11/26 01:17:40 UTC

Re: svn commit: r12027 - trunk

julianfoad@tigris.org wrote:

>Author: julianfoad
>Date: Wed Nov 24 19:32:13 2004
>New Revision: 12027
>
>Modified:
>   trunk/configure.in
>Log:
>Fix APR version expression (r12026).
>
>* configure.in
>  (APR_VER_REGEX, APU_VER_REGEX): Rewrite without "\(" and "\)".
>  
>
Either this commit or the previous one somehow broke the build on FreeBSD.

-- Brane



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Breakage list [was: Re: svn commit: r12027 - trunk]

Posted by Branko Čibej <br...@xbc.nu>.
Julian Foad wrote:

> Branko Čibej wrote:
>
>> Read svn-breakage, it's all there. I'll say again that IMNSHO 
>> everyons who commits code changes should subscribe to svn-breakage 
>> and check at least the FAILed test runs.
>
>
> That's fair enough in principle.  I've just re-subscribed and set a 
> filter to discard the "PASS" emails.
>
> However, if I was still using a modem, I would be very reluctant to 
> subscribe because of the high volume of traffic on that list - 
> currently around 2000 emails per month, and they are not tiny.

Well, the PASS mails are about 2k... multiplied by 2000, that's probably 
more than you want to download, yes.

> Would you consider posting only a summary of passes?

Not "I", "we" as in "the SVN project"

> Or providing a list that sends only the failures?

Hmmm...

> I think you said before that you like to see the passes, to know that 
> they are actually being tested, but I wonder if that still applies now 
> that there are so many that it is not feasible to even look carefully 
> at the Subject lines.  Perhaps it would be better to set up an 
> automatic monitoring agent to check that all of your intended tests 
> are either passing or sending a failure email?  This could 
> infrequently (say weekly) send a summary of which tests have been run.

Well, it's really the test framework's job to do things like that. 
Patches are always welcome. :-)

-- Brane



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Breakage list [was: Re: svn commit: r12027 - trunk]

Posted by Julian Foad <ju...@btopenworld.com>.
Branko Čibej wrote:
> Read svn-breakage, it's all there. I'll say again that IMNSHO everyons 
> who commits code changes should subscribe to svn-breakage and check at 
> least the FAILed test runs.

That's fair enough in principle.  I've just re-subscribed and set a filter to 
discard the "PASS" emails.

However, if I was still using a modem, I would be very reluctant to subscribe 
because of the high volume of traffic on that list - currently around 2000 
emails per month, and they are not tiny.

Would you consider posting only a summary of passes?  Or providing a list that 
sends only the failures?  I think you said before that you like to see the 
passes, to know that they are actually being tested, but I wonder if that still 
applies now that there are so many that it is not feasible to even look 
carefully at the Subject lines.  Perhaps it would be better to set up an 
automatic monitoring agent to check that all of your intended tests are either 
passing or sending a failure email?  This could infrequently (say weekly) send 
a summary of which tests have been run.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12027 - trunk

Posted by Philip Martin <ph...@codematters.co.uk>.
Branko Čibej <br...@xbc.nu> writes:

> Yes, '|' is a literal in basic RE, but '\|' should be an
> operator. Same goes for '()' vs. '\(\)'. At least that's how basic REs
> work on all the systems I've ever worked with...

No, only extended REs support operator '|'.  FreeBSD's re_format(7)
states:

   `|' is an ordinary character and there is no equivalent for its
   functionality.

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12027 - trunk

Posted by Branko Čibej <br...@xbc.nu>.
Philip Martin wrote:

>Branko ÄŒibej <br...@xbc.nu> writes:
>
>  
>
>>Julian Foad wrote:
>>
>>    
>>
>>>Branko ÄŒibej wrote:
>>>
>>>      
>>>
>>>>brane@mithril:~$ expr '0.9.5' : '0\.9\.[5-9]\|0\.9\.[1-9][0-9]'
>>>>0
>>>>        
>>>>
>>>Thanks.  I don't know why that doesn't work as I expect it to and as
>>>it works on most systems, but I've reverted that part of the change
>>>in r12044.
>>>      
>>>
>>I tried several variants, but not one with '\|' worked. I don't know
>>why, either.
>>    
>>
>
>It's an extended RE and the FreeBSD manpage expr(1) states that a
>basic RE is to be used, thus '|' is a literal not an operator.
>  
>
Yes, '|' is a literal in basic RE, but '\|' should be an operator. Same 
goes for '()' vs. '\(\)'. At least that's how basic REs work on all the 
systems I've ever worked with...

Ah well, we can always pipe through egrep instead and use extended REs, 
which are nicer to read anyway.

-- Brane



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12027 - trunk

Posted by Philip Martin <ph...@codematters.co.uk>.
Branko Čibej <br...@xbc.nu> writes:

> Julian Foad wrote:
>
>> Branko Čibej wrote:
>>
>>> brane@mithril:~$ expr '0.9.5' : '0\.9\.[5-9]\|0\.9\.[1-9][0-9]'
>>> 0
>>
>> Thanks.  I don't know why that doesn't work as I expect it to and as
>> it works on most systems, but I've reverted that part of the change
>> in r12044.
>
> I tried several variants, but not one with '\|' worked. I don't know
> why, either.

It's an extended RE and the FreeBSD manpage expr(1) states that a
basic RE is to be used, thus '|' is a literal not an operator.

-- 
Philip Martin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12027 - trunk

Posted by Branko Čibej <br...@xbc.nu>.
Julian Foad wrote:

> Branko Čibej wrote:
>
>> brane@mithril:~$ uname -rs
>> FreeBSD 5.0-RELEASE
>> brane@mithril:~$ expr '0.9.5' : '0\.9\.[5-9]\|0\.9\.[1-9][0-9]'
>> 0
>> brane@mithril:~$ expr '0.9.5' : '0\.9\.[5-9]'
>> 5
>
>
> Thanks.  I don't know why that doesn't work as I expect it to and as 
> it works on most systems, but I've reverted that part of the change in 
> r12044.

I tried several variants, but not one with '\|' worked. I don't know 
why, either.

> (We don't have an urgent need to support APR versions 0.9.(>= 10) but 
> if and when anyone wants to revisit this version-checking code I 
> suggest accepting just one regexp and allowing it to be an arbitrary 
> regexp with grouping and alternation, say by using "echo $VERSION | 
> grep ^$REGEXP" instead of testing two separate regexps with "expr 
> $VERSION : $REGEXP" commands.)

We'll burn that bridge when we get to it. :-)

> Sorry for the breakage.

Hey, that's what the automatic tests are for, after all. :-)


-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12027 - trunk

Posted by Julian Foad <ju...@btopenworld.com>.
Branko Čibej wrote:
> brane@mithril:~$ uname -rs
> FreeBSD 5.0-RELEASE
> brane@mithril:~$ expr '0.9.5' : '0\.9\.[5-9]\|0\.9\.[1-9][0-9]'
> 0
> brane@mithril:~$ expr '0.9.5' : '0\.9\.[5-9]'
> 5

Thanks.  I don't know why that doesn't work as I expect it to and as it works 
on most systems, but I've reverted that part of the change in r12044.

(We don't have an urgent need to support APR versions 0.9.(>= 10) but if and 
when anyone wants to revisit this version-checking code I suggest accepting 
just one regexp and allowing it to be an arbitrary regexp with grouping and 
alternation, say by using "echo $VERSION | grep ^$REGEXP" instead of testing 
two separate regexps with "expr $VERSION : $REGEXP" commands.)

Sorry for the breakage.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12027 - trunk

Posted by Branko Čibej <br...@xbc.nu>.
Julian Foad wrote:

> Branko Čibej wrote:
>
>> Read svn-breakage, it's all there. I'll say again that IMNSHO 
>> everyons who commits code changes should subscribe to svn-breakage 
>> and check at least the FAILed test runs.
>
>
> I've checked the archive for this particular problem.
>
> Could you please try and tell me the result of this command on that 
> system:
>
> expr "0.9.5" : "0\.9\.[5-9]\|0\.9\.[1-9][0-9]"
>
> It should print the number "5", being the number of characters that 
> match the regexp.

brane@mithril:~$ uname -rs
FreeBSD 5.0-RELEASE
brane@mithril:~$ expr '0.9.5' : '0\.9\.[5-9]\|0\.9\.[1-9][0-9]'
0
brane@mithril:~$ expr '0.9.5' : '0\.9\.[5-9]'
5

-- Brane



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12027 - trunk

Posted by Julian Foad <ju...@btopenworld.com>.
Branko Čibej wrote:
> Read svn-breakage, it's all there. I'll say again that IMNSHO everyons 
> who commits code changes should subscribe to svn-breakage and check at 
> least the FAILed test runs.

I've checked the archive for this particular problem.

Could you please try and tell me the result of this command on that system:

expr "0.9.5" : "0\.9\.[5-9]\|0\.9\.[1-9][0-9]"

It should print the number "5", being the number of characters that match the 
regexp.

Thanks.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12027 - trunk

Posted by Branko Čibej <br...@xbc.nu>.
Julian Foad wrote:

> Branko Čibej wrote:
>
>> julianfoad@tigris.org wrote:
>>
>>> Fix APR version expression (r12026).
>>>
>>> * configure.in
>>>  (APR_VER_REGEX, APU_VER_REGEX): Rewrite without "\(" and "\)".
>>>
>> Either this commit or the previous one somehow broke the build on 
>> FreeBSD.
>
>
> Thanks for reporting a problem.  I could just revert the change but I 
> would prefer it if you could tell me in what way it broke so that I 
> could fix it. Thanks.

Read svn-breakage, it's all there. I'll say again that IMNSHO everyons 
who commits code changes should subscribe to svn-breakage and check at 
least the FAILed test runs.

-- Brane



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r12027 - trunk

Posted by Julian Foad <ju...@btopenworld.com>.
Branko Čibej wrote:
> julianfoad@tigris.org wrote:
>> Fix APR version expression (r12026).
>>
>> * configure.in
>>  (APR_VER_REGEX, APU_VER_REGEX): Rewrite without "\(" and "\)".
>>
> Either this commit or the previous one somehow broke the build on FreeBSD.

Thanks for reporting a problem.  I could just revert the change but I would 
prefer it if you could tell me in what way it broke so that I could fix it. 
Thanks.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org