You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by tedyu <gi...@git.apache.org> on 2017/04/03 22:51:09 UTC
[GitHub] eagle pull request #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
GitHub user tedyu opened a pull request:
https://github.com/apache/eagle/pull/902
[EAGLE-985] Upgrade hbase dependency to 1.2.5
Upgrade hbase dependency to 1.2.5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tedyu/eagle master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/902.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #902
----
commit 9c18fbb82920e75d6b0319bc00e47db16b8b9efd
Author: tedyu <yu...@gmail.com>
Date: 2017-04-03T22:49:21Z
EAGLE-985 Upgrade hbase dependency to 1.2.5
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:
https://github.com/apache/eagle/pull/902
@jhsenjaliya @tedyu After this upgrade, does we still support HBase 0.98?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by qingwen220 <gi...@git.apache.org>.
Github user qingwen220 commented on the issue:
https://github.com/apache/eagle/pull/902
Yes. We expect after 0.5, Eagle can support Kafka 0.10 & storm 0.10.
There is a concern. We have a coprocessor module in Eagle for HBase 0.98. I am not sure if we could support this function after upgrade
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by baibaichen <gi...@git.apache.org>.
Github user baibaichen commented on the issue:
https://github.com/apache/eagle/pull/902
hi @tedyu
Is the new API you used supported in 1.0.x?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/902
@qingwen220 , @r7raul1984 looks like we can accommodate hbase 1.2.5 with or without this PR changes but I havent tested with hbase coprocessor enabled. so if someone can test current eagle code with hbase 1.2.5 with coprocessor enabled, we can make decision on whether we can include hbase upgrade in eagle 0.5 or later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/902
Hi @qingwen220 no, since there are some function signature changes here, I dont think it will be compatible. ( without those changes, it is compatible though) so the question really comes down to whether we want to support 0.98 till 0.5 release then this can be pushed to 0.6 when majority of the tech stack is going to change ( storm, kafka, etc..), comment?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the issue:
https://github.com/apache/eagle/pull/902
Yes. But hbase 1.0 wouldn't have any more new release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by r7raul1984 <gi...@git.apache.org>.
Github user r7raul1984 commented on the issue:
https://github.com/apache/eagle/pull/902
@wujinhu +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/902
master works fine with hbase 1.2.2
I am planning to test this patch with hbase 1.2.5 tonight
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by wujinhu <gi...@git.apache.org>.
Github user wujinhu commented on the issue:
https://github.com/apache/eagle/pull/902
Should we have multiple version support for HBase(Storm/Kafka etc) so that users can still use old versions if they cannot switch to new version quickly?
I think it will be better if we have some abstractions first instead of doing like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by tedyu <gi...@git.apache.org>.
Github user tedyu commented on the issue:
https://github.com/apache/eagle/pull/902
@jhsenjaliya
Did you find any issue during testing ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/902
@tedyu I pulled your PR and used ur code to run my eagle, I am running alert engine app + hdfs audit log app and it successfully created the alert i was expecting. so this PR is working fine. but As i mentioned earlier, I was using hbase 1.2.2 and also tested hbase 1.2.5 without any code change to eagle and it was working fine as well. so probably these changes are not mandatory but good to follow newer hbase functions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by r7raul1984 <gi...@git.apache.org>.
Github user r7raul1984 commented on the issue:
https://github.com/apache/eagle/pull/902
In my opition ,we should do more test before upgrade to hbase 1.2.5 rather than just solve compile problem .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #902: [EAGLE-985] Upgrade hbase dependency to 1.2.5
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/902
+1, LGTM, I will be testing this on my dev environment as well sometime tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---