You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by "Robert Muir (Jira)" <ji...@apache.org> on 2022/05/10 03:36:00 UTC

[jira] [Commented] (LUCENE-9356) Add tests for corruptions caused by byte flips

    [ https://issues.apache.org/jira/browse/LUCENE-9356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534116#comment-17534116 ] 

Robert Muir commented on LUCENE-9356:
-------------------------------------

The test seems wrong to me, for example it does not consider CRC-32 collisions. I think we should just remove the test for this reason.

> Add tests for corruptions caused by byte flips
> ----------------------------------------------
>
>                 Key: LUCENE-9356
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9356
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Adrien Grand
>            Priority: Minor
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> We already have tests that file truncation and modification of the index headers are caught correctly. I'd like to add another test that flipping a byte in a way that modifies the checksum of the file is always caught gracefully by Lucene.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org