You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by pt...@apache.org on 2025/07/11 14:30:20 UTC
(ignite-3) 38/45: wip autogenerated column TODOs
This is an automated email from the ASF dual-hosted git repository.
ptupitsyn pushed a commit to branch ignite-22133-bak
in repository https://gitbox.apache.org/repos/asf/ignite-3.git
commit 0b40fc105399331435e5e1460a2e66f020678874
Author: Pavel Tupitsyn <pt...@apache.org>
AuthorDate: Fri Jul 11 15:34:12 2025 +0300
wip autogenerated column TODOs
---
.../MusicStoreIgniteTest.cs | 1 +
.../Update/Internal/IgniteUpdateSqlGenerator.cs | 5 +++--
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/modules/platforms/dotnet/Apache.Ignite.EntityFrameworkCore.FunctionalTests/MusicStoreIgniteTest.cs b/modules/platforms/dotnet/Apache.Ignite.EntityFrameworkCore.FunctionalTests/MusicStoreIgniteTest.cs
index f3141ed8ce4..50864daeb20 100644
--- a/modules/platforms/dotnet/Apache.Ignite.EntityFrameworkCore.FunctionalTests/MusicStoreIgniteTest.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.EntityFrameworkCore.FunctionalTests/MusicStoreIgniteTest.cs
@@ -26,6 +26,7 @@ public class MusicStoreIgniteTest : MusicStoreTestBase<MusicStoreIgniteTest.Musi
public MusicStoreIgniteTest(MusicStoreIgniteFixture fixture)
: base(fixture)
{
+ // TODO: This requires auto-increment ID columns, which are not supported by Ignite?
}
public class MusicStoreIgniteFixture : MusicStoreFixtureBase
diff --git a/modules/platforms/dotnet/Apache.Ignite.EntityFrameworkCore/Update/Internal/IgniteUpdateSqlGenerator.cs b/modules/platforms/dotnet/Apache.Ignite.EntityFrameworkCore/Update/Internal/IgniteUpdateSqlGenerator.cs
index 82dc63d937f..2606b220cb7 100644
--- a/modules/platforms/dotnet/Apache.Ignite.EntityFrameworkCore/Update/Internal/IgniteUpdateSqlGenerator.cs
+++ b/modules/platforms/dotnet/Apache.Ignite.EntityFrameworkCore/Update/Internal/IgniteUpdateSqlGenerator.cs
@@ -34,7 +34,8 @@ public class IgniteUpdateSqlGenerator : UpdateAndSelectSqlGenerator
// SqlGenerationHelper.DelimitIdentifier(commandStringBuilder, "rowid");
// commandStringBuilder.Append(" = ").Append("last_insert_rowid()");
- // TODO: Why do we need this?
+
+ // TODO: This is needed to obtain the last inserted row ID for auto-increment columns.
commandStringBuilder.Append("1 = 1");
}
@@ -50,7 +51,7 @@ public class IgniteUpdateSqlGenerator : UpdateAndSelectSqlGenerator
protected override void AppendRowsAffectedWhereCondition(StringBuilder commandStringBuilder, int expectedRowsAffected)
{
- // TODO: Why do we need this?
+ // TODO: This is needed to obtain the last inserted row ID for auto-increment columns.
commandStringBuilder.Append("1 = 1");
}