You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/23 05:22:48 UTC

[GitHub] [cloudstack] davidjumani commented on a change in pull request #5237: [UI] Add Shift key for noVNC consoles

davidjumani commented on a change in pull request #5237:
URL: https://github.com/apache/cloudstack/pull/5237#discussion_r675313414



##########
File path: systemvm/agent/noVNC/app/ui.js
##########
@@ -1551,6 +1553,17 @@ const UI = {
         }
     },
 
+    toggleShift() {
+        const btn = document.getElementById('noVNC_toggle_shift_button');
+        if (btn.classList.contains("noVNC_selected")) {
+            UI.sendKey(KeyTable.XK_Shift_L, "ShiftLeft", false);
+            btn.classList.remove("noVNC_selected");
+        } else {
+            UI.sendKey(KeyTable.XK_Control_L, "ShiftLeft", true);

Review comment:
       ```suggestion
               UI.sendKey(KeyTable.XK_Shift_L, "ShiftLeft", true);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org