Re: CVS update: subversion/subversion/include svn_fs.h

[Karl Fogel <kf...@galois.collab.net>]

Greg Stein <gs...@lyra.org> writes:
> Where does that log message come from, and why does it need to be delivered
> from the editor back to a hook?

You're right, the log_msg argument doesn't belong here.  The driver
already has it.  I'll get it out of there.

> Does the thing that drives the editor already know what the log message is?

See above.

Thanks,
-Karl

Re: CVS update: subversion/subversion/include svn_fs.h

[Karl Fogel <kf...@galois.collab.net>]

Greg Stein <gs...@lyra.org> writes:
> An interesting question is how the commit driver passes the log message into
> the editor. I'm guessing that it would actually be another parameter to the
> get_commit_editor() function.
> [ and stashed in the edit_baton as necessary ]

Yup, I think that makes the most sense.  Not that it had occurred to
me yet or anything -- thanks for the suggestion! :-)

-K

Re: CVS update: subversion/subversion/include svn_fs.h

[Greg Stein <gs...@lyra.org>]

On Tue, Feb 06, 2001 at 04:57:34PM -0600, Karl Fogel wrote:
> Greg Stein <gs...@lyra.org> writes:
> > Where does that log message come from, and why does it need to be delivered
> > from the editor back to a hook?
> 
> You're right, the log_msg argument doesn't belong here.  The driver
> already has it.  I'll get it out of there.
> 
> > Does the thing that drives the editor already know what the log message is?
> 
> See above.

An interesting question is how the commit driver passes the log message into
the editor. I'm guessing that it would actually be another parameter to the
get_commit_editor() function.
[ and stashed in the edit_baton as necessary ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/