You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/27 08:28:29 UTC

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1151: build: create build-parent-it pom to collect common integration tests set-up

ppalaga commented on a change in pull request #1151:
URL: https://github.com/apache/camel-quarkus/pull/1151#discussion_r415613730



##########
File path: tooling/create-extension-templates/parent-pom.xml
##########
@@ -23,9 +23,9 @@
     <modelVersion>4.0.0</modelVersion>
     <parent>
         <groupId>org.apache.camel.quarkus</groupId>
-        <artifactId>camel-quarkus-build-parent</artifactId>
+        <artifactId>camel-quarkus-build-parent-it</artifactId>
         <version>[=version]</version>
-        <relativePath>../../poms/build-parent/pom.xml</relativePath>
+        <relativePath>../../poms/build-parent-it/pom.xml</relativePath>

Review comment:
       I think this should stay as is. This the template for the parent of runtime and deployment modules.
   
   The template that needs change is `tooling/create-extension-templates/integration-test-pom.xml`. I think we can hardcode the artifactId `camel-quarkus-build-parent-it` there.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org