You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/03/30 02:40:51 UTC
[GitHub] [daffodil-vscode] tuxji commented on a change in pull request #96: RC2 Updates
tuxji commented on a change in pull request #96:
URL: https://github.com/apache/daffodil-vscode/pull/96#discussion_r838057990
##########
File path: build/bin.NOTICE
##########
@@ -165,7 +181,7 @@ ip4s (lib/com.comcast:ip4s-core.jar-<VERSION>.jar)
Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar)
Apache Commons Lang
- Copyright 2001-2021 The Apache Software Foundation
-
+ Copyright 2001-2022 The Apache Software Foundation
+
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
Review comment:
Yes, I removed the dependencies that do not have a NOTICE file in my Daffodil PR's final changes as Steve suggested. I'll upload my suggested edits directly to this PR as well.
##########
File path: build/bin.NOTICE
##########
@@ -77,9 +84,6 @@ Apache XML Commons Resolver (lib/xml-resolver.xml-resolver-<VERSION>.jar)
Apache XML Commons Resolver
Copyright 2006 The Apache Software Foundation.
- This product includes software developed at
- The Apache Software Foundation http://www.apache.org/
-
Review comment:
I've removed these lines in my edits.
##########
File path: build/bin.LICENSE
##########
@@ -2207,3 +2207,537 @@
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+ This product bundles 'Saxon-HE (Home Edition)', including the following files:
+ - lib/net.sf.saxon.Saxon-HE-<VERSION>.jar in in daffodil-debugger-<VERSION>.zip
+ These files are available under the MPL 2.0 license:
+
+ Most of the open source code in the Saxon product is governed by the Mozilla Public
Review comment:
Saxon is gone now, but I've rearranged the lines mentioning each jar and its license to make it easier to understand which files are covered by which licenses.
##########
File path: build/bin.NOTICE
##########
@@ -169,3 +166,71 @@ Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar)
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
+
+Apache Commons Codec (lib/commons-codec.commons-codec-<VERSION>.jar)
+ Apache Commons Codec
+ Copyright 2002-2017 The Apache Software Foundation
+
+ src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java
+ contains test data from http://aspell.net/test/orig/batch0.tab.
+ Copyright (C) 2002 Kevin Atkinson (kevina@gnu.org)
+
+ ===============================================================================
+
+ The content of package org.apache.commons.codec.language.bm has been translated
+ from the original php source code available at http://stevemorse.org/phoneticinfo.htm
+ with permission from the original authors.
+ Original source copyright:
+ Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
+
+Apache Commons Logging (lib/commons-logging.commons-logging-<VERSION>.jar)
+ Apache Commons Logging
+ Copyright 2003-2014 The Apache Software Foundation
+
+Apache HttpClient (lib/org.apache.httpcomponents.httpclient-<VERSION>.jar)
+ Apache HttpClient
+ Copyright 1999-2020 The Apache Software Foundation
+
+Apache HttpCore (lib/org.apache.httpcomponents.httpcore-<VERSION>.jar)
+ Apache HttpCore
+ Copyright 2005-2020 The Apache Software Foundation
+
+Apache Log4j (lib/org.apache.logging.log4j.log4j-api-<VERSION>.jar, org.apache.logging.log4j.log4j-core-<VERSION>.jar)
+ Apache Log4j
+ Copyright 1999-2019 Apache Software Foundation
+
+ This product includes software developed at
+ The Apache Software Foundation (http://www.apache.org/).
+
+ ResolverUtil.java
+ Copyright 2005-2006 Tim Fennell
+
+ Dumbster SMTP test server
Review comment:
Aye, I took a pass at this and updated bin.LICENSE and bin.NOTICE. I noticed that many jars don't have LICENSE or NOTICE files in them but I didn't take the extra time to visit their source repositories and check for LICENSE/NOTICE files there as well, so I don't promise that my edits are the last word. I just want to give these files a better foundation for the 1.0.0 release and let future PRs improve them.
##########
File path: build/bin.LICENSE
##########
@@ -2207,3 +2207,537 @@
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+ This product bundles 'Saxon-HE (Home Edition)', including the following files:
Review comment:
Actually we can remove the Saxon license because daffodil-debugger does not depend on daffodil-schematron, and therefore does not include Saxon or its transitive dependencies in the daffodil-debugger zip file. It's important to build the extension and then look inside daffodil-debugger.zip to see which jars daffodil-debugger actually uses instead of simply starting with a copy of Daffodil's bin.LICENSE and bin.NOTICE. I was surprised how many differences I found between Daffodil's libs and daffodil-debugger's libs once I actually compared the libs. I don't simply see a superset or subset of one's libs in the other's libs; some dependencies even have different versions. We only just released Daffodil 3.3.0, so there hasn't been enough time for Daffodil to bump some dependency versions to newer versions yet. Someone will have to look closely at how daffodil-debugger specifies its dependencies and figure out why certain dependencies have different versions.
P.S. I know why the versions are different now - when I built the extension, I'd checked out the main branch but the main branch is still using Daffodil 3.2.1, not 3.3.0.
##########
File path: build/bin.NOTICE
##########
@@ -169,3 +166,71 @@ Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar)
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
+
+Apache Commons Codec (lib/commons-codec.commons-codec-<VERSION>.jar)
+ Apache Commons Codec
+ Copyright 2002-2017 The Apache Software Foundation
+
+ src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java
+ contains test data from http://aspell.net/test/orig/batch0.tab.
+ Copyright (C) 2002 Kevin Atkinson (kevina@gnu.org)
+
+ ===============================================================================
+
+ The content of package org.apache.commons.codec.language.bm has been translated
+ from the original php source code available at http://stevemorse.org/phoneticinfo.htm
+ with permission from the original authors.
+ Original source copyright:
+ Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
+
+Apache Commons Logging (lib/commons-logging.commons-logging-<VERSION>.jar)
+ Apache Commons Logging
+ Copyright 2003-2014 The Apache Software Foundation
+
+Apache HttpClient (lib/org.apache.httpcomponents.httpclient-<VERSION>.jar)
+ Apache HttpClient
+ Copyright 1999-2020 The Apache Software Foundation
+
+Apache HttpCore (lib/org.apache.httpcomponents.httpcore-<VERSION>.jar)
+ Apache HttpCore
+ Copyright 2005-2020 The Apache Software Foundation
+
+Apache Log4j (lib/org.apache.logging.log4j.log4j-api-<VERSION>.jar, org.apache.logging.log4j.log4j-core-<VERSION>.jar)
Review comment:
Done.
##########
File path: build/bin.NOTICE
##########
@@ -169,3 +166,71 @@ Apache Commons Lang (lib/org.apache.commons:commons-lang3-<VERSION>.jar)
This product includes software developed at
The Apache Software Foundation (https://www.apache.org/).
+
+Apache Commons Codec (lib/commons-codec.commons-codec-<VERSION>.jar)
+ Apache Commons Codec
+ Copyright 2002-2017 The Apache Software Foundation
+
+ src/test/org/apache/commons/codec/language/DoubleMetaphoneTest.java
+ contains test data from http://aspell.net/test/orig/batch0.tab.
+ Copyright (C) 2002 Kevin Atkinson (kevina@gnu.org)
+
+ ===============================================================================
+
+ The content of package org.apache.commons.codec.language.bm has been translated
+ from the original php source code available at http://stevemorse.org/phoneticinfo.htm
+ with permission from the original authors.
+ Original source copyright:
+ Copyright (c) 2008 Alexander Beider & Stephen P. Morse.
+
+Apache Commons Logging (lib/commons-logging.commons-logging-<VERSION>.jar)
+ Apache Commons Logging
+ Copyright 2003-2014 The Apache Software Foundation
+
+Apache HttpClient (lib/org.apache.httpcomponents.httpclient-<VERSION>.jar)
+ Apache HttpClient
+ Copyright 1999-2020 The Apache Software Foundation
+
+Apache HttpCore (lib/org.apache.httpcomponents.httpcore-<VERSION>.jar)
+ Apache HttpCore
+ Copyright 2005-2020 The Apache Software Foundation
Review comment:
I removed the http notices because they're not used by daffodil-debugger. They're in Daffodil's bin.NOTICE only because daffodil-schematron uses Saxon-HE, Saxon-HE uses xml-resolver, and xml-resolver uses these http jars. You have to build the extension and look at daffodil-debugger's libs as the source of truth before you edit bin.LICENSE or bin.NOTICE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org