You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/13 12:57:24 UTC
[GitHub] [airflow] ashb commented on a diff in pull request #22974: Replace usage of `DummyOperator` with `EmptyOperator`
ashb commented on code in PR #22974:
URL: https://github.com/apache/airflow/pull/22974#discussion_r849451006
##########
airflow/providers/dbt/cloud/example_dags/example_dbt_cloud.py:
##########
@@ -22,7 +22,7 @@
try:
from airflow.operators.empty import EmptyOperator as DummyOperator
except ModuleNotFoundError:
- from airflow.operators.dummy import DummyOperator
+ from airflow.operators.dummy import DummyOperator # type: ignore
Review Comment:
I know its a slightly bigger change, but shouldn't we do this as
```suggestion
from airflow.operators.dummy import DummyOperator as EmptyOperator # type: ignore
```
and then change all the uses to `EmptyOperator()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org